From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA090C43214 for ; Wed, 18 Aug 2021 12:00:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C19076104F for ; Wed, 18 Aug 2021 12:00:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234136AbhHRMAx (ORCPT ); Wed, 18 Aug 2021 08:00:53 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3661 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231476AbhHRMAv (ORCPT ); Wed, 18 Aug 2021 08:00:51 -0400 Received: from fraeml709-chm.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4GqRJp6N8vz6BHR9; Wed, 18 Aug 2021 19:59:22 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml709-chm.china.huawei.com (10.206.15.37) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 18 Aug 2021 14:00:15 +0200 Received: from [10.202.227.179] (10.202.227.179) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.8; Wed, 18 Aug 2021 13:00:14 +0100 Subject: Re: [PATCH v2 06/11] blk-mq: Pass driver tags to blk_mq_clear_rq_mapping() To: Ming Lei CC: , , , , , , , References: <1628519378-211232-1-git-send-email-john.garry@huawei.com> <1628519378-211232-7-git-send-email-john.garry@huawei.com> From: John Garry Message-ID: <23448833-593c-139f-6051-9b8e7d3deade@huawei.com> Date: Wed, 18 Aug 2021 13:00:13 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.179] X-ClientProxiedBy: lhreml748-chm.china.huawei.com (10.201.108.198) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >> >> @@ -2346,8 +2345,11 @@ static void blk_mq_clear_rq_mapping(struct blk_mq_tag_set *set, >> void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags, >> unsigned int hctx_idx) >> { >> + struct blk_mq_tags *drv_tags; >> struct page *page; >> >> + drv_tags = set->tags[hctx_idx]; > Hi Ming, > Indent. That's intentional, as we have from later patch: void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags, unsigned int hctx_idx) { struct blk_mq_tags *drv_tags; struct page *page; + if (blk_mq_is_sbitmap_shared(set->flags)) + drv_tags = set->shared_sbitmap_tags; + else drv_tags = set->tags[hctx_idx]; ... blk_mq_clear_rq_mapping(drv_tags, tags); } And it's just nice to not re-indent later. > >> + >> if (tags->static_rqs && set->ops->exit_request) { >> int i; >> >> @@ -2361,7 +2363,7 @@ void blk_mq_free_rqs(struct blk_mq_tag_set *set, struct blk_mq_tags *tags, >> } >> } >> >> - blk_mq_clear_rq_mapping(set, tags, hctx_idx); >> + blk_mq_clear_rq_mapping(drv_tags, tags); > > Maybe you can pass set->tags[hctx_idx] directly since there is only one > reference on it. > Again, intentional for similar reason, as above. Thanks, John