From: Hans Verkuil <hverkuil@xs4all.nl>
To: Joe Perches <joe@perches.com>,
Santiago Hormazabal <santiagohssl@gmail.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Ezequiel Garcia <ezequiel@collabora.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] media: Add support for the AM/FM radio chip KT0913 from KT Micro.
Date: Fri, 17 Jul 2020 12:04:24 +0200 [thread overview]
Message-ID: <234961cc-f783-475c-d3db-69720a7da010@xs4all.nl> (raw)
In-Reply-To: <9bd42f458908eedd810c5e8805f997997763d32a.camel@perches.com>
On 17/07/2020 11:51, Joe Perches wrote:
> On Fri, 2020-07-17 at 11:29 +0200, Hans Verkuil wrote:
>> It's standard linux codingstyle to use lowercase for hex numbers.
>> Can you change that throughout the source for the next version?
>
> Is there a standard? It's not in coding-style.rst.
>
> While I prefer lowercase too, it seems the kernel has
> only ~2:1 preference for lowercase to uppercase hex.
>
> $ git grep -ohP '\b0[xX][0-9a-f]+\b' | grep [a-f] | wc -l
> 1149833
> $ git grep -ohP '\b0[xX][0-9A-F]+\b' | grep [A-F] | wc -l
> 575781
>
>
Well, it's indeed not a standard for the kernel as a whole, but certainly
for drivers/media:
$ git grep -ohP '\b0[xX][0-9a-f]+\b' drivers/media/ | grep [a-f] | wc -l
109272
$ git grep -ohP '\b0[xX][0-9A-F]+\b' drivers/media/ | grep [A-F] | wc -l
22392
The media subsystem has a 5:1 preference for lowercase. And uppercase is
mostly found in older drivers.
Still, I really prefer lowercase over uppercase, especially in new drivers.
Regards,
Hans
next prev parent reply other threads:[~2020-07-17 10:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-17 0:44 [PATCH 0/3] KT091 FM/AM driver Santiago Hormazabal
2020-07-17 0:44 ` [PATCH 1/3] dt-bindings: vendor-prefixes: Add KT Micro Santiago Hormazabal
2020-07-23 20:51 ` Rob Herring
2020-07-17 0:44 ` [PATCH 2/3] media: kt0913: device tree binding Santiago Hormazabal
2020-07-23 20:51 ` Rob Herring
2020-07-17 0:44 ` [PATCH 3/3] media: Add support for the AM/FM radio chip KT0913 from KT Micro Santiago Hormazabal
2020-07-17 9:29 ` Hans Verkuil
2020-07-17 9:51 ` Joe Perches
2020-07-17 10:04 ` Hans Verkuil [this message]
2020-07-17 17:58 ` Joe Perches
2020-07-17 15:10 ` Santiago Hormazabal
2020-08-03 2:09 [PATCH 0/3] KT0913 FM/AM driver Santiago Hormazabal
2020-08-03 2:09 ` [PATCH 3/3] media: Add support for the AM/FM radio chip KT0913 from KT Micro Santiago Hormazabal
2020-08-03 13:05 ` Hans Verkuil
2020-08-03 13:37 ` Santiago Hormazabal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=234961cc-f783-475c-d3db-69720a7da010@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=devicetree@vger.kernel.org \
--cc=ezequiel@collabora.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=santiagohssl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).