From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 234CDC31E5B for ; Tue, 18 Jun 2019 22:24:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EFC8320873 for ; Tue, 18 Jun 2019 22:24:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730807AbfFRWYe (ORCPT ); Tue, 18 Jun 2019 18:24:34 -0400 Received: from mx1.redhat.com ([209.132.183.28]:60588 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730519AbfFRWYe (ORCPT ); Tue, 18 Jun 2019 18:24:34 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7D4D187633; Tue, 18 Jun 2019 22:24:33 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-57.rdu2.redhat.com [10.10.120.57]) by smtp.corp.redhat.com (Postfix) with ESMTP id 72D941001DC3; Tue, 18 Jun 2019 22:24:31 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <155905626142.1662.18430571708534506785.stgit@warthog.procyon.org.uk> <155905627049.1662.17033721577309385838.stgit@warthog.procyon.org.uk> To: Miklos Szeredi Cc: dhowells@redhat.com, Al Viro , Ian Kent , Linux API , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Miklos Szeredi Subject: Re: [PATCH 01/25] vfs: syscall: Add fsinfo() to query filesystem information [ver #13] MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <23582.1560896665.1@warthog.procyon.org.uk> Date: Tue, 18 Jun 2019 23:24:25 +0100 Message-ID: <23583.1560896665@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Tue, 18 Jun 2019 22:24:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Miklos Szeredi wrote: > Please don't resurrect MS_ flags. They are from the old API and > shouldn't be used in the new one. Some of them (e.g. MS_POSIXACL, > MS_I_VERSION) are actually internal flags despite being exported on > the old API. That makes it harder to emulate statfs() using this interface, but ok. I wonder if I should split the standard parameters (rw/ro, posixacl, dirsync, sync, lazytime, mand) out of FSINFO_ATTR_PARAMETERS and stick them in their own attribute, say FSINFO_ATTR_STD_PARAMETERS. That would make it easier for a filesystem to only overload them if it wants to. > And there's SB_SILENT which is simply not a superblock flag and we might be > better getting rid of it entirely. Yeah. It's a parse-time flag. > The proper way to query mount options should be analogous to the way > they are set on the new API: list of {key, type, value, aux} tuples. It's not quite that simple: "aux" might be a datum that you can't recover or is meaningless to another process (an fd, for example). David