[PATCH v2] staging: r8188eu: change declaration of Efuse_Read1ByteFromFakeContent

[PATCH v2] staging: r8188eu: change declaration of Efuse_Read1ByteFromFakeContent

[Phillip Potter]

Remove forward declaration of Efuse_Read1ByteFromFakeContent function
from core/rtw_efuse.c, as the function is defined in full directly
after this and therefore this forward declaration is redundant.

In addition, convert the storage class of the function to static, as the
function is only used with rtw_efuse.c, and tidy up the signature
alignment.

Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
---

V1: Removed forward declaration.
V2: Takes account of feedback from Michael Straube and Fabio M. De
    Francesco to make storage class of the function static.

---
 drivers/staging/r8188eu/core/rtw_efuse.c | 14 +++-----------
 1 file changed, 3 insertions(+), 11 deletions(-)

diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
index decccf7622f0..c1c70648f5bc 100644
--- a/drivers/staging/r8188eu/core/rtw_efuse.c
+++ b/drivers/staging/r8188eu/core/rtw_efuse.c
@@ -29,17 +29,9 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
 #define REG_EFUSE_CTRL		0x0030
 #define EFUSE_CTRL			REG_EFUSE_CTRL		/*  E-Fuse Control. */
 /*  */
-
-bool
-Efuse_Read1ByteFromFakeContent(
-			struct adapter *pAdapter,
-			u16 Offset,
-		u8 *Value);
-bool
-Efuse_Read1ByteFromFakeContent(
-			struct adapter *pAdapter,
-			u16 Offset,
-		u8 *Value)
+static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
+					   u16 Offset,
+					   u8 *Value)
 {
 	if (Offset >= EFUSE_MAX_HW_SIZE)
 		return false;
-- 
2.31.1

Re: [PATCH v2] staging: r8188eu: change declaration of Efuse_Read1ByteFromFakeContent

[Michael Straube]

On 8/21/21 12:56 PM, Phillip Potter wrote:
> Remove forward declaration of Efuse_Read1ByteFromFakeContent function
> from core/rtw_efuse.c, as the function is defined in full directly
> after this and therefore this forward declaration is redundant.
> 
> In addition, convert the storage class of the function to static, as the
> function is only used with rtw_efuse.c, and tidy up the signature
> alignment.
> 
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> 
> V1: Removed forward declaration.
> V2: Takes account of feedback from Michael Straube and Fabio M. De
>      Francesco to make storage class of the function static.
> 
> ---
>   drivers/staging/r8188eu/core/rtw_efuse.c | 14 +++-----------
>   1 file changed, 3 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
> index decccf7622f0..c1c70648f5bc 100644
> --- a/drivers/staging/r8188eu/core/rtw_efuse.c
> +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
> @@ -29,17 +29,9 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
>   #define REG_EFUSE_CTRL		0x0030
>   #define EFUSE_CTRL			REG_EFUSE_CTRL		/*  E-Fuse Control. */
>   /*  */
> -
> -bool
> -Efuse_Read1ByteFromFakeContent(
> -			struct adapter *pAdapter,
> -			u16 Offset,
> -		u8 *Value);
> -bool
> -Efuse_Read1ByteFromFakeContent(
> -			struct adapter *pAdapter,
> -			u16 Offset,
> -		u8 *Value)
> +static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
> +					   u16 Offset,
> +					   u8 *Value)
>   {
>   	if (Offset >= EFUSE_MAX_HW_SIZE)
>   		return false;
> 

Looks good to me.

Acked-by: Michael Straube<straube.linux@gmail.com>


Thanks,

Michael

Re: [PATCH v2] staging: r8188eu: change declaration of Efuse_Read1ByteFromFakeContent

[Fabio M. De Francesco]

On Saturday, August 21, 2021 12:56:15 PM CEST Phillip Potter wrote:
> Remove forward declaration of Efuse_Read1ByteFromFakeContent function
> from core/rtw_efuse.c, as the function is defined in full directly
> after this and therefore this forward declaration is redundant.
> 
> In addition, convert the storage class of the function to static, as the
> function is only used with rtw_efuse.c, and tidy up the signature
> alignment.
> 
> Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> ---
> 
> V1: Removed forward declaration.
> V2: Takes account of feedback from Michael Straube and Fabio M. De
>     Francesco to make storage class of the function static.

Thanks!

Acked-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>

Cheers,

Fabio

Re: [PATCH v2] staging: r8188eu: change declaration of Efuse_Read1ByteFromFakeContent

[Phillip Potter]

On Sat, 21 Aug 2021 at 12:03, Michael Straube <straube.linux@gmail.com> wrote:
>
> On 8/21/21 12:56 PM, Phillip Potter wrote:
> > Remove forward declaration of Efuse_Read1ByteFromFakeContent function
> > from core/rtw_efuse.c, as the function is defined in full directly
> > after this and therefore this forward declaration is redundant.
> >
> > In addition, convert the storage class of the function to static, as the
> > function is only used with rtw_efuse.c, and tidy up the signature
> > alignment.
> >
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > ---
> >
> > V1: Removed forward declaration.
> > V2: Takes account of feedback from Michael Straube and Fabio M. De
> >      Francesco to make storage class of the function static.
> >
> > ---
> >   drivers/staging/r8188eu/core/rtw_efuse.c | 14 +++-----------
> >   1 file changed, 3 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/staging/r8188eu/core/rtw_efuse.c b/drivers/staging/r8188eu/core/rtw_efuse.c
> > index decccf7622f0..c1c70648f5bc 100644
> > --- a/drivers/staging/r8188eu/core/rtw_efuse.c
> > +++ b/drivers/staging/r8188eu/core/rtw_efuse.c
> > @@ -29,17 +29,9 @@ u8 fakeBTEfuseModifiedMap[EFUSE_BT_MAX_MAP_LEN] = {0};
> >   #define REG_EFUSE_CTRL              0x0030
> >   #define EFUSE_CTRL                  REG_EFUSE_CTRL          /*  E-Fuse Control. */
> >   /*  */
> > -
> > -bool
> > -Efuse_Read1ByteFromFakeContent(
> > -                     struct adapter *pAdapter,
> > -                     u16 Offset,
> > -             u8 *Value);
> > -bool
> > -Efuse_Read1ByteFromFakeContent(
> > -                     struct adapter *pAdapter,
> > -                     u16 Offset,
> > -             u8 *Value)
> > +static bool Efuse_Read1ByteFromFakeContent(struct adapter *pAdapter,
> > +                                        u16 Offset,
> > +                                        u8 *Value)
> >   {
> >       if (Offset >= EFUSE_MAX_HW_SIZE)
> >               return false;
> >
>
> Looks good to me.
>
> Acked-by: Michael Straube<straube.linux@gmail.com>
>
>
> Thanks,
>
> Michael

Thanks Michael.

Regards,
Phil

Re: [PATCH v2] staging: r8188eu: change declaration of Efuse_Read1ByteFromFakeContent

[Phillip Potter]

On Sat, 21 Aug 2021 at 13:17, Fabio M. De Francesco
<fmdefrancesco@gmail.com> wrote:
>
> On Saturday, August 21, 2021 12:56:15 PM CEST Phillip Potter wrote:
> > Remove forward declaration of Efuse_Read1ByteFromFakeContent function
> > from core/rtw_efuse.c, as the function is defined in full directly
> > after this and therefore this forward declaration is redundant.
> >
> > In addition, convert the storage class of the function to static, as the
> > function is only used with rtw_efuse.c, and tidy up the signature
> > alignment.
> >
> > Signed-off-by: Phillip Potter <phil@philpotter.co.uk>
> > ---
> >
> > V1: Removed forward declaration.
> > V2: Takes account of feedback from Michael Straube and Fabio M. De
> >     Francesco to make storage class of the function static.
>
> Thanks!
>
> Acked-by: Fabio M. De Francesco <fmdefrancesco@gmail.com>
>
> Cheers,
>
> Fabio
>
>

Thanks Fabio.

Regards,
Phil