From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967168AbdAKOEZ (ORCPT ); Wed, 11 Jan 2017 09:04:25 -0500 Received: from mout.kundenserver.de ([217.72.192.73]:61274 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S967152AbdAKOEX (ORCPT ); Wed, 11 Jan 2017 09:04:23 -0500 From: Arnd Bergmann To: David Howells Cc: Tina Ruchandani , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] afs: correctly use 64-bit time for UUID Date: Wed, 11 Jan 2017 15:03:50 +0100 Message-ID: <2360985.j9pqdKkA3M@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <5338.1484142692@warthog.procyon.org.uk> References: <20170111134436.3877048-1-arnd@arndb.de> <5338.1484142692@warthog.procyon.org.uk> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:R8/5fdG9gJtzJkdWNqqCdTyCBhuTry0GMeW8xj6I2APuk5GZy+2 puksvYmsXKTmaUDNgvysXdoPTE8UbgKRn5+IZmNqClDrTDTsQzIRLcCA1ggipmFZMkGGl5p hYVLPsdE8OGdUIHKZE1IoOrRoyY7qzkqhwXa/+j5y1vcwgrnNjI85GobMWtbEbCPCiwyYUf fiiYYLparsGYhpZW+rONA== X-UI-Out-Filterresults: notjunk:1;V01:K0:hdkeomJE0oc=:IEoESNUHX5JlOPfS4Us5DT Z7kdHreSv0cL9oj85mGMpIOptMfuRgOzRC2x0o36dZvyncVEgL0Z3DI1nQCDAsGCEwW6wiwku /otpTe6zv8DI40pmML7K2OYMCLKo8vyhzBJqS1MAIeV99EsmXXo70XVy6/raH3XuYBXK7ho/r Tq/Ki696K6leRzYXOHnI7aZ5zH+6aN24RhBNUNBC015QShumn/MlPfaIlMSSX5PAm/dcXWSRC CzbdOwJVHvjfG1ShCCyJHl8Uhfli4Q4Jm/ciWaI+sJp9v8dInon4d+Vn3qCoe4oOXk1Yz3QJp wVTu3MnmhtT72y/7j8S7JJjLtwT4xJxnD/LM/2fS5azdLSfPo1i0yQ8ch6AcSr48Hc2lPnz9g FusXcK+1OCz2LQ2+L2CtilnwVQF253aU4lhecqBvOwGVGZcAhz1X47KuN9Iz0GnJ6+cxwLsol HXpxp+t/1XWE6wKpmVM0OCCKhtRDwLxr82vyJNDUDCANq4/KJRrqtvsM3n6smxfqeElNspEMM SIVWDPmdkIY2KHbPyiyptVTOk/TlI28eGckEiVps3EnprlSvR/8g/9peSw/yzADHer5K4jj+T tiMO26O/yygqe10ck1RZ5Wa0vAl6oxpIGc7L2Ifxin0UqOru2T7LfWlkf3uIA3k2K74AlKBAB 3ldBD+b8U+AYQExGGf0lVJuwsnIm0ZhsFdG+mQ4K1IgGlETh9yr5uvfjdTrz01J/fqXdLUNlC lZecee9dNJ2ZUm6X Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wednesday, January 11, 2017 1:51:32 PM CET David Howells wrote: > Arnd Bergmann wrote: > > > From: Tina Ruchandani > > > > UUID calculation uses 'struct timespec' whose seconds will overflow > > in year 2038 and beyond for 32-bit systems. This patch removes the > > dependency on 'struct timespec' by using ktime_get_real(). > > While the patch does not fix a 'bug' as such, it is part of a larger > > effort to remove instances of 'struct timespec' and other data-structures > > suffering from y2038 problem from the kernel. > > Is it worth abstracting out in-kernel UUID generation? Do you mean moving it out of AFS into lib/*.c? I think the 'afs_uuid' structure is quite different from other UUID definitions, so that wouldn't work. Arnd