linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guenter Roeck <linux@roeck-us.net>
To: "Linus Torvalds" <torvalds@linux-foundation.org>,
	"Matthew Auld" <matthew.auld@intel.com>,
	"Arunpravin Paneer Selvam" <Arunpravin.PaneerSelvam@amd.com>,
	"Christian König" <christian.koenig@amd.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Linux 6.8-rc5
Date: Tue, 20 Feb 2024 13:48:07 -0800	[thread overview]
Message-ID: <2374eaeb-fa34-44b9-a945-2cd871aacf7b@roeck-us.net> (raw)
In-Reply-To: <CAHk-=wj6xj_cGmsQK7g=hSfRZZNo-njC+u_1v3dE8fPZtjCBOg@mail.gmail.com>

Actually,

On 2/20/24 11:57, Linus Torvalds wrote:

>> Commit a64056bb5a32 ("drm/tests/drm_buddy: add alloc_contiguous test"):
>>
>> +       u64 mm_size, ps = SZ_4K, i, n_pages, total;
>> ...
>> +       n_pages = mm_size / ps;
> 

Turns out it wasn't this code, but

> Now, the __moddi3() is a *bit* more reasonable, because I assume it comes from
> 
>                  int slot = i % 3;
> 

this code. Sorry, I guess I should have spent more time on it.
Just declaring i as int solves the problem. In my case I used
gcc 11.4. I since also tried with gcc 13.1, but that makes
the problem worse. With that, I get

          U __moddi3
          U __umoddi3
          U __umulsidi3

No idea why a single assignment would result in three undefined
symbols, but there we are. This is with xtensa, but I assume
the same is true for other architectures.

Unfortunately, I can not test your attached patch because the
DRM unit tests blow up my qemu test machines.

Guenter


  parent reply	other threads:[~2024-02-20 21:48 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-18 21:13 Linux 6.8-rc5 Linus Torvalds
2024-02-19  8:07 ` Build regressions/improvements in v6.8-rc5 Geert Uytterhoeven
2024-02-19  9:54   ` Geert Uytterhoeven
2024-02-19  8:12 ` Geert Uytterhoeven
2024-02-20 19:08 ` Linux 6.8-rc5 Guenter Roeck
2024-02-20 19:57   ` Linus Torvalds
2024-02-20 20:16     ` Linus Torvalds
2024-02-20 23:07       ` Shuah Khan
2024-02-20 20:37     ` Linus Torvalds
2024-02-20 20:51     ` Geert Uytterhoeven
2024-02-20 21:48     ` Guenter Roeck [this message]
2024-02-20 22:02       ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2374eaeb-fa34-44b9-a945-2cd871aacf7b@roeck-us.net \
    --to=linux@roeck-us.net \
    --cc=Arunpravin.PaneerSelvam@amd.com \
    --cc=christian.koenig@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew.auld@intel.com \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).