From: "Zhang, Tina" <tina.zhang@intel.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: "intel-gvt-dev@lists.freedesktop.org"
<intel-gvt-dev@lists.freedesktop.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kraxel@redhat.com" <kraxel@redhat.com>,
"zhenyuw@linux.intel.com" <zhenyuw@linux.intel.com>,
"Lv, Zhiyuan" <zhiyuan.lv@intel.com>,
"Wang, Zhi A" <zhi.a.wang@intel.com>,
"Tian, Kevin" <kevin.tian@intel.com>,
"Yuan, Hang" <hang.yuan@intel.com>
Subject: RE: [RFC PATCH v3 1/4] vfio: Define device specific irq type capability
Date: Thu, 27 Jun 2019 08:40:03 +0000 [thread overview]
Message-ID: <237F54289DF84E4997F34151298ABEBC876835C6@SHSMSX101.ccr.corp.intel.com> (raw)
In-Reply-To: <20190626220739.578c518b@x1.home>
> -----Original Message-----
> From: Alex Williamson [mailto:alex.williamson@redhat.com]
> Sent: Thursday, June 27, 2019 12:08 PM
> To: Zhang, Tina <tina.zhang@intel.com>
> Cc: intel-gvt-dev@lists.freedesktop.org; kvm@vger.kernel.org; linux-
> kernel@vger.kernel.org; kraxel@redhat.com; zhenyuw@linux.intel.com; Lv,
> Zhiyuan <zhiyuan.lv@intel.com>; Wang, Zhi A <zhi.a.wang@intel.com>; Tian,
> Kevin <kevin.tian@intel.com>; Yuan, Hang <hang.yuan@intel.com>
> Subject: Re: [RFC PATCH v3 1/4] vfio: Define device specific irq type
> capability
>
> On Thu, 27 Jun 2019 11:37:59 +0800
> Tina Zhang <tina.zhang@intel.com> wrote:
>
> > Cap the number of irqs with fixed indexes and use capability chains to
> > chain device specific irqs.
> >
> > Signed-off-by: Tina Zhang <tina.zhang@intel.com>
> > ---
> > include/uapi/linux/vfio.h | 19 ++++++++++++++++++-
> > 1 file changed, 18 insertions(+), 1 deletion(-)
> >
> > diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h
> > index 02bb7ad6e986..600784acc4ac 100644
> > --- a/include/uapi/linux/vfio.h
> > +++ b/include/uapi/linux/vfio.h
> > @@ -444,11 +444,27 @@ struct vfio_irq_info {
> > #define VFIO_IRQ_INFO_MASKABLE (1 << 1)
> > #define VFIO_IRQ_INFO_AUTOMASKED (1 << 2)
> > #define VFIO_IRQ_INFO_NORESIZE (1 << 3)
> > +#define VFIO_IRQ_INFO_FLAG_CAPS (1 << 4) /* Info
> supports caps */
> > __u32 index; /* IRQ index */
> > + __u32 cap_offset; /* Offset within info struct of first cap */
> > __u32 count; /* Number of IRQs within this index */
> > };
>
>
> This cannot be inserted into the middle of the structure, it breaks
> compatibility with all existing userspace binaries. I must be added to the end
> of the structure.
Indeed. Thanks.
BR,
Tina
>
> > #define VFIO_DEVICE_GET_IRQ_INFO _IO(VFIO_TYPE, VFIO_BASE +
> 9)
> >
> > +/*
> > + * The irq type capability allows irqs unique to a specific device or
> > + * class of devices to be exposed.
> > + *
> > + * The structures below define version 1 of this capability.
> > + */
> > +#define VFIO_IRQ_INFO_CAP_TYPE 3
> > +
> > +struct vfio_irq_info_cap_type {
> > + struct vfio_info_cap_header header;
> > + __u32 type; /* global per bus driver */
> > + __u32 subtype; /* type specific */
> > +};
> > +
> > /**
> > * VFIO_DEVICE_SET_IRQS - _IOW(VFIO_TYPE, VFIO_BASE + 10, struct
> vfio_irq_set)
> > *
> > @@ -550,7 +566,8 @@ enum {
> > VFIO_PCI_MSIX_IRQ_INDEX,
> > VFIO_PCI_ERR_IRQ_INDEX,
> > VFIO_PCI_REQ_IRQ_INDEX,
> > - VFIO_PCI_NUM_IRQS
> > + VFIO_PCI_NUM_IRQS = 5 /* Fixed user ABI, IRQ indexes >=5
> use */
> > + /* device specific cap to define content */
> > };
> >
> > /*
next prev parent reply other threads:[~2019-06-27 8:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-27 3:37 [RFC PATCH v3 0/4] Deliver vGPU display vblank event to userspace Tina Zhang
2019-06-27 3:37 ` [RFC PATCH v3 1/4] vfio: Define device specific irq type capability Tina Zhang
2019-06-27 4:07 ` Alex Williamson
2019-06-27 8:40 ` Zhang, Tina [this message]
2019-06-27 6:19 ` Gerd Hoffmann
2019-06-27 8:55 ` Zhang, Tina
2019-06-27 10:20 ` Gerd Hoffmann
2019-06-27 3:38 ` [RFC PATCH v3 2/4] vfio: Introduce vGPU display irq type Tina Zhang
2019-06-27 6:20 ` Gerd Hoffmann
2019-06-27 9:11 ` Zhang, Tina
2019-06-27 3:38 ` [RFC PATCH v3 3/4] drm/i915/gvt: Register vGPU display vblank irq Tina Zhang
2019-06-27 3:38 ` [RFC PATCH v3 4/4] drm/i915/gvt: Deliver vGPU vblank event to userspace Tina Zhang
2019-06-27 6:22 ` [RFC PATCH v3 0/4] Deliver vGPU display " Gerd Hoffmann
2019-06-27 8:44 ` Zhang, Tina
2019-06-27 10:31 ` Gerd Hoffmann
2019-06-28 3:21 ` Zhenyu Wang
2019-06-28 5:43 ` Gerd Hoffmann
2019-06-28 7:23 ` Zhenyu Wang
2019-06-28 8:44 ` Zhang, Tina
2019-06-28 12:43 ` Zhang, Tina
2019-07-01 3:09 ` Zhenyu Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=237F54289DF84E4997F34151298ABEBC876835C6@SHSMSX101.ccr.corp.intel.com \
--to=tina.zhang@intel.com \
--cc=alex.williamson@redhat.com \
--cc=hang.yuan@intel.com \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=kevin.tian@intel.com \
--cc=kraxel@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.a.wang@intel.com \
--cc=zhiyuan.lv@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).