From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: linaro-kernel@lists.linaro.org, linux-pm@vger.kernel.org,
ashwin.chaugule@linaro.org,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 5/6] cpufreq: governor: replace per-cpu delayed work with timers
Date: Tue, 08 Dec 2015 00:17:18 +0100 [thread overview]
Message-ID: <2389125.q3qMOpRs8O@vostro.rjw.lan> (raw)
In-Reply-To: <3999637.u4UiK7zxOR@vostro.rjw.lan>
On Monday, December 07, 2015 11:43:50 PM Rafael J. Wysocki wrote:
> On Monday, December 07, 2015 01:20:27 PM Viresh Kumar wrote:
> > On 07-12-15, 02:28, Rafael J. Wysocki wrote:
> > > What about if that happens in parallel with the decrementation in
> > > dbs_work_handler()?
> > >
> > > Is there anything preventing that from happening?
> >
> > Hmmm, you are right. Following is required for that.
> >
> > diff --git a/drivers/cpufreq/cpufreq_governor.c b/drivers/cpufreq/cpufreq_governor.c
> > index c9e420bd0eec..d8a89e653933 100644
> > --- a/drivers/cpufreq/cpufreq_governor.c
> > +++ b/drivers/cpufreq/cpufreq_governor.c
> > @@ -230,6 +230,7 @@ static void dbs_work_handler(struct work_struct *work)
> > struct dbs_data *dbs_data;
> > unsigned int sampling_rate, delay;
> > bool eval_load;
> > + unsigned long flags;
> >
> > policy = shared->policy;
> > dbs_data = policy->governor_data;
> > @@ -257,7 +258,10 @@ static void dbs_work_handler(struct work_struct *work)
> > delay = dbs_data->cdata->gov_dbs_timer(policy, eval_load);
> > mutex_unlock(&shared->timer_mutex);
> >
> > + spin_lock_irqsave(&shared->timer_lock, flags);
> > shared->skip_work--;
> > + spin_unlock_irqrestore(&shared->timer_lock, flags);
> > +
> > gov_add_timers(policy, delay);
> > }
>
> OK, so can you please send an updated patch with the above change folded in?
In fact, I've already folded the above changes into the $subject patch (but this
is an exception).
I'll send the "atomic" changes separately.
Thanks,
Rafael
next prev parent reply other threads:[~2015-12-07 22:47 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1449115453.git.viresh.kumar@linaro.org>
2015-12-03 4:07 ` [PATCH V2 1/6] cpufreq: ondemand: Update sampling rate only for concerned policies Viresh Kumar
2015-12-03 4:07 ` [PATCH V2 2/6] cpufreq: ondemand: Work is guaranteed to be pending Viresh Kumar
2015-12-03 4:07 ` [PATCH V2 3/6] cpufreq: governor: Pass policy as argument to ->gov_dbs_timer() Viresh Kumar
2015-12-03 4:07 ` [PATCH V2 4/6] cpufreq: governor: initialize/destroy timer_mutex with 'shared' Viresh Kumar
2015-12-03 4:07 ` [PATCH V2 5/6] cpufreq: governor: replace per-cpu delayed work with timers Viresh Kumar
2015-12-04 1:18 ` Rafael J. Wysocki
2015-12-04 6:11 ` Viresh Kumar
2015-12-05 2:14 ` Rafael J. Wysocki
2015-12-05 4:10 ` Viresh Kumar
2015-12-07 1:28 ` Rafael J. Wysocki
2015-12-07 7:50 ` Viresh Kumar
2015-12-07 22:43 ` Rafael J. Wysocki
2015-12-07 23:17 ` Rafael J. Wysocki [this message]
2015-12-08 0:39 ` [PATCH][experimantal] cpufreq: governor: Use an atomic variable for synchronization Rafael J. Wysocki
2015-12-08 6:59 ` Viresh Kumar
2015-12-08 13:30 ` Rafael J. Wysocki
2015-12-08 13:36 ` Viresh Kumar
2015-12-08 14:19 ` Rafael J. Wysocki
2015-12-08 13:55 ` Viresh Kumar
2015-12-08 14:30 ` Rafael J. Wysocki
2015-12-08 14:56 ` Viresh Kumar
2015-12-08 16:42 ` Rafael J. Wysocki
2015-12-08 16:34 ` Viresh Kumar
2015-12-08 6:46 ` [PATCH V2 5/6] cpufreq: governor: replace per-cpu delayed work with timers Viresh Kumar
2015-12-08 6:56 ` Viresh Kumar
2015-12-08 13:18 ` Rafael J. Wysocki
2015-12-08 13:30 ` Viresh Kumar
2015-12-08 14:04 ` Rafael J. Wysocki
2015-12-04 6:13 ` [PATCH V3 " Viresh Kumar
2015-12-09 2:04 ` [PATCH V4 " Viresh Kumar
2015-12-09 22:06 ` Rafael J. Wysocki
2015-12-10 2:36 ` Viresh Kumar
2015-12-10 22:17 ` Rafael J. Wysocki
2015-12-11 1:42 ` Viresh Kumar
2015-12-03 4:07 ` [PATCH V2 6/6] cpufreq: ondemand: update update_sampling_rate() to make it more efficient Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2389125.q3qMOpRs8O@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=ashwin.chaugule@linaro.org \
--cc=linaro-kernel@lists.linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).