From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751712AbcKGWWL (ORCPT <rfc822;w@1wt.eu>);
        Mon, 7 Nov 2016 17:22:11 -0500
Received: from mout.kundenserver.de ([217.72.192.74]:53609 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751074AbcKGWWI (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 7 Nov 2016 17:22:08 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: Pravin Shelar <pshelar@ovn.org>
Cc: "David S. Miller" <davem@davemloft.net>, Jiri Benc <jbenc@redhat.com>,
        Hannes Frederic Sowa <hannes@stressinduktion.org>,
        Alexander Duyck <aduyck@mirantis.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] vxlan: hide unused local variable
Date: Mon, 07 Nov 2016 23:21:50 +0100
Message-ID: <2394498.yAioIp78MI@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <CAOrHB_BRnCmka_cQ1ALnOC1Yta7c8_KWrQ7tzr2tX2fbvOjs7g@mail.gmail.com>
References: <20161107211017.857340-1-arnd@arndb.de> <CAOrHB_BRnCmka_cQ1ALnOC1Yta7c8_KWrQ7tzr2tX2fbvOjs7g@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:aH+LTUKUhXtVPlo64HzBEd4UoQ+gxwAuzcjlUdB6aW2iBFWHkDs
 1OXKrEiDCUXhFGobNPpxU1KmM7Ns5w33LcEtOTLg0hb0I7J6DUU6VNXG3bOqN4YdA4pq9tK
 oY+QyMj2CrzE4p5Wx4cj5mHQRo4ov5o12JVzwfbcOoba2bZ8DnSR1n8dFiGK3MxkgmaZdh/
 Itr+yQxMzBzXskFiDSXaQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:8FopVQ6+Qrg=:oCtBew1rS2qtF2SlYbAuPV
 uI8gSdZm4Mj4x6lJl/z/6yA0DdWH8y0g3l1zIxAZXn6Fi0MWpavOe0Z4io/4FMLqqK+AKkO4P
 XX1Jb5e+952ILQpDzsxEIrSx1j9qXMSj+NQtlyALWK1PYMK3dqB2x6AWWxN5+e5YR7CJb6fg3
 kE5KfuJdJhSpHdmU8i+8pkJ05/EgfQSykX3si3g+B5ZX05BrUgZEFe37dHZKvfU8VJr25BicG
 vXWQOU/+bfYY3wCyWOZyOhcmTKeLqWx9WB0qWQER3t5vHAfM5Sx8+j2lBE7yrBGS34D4CgxvT
 TsFQgQW6orKsrznkzWi9AuTRwhaH2s1tEQDVjRXWoxUNKtC1zbrcAvxWJS297Q3OPEvssCxdZ
 qBRcLcdMLaO63HMlipBIijnJLrbTmqsOJoqiwhez83hfbQorDODY8695VVtfWx+9EvNqybbMV
 uwI/LWRIzf0pGjBp25hnLLER/RStLOq8ZUdtNwLVp+uD4iTDCKwFJTIqQ8TlGmHutdWYZZGY3
 b1agaNOyRqF+xUEV6C5fIUbmT9E+oF8z8/sm75h6QxWevjZNiTENdUAKullLjhDCJVSouMgZD
 W8Yc8dAKbo6ayO0KFlFnAJv2ntziCLwWDybapzhnck2M3ct6rlhojodnOlG++jpykcbbq9O9m
 x2D4p8g7nRthToIHj4Ash6KU9WV1PBIegbHSy0PqMHwqbEITbs7QrJWwPpGfuSLhX1Obw3U/w
 folscunREWNgSbOj
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Monday, November 7, 2016 2:16:30 PM CET Pravin Shelar wrote:
> On Monday, November 7, 2016, Arnd Bergmann <arnd@arndb.de> wrote:
> 
> > A bugfix introduced a harmless warning in v4.9-rc4:
> >
> > drivers/net/vxlan.c: In function 'vxlan_group_used':
> > drivers/net/vxlan.c:947:21: error: unused variable 'sock6'
> > [-Werror=unused-variable]
> >
> > This hides the variable inside of the same #ifdef that is
> > around its user. The extraneous initialization is removed
> > at the same time, it was accidentally introduced in the
> > same commit.
> >
> > Fixes: c6fcc4fc5f8b ("vxlan: avoid using stale vxlan socket.")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de <javascript:;>>
> > ---
> 
> 
> I have already submitted patch to fix this issue.
> 
> https://patchwork.ozlabs.org/patch/691588/

You have tagged those seven patches for net-next which seems
appropriate, but as I wrote above the commit that introduced
it was merged between -rc3 and -rc4, so I think we still need a
fix for v4.9, right?

	Arnd