From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A836C33CB3 for ; Tue, 14 Jan 2020 15:36:07 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 295CF24672 for ; Tue, 14 Jan 2020 15:36:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="bCRhGJGp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729112AbgANPgF (ORCPT ); Tue, 14 Jan 2020 10:36:05 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:5190 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725904AbgANPgF (ORCPT ); Tue, 14 Jan 2020 10:36:05 -0500 Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 14 Jan 2020 07:35:44 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Tue, 14 Jan 2020 07:36:04 -0800 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Tue, 14 Jan 2020 07:36:04 -0800 Received: from [10.21.133.51] (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 14 Jan 2020 15:36:02 +0000 Subject: Re: [PATCH v4 04/14] dmaengine: tegra-apb: Clean up tasklet releasing To: Dmitry Osipenko , Laxman Dewangan , Vinod Koul , Dan Williams , Thierry Reding , =?UTF-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= CC: , , References: <20200112173006.29863-1-digetx@gmail.com> <20200112173006.29863-5-digetx@gmail.com> From: Jon Hunter Message-ID: <2395e415-c435-0305-b53e-81278ff24d30@nvidia.com> Date: Tue, 14 Jan 2020 15:36:00 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20200112173006.29863-5-digetx@gmail.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1579016144; bh=4nzaSqhuTxBtHcd2ez0EJ4Bfl+5vH4h40EZkwwGBUgA=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=bCRhGJGpIM4zf0HkZYKQe4MwSUQPwKEpXlAxKLWJPIIp/CT1afIFYr0HYE6BWgEzx m9HFHWr9g41QOPxlyoBFcpZ25fLuDO5vb47QTrFtNFIv15WTgNZbVT2io0IIY4FFAC rChsqV8tzUaIGtJ/mjdd+VqZEnKPFxdkKES013iVV8XCkiQDow4oSA/WOjrfYDn3NX /JHzeNXuidGr7MM2A4oA+Qnh79VfoQDCK50tPbYqZMWPRl+KTAquKDRh1WXaJcvzuF vR4ZdEKaGBcQVhWvLyA0VVyNukqnS8igFknhOuqn91X1vRT4yJ3hB9RTbjQD1a+iWr vENEnpNAnkruw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/01/2020 17:29, Dmitry Osipenko wrote: > There is no need to kill tasklet when driver's probe fails because tasklet > can't be scheduled at this time. It is also cleaner to kill tasklet on > channel's freeing rather than to kill it on driver's removal, otherwise > tasklet could perform a dummy execution after channel's releasing, which > isn't very nice. > > Signed-off-by: Dmitry Osipenko > --- > drivers/dma/tegra20-apb-dma.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/dma/tegra20-apb-dma.c b/drivers/dma/tegra20-apb-dma.c > index 24ad3a5a04e3..1b8a11804962 100644 > --- a/drivers/dma/tegra20-apb-dma.c > +++ b/drivers/dma/tegra20-apb-dma.c > @@ -1287,7 +1287,6 @@ static void tegra_dma_free_chan_resources(struct dma_chan *dc) > struct tegra_dma_sg_req *sg_req; > struct list_head dma_desc_list; > struct list_head sg_req_list; > - unsigned long flags; > > INIT_LIST_HEAD(&dma_desc_list); > INIT_LIST_HEAD(&sg_req_list); > @@ -1295,15 +1294,14 @@ static void tegra_dma_free_chan_resources(struct dma_chan *dc) > dev_dbg(tdc2dev(tdc), "Freeing channel %d\n", tdc->id); > > tegra_dma_terminate_all(dc); > + tasklet_kill(&tdc->tasklet); > > - spin_lock_irqsave(&tdc->lock, flags); > list_splice_init(&tdc->pending_sg_req, &sg_req_list); > list_splice_init(&tdc->free_sg_req, &sg_req_list); > list_splice_init(&tdc->free_dma_desc, &dma_desc_list); > INIT_LIST_HEAD(&tdc->cb_desc); > tdc->config_init = false; > tdc->isr_handler = NULL; > - spin_unlock_irqrestore(&tdc->lock, flags); > > while (!list_empty(&dma_desc_list)) { > dma_desc = list_first_entry(&dma_desc_list, > @@ -1542,7 +1540,6 @@ static int tegra_dma_probe(struct platform_device *pdev) > struct tegra_dma_channel *tdc = &tdma->channels[i]; > > free_irq(tdc->irq, tdc); > - tasklet_kill(&tdc->tasklet); > } > > pm_runtime_disable(&pdev->dev); > @@ -1562,7 +1559,6 @@ static int tegra_dma_remove(struct platform_device *pdev) > for (i = 0; i < tdma->chip_data->nr_channels; ++i) { > tdc = &tdma->channels[i]; > free_irq(tdc->irq, tdc); > - tasklet_kill(&tdc->tasklet); > } > > pm_runtime_disable(&pdev->dev); Acked-by: Jon Hunter Cheers Jon -- nvpublic