Re: [PATCH v27 00/10] NTFS read-write driver GPL implementation by Paragon Software

From: Yan Pashkovsky <yanp.bugz@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>, "Darrick J. Wong" <djwong@kernel.org>
Cc: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
	linux-kernel@vger.kernel.org, pali@kernel.org, dsterba@suse.cz,
	aaptel@suse.com, willy@infradead.org, rdunlap@infradead.org,
	joe@perches.com, mark@harmstone.com, nborisov@suse.com,
	linux-ntfs-dev@lists.sourceforge.net, anton@tuxera.com,
	dan.carpenter@oracle.com, hch@lst.de, ebiggers@kernel.org,
	andy.lavr@gmail.com, kari.argillander@gmail.com,
	oleksandr@natalenko.name
Subject: Re: [PATCH v27 00/10] NTFS read-write driver GPL implementation by Paragon Software
Date: Sat, 21 Aug 2021 15:38:30 +0300	[thread overview]
Message-ID: <2399771e-8222-267d-1655-c84a1401f2cd@gmail.com> (raw)
In-Reply-To: <YQdlJM6ngxPoeq4U@mit.edu>

> Konstantin, I would *strongly* encourage you to try running fstests,
> about 60 seconds into a run, we discover that generic/013 will trigger
> locking problems that could lead to deadlocks.

Seems like it's a real issue. I was using new HDD and ntfs3-dkms (v26) 
in Arch and faced locking while was doing rsync:

[ 5529.507567] INFO: task kworker/0:1:18 blocked for more than 1105 seconds.
[ 5529.507580]       Tainted: P           OE     5.13.4-arch1-1 #1
[ 5529.507584] "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" 
disables this message.
[ 5529.507586] task:kworker/0:1     state:D stack:    0 pid:   18 ppid: 
     2 flags:0x00004000
[ 5529.507598] Workqueue: usb_hub_wq hub_event
[ 5529.507612] Call Trace:
[ 5529.507615]  ? out_of_line_wait_on_bit_lock+0xb0/0xb0
[ 5529.507631]  __schedule+0x310/0x930
[ 5529.507641]  ? out_of_line_wait_on_bit_lock+0xb0/0xb0
[ 5529.507648]  schedule+0x5b/0xc0
[ 5529.507654]  bit_wait+0xd/0x60
[ 5529.507661]  __wait_on_bit+0x2a/0x90
[ 5529.507669]  __inode_wait_for_writeback+0xb0/0xe0
[ 5529.507680]  ? var_wake_function+0x20/0x20
[ 5529.507689]  writeback_single_inode+0x64/0x140
[ 5529.507699]  sync_inode_metadata+0x3d/0x60
[ 5529.507712]  ntfs_set_state+0x126/0x1a0 [ntfs3]
[ 5529.507738]  ni_write_inode+0x244/0xef0 [ntfs3]
[ 5529.507764]  ? pagevec_lookup_range_tag+0x24/0x30
[ 5529.507772]  ? __filemap_fdatawait_range+0x6f/0xf0
[ 5529.507785]  __writeback_single_inode+0x260/0x310
[ 5529.507795]  writeback_single_inode+0xa7/0x140
[ 5529.507803]  sync_inode_metadata+0x3d/0x60
[ 5529.507814]  ntfs_set_state+0x126/0x1a0 [ntfs3]
[ 5529.507834]  ntfs_sync_fs+0xf9/0x100 [ntfs3]
[ 5529.507857]  sync_filesystem+0x40/0x90
[ 5529.507868]  fsync_bdev+0x21/0x60
[ 5529.507874]  delete_partition+0x13/0x80
[ 5529.507882]  blk_drop_partitions+0x5b/0xa0
[ 5529.507889]  del_gendisk+0xa5/0x220
[ 5529.507895]  sd_remove+0x3d/0x80
[ 5529.507907]  __device_release_driver+0x17a/0x230
[ 5529.507918]  device_release_driver+0x24/0x30
[ 5529.507927]  bus_remove_device+0xdb/0x140
[ 5529.507937]  device_del+0x18b/0x400
[ 5529.507943]  ? ata_tlink_match+0x30/0x30
[ 5529.507949]  ? attribute_container_device_trigger+0xc5/0x100
[ 5529.507959]  __scsi_remove_device+0x118/0x150
[ 5529.507967]  scsi_forget_host+0x54/0x60
[ 5529.507978]  scsi_remove_host+0x72/0x110
[ 5529.507988]  usb_stor_disconnect+0x46/0xb0 [usb_storage]
[ 5529.508003]  usb_unbind_interface+0x8a/0x270
[ 5529.508010]  ? kernfs_find_ns+0x35/0xd0
[ 5529.508017]  __device_release_driver+0x17a/0x230
[ 5529.508027]  device_release_driver+0x24/0x30
[ 5529.508036]  bus_remove_device+0xdb/0x140
[ 5529.508044]  device_del+0x18b/0x400
[ 5529.508050]  ? kobject_put+0x98/0x1d0
[ 5529.508062]  usb_disable_device+0xc6/0x1f0
[ 5529.508073]  usb_disconnect.cold+0x7e/0x250
[ 5529.508085]  hub_event+0xc7b/0x17f0
[ 5529.508099]  process_one_work+0x1e3/0x3b0
[ 5529.508109]  worker_thread+0x50/0x3b0
[ 5529.508115]  ? process_one_work+0x3b0/0x3b0
[ 5529.508122]  kthread+0x133/0x160
[ 5529.508127]  ? set_kthread_struct+0x40/0x40
[ 5529.508133]  ret_from_fork+0x22/0x30

[ 8440.627659] blk_update_request: I/O error, dev sdd, sector 256017240 
op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0
[ 8440.627667] ntfs3: 165 callbacks suppressed
[ 8440.627667] ntfs3: sdd1: failed to read volume at offset 0x1e84f6b000
[ 8440.627673] blk_update_request: I/O error, dev sdd, sector 256017240 
op 0x0:(READ) flags 0x0 phys_seg 1 prio class 0
[ 8440.627676] ntfs3: sdd1: failed to read volume at offset 0x1e84f6b000
[ 8440.778355] blk_update_request: I/O error, dev sdd, sector 6293496 op 
0x0:(READ) flags 0x0 phys_seg 1 prio class 0
[ 8440.778384] ntfs3: sdd1: failed to read volume at offset 0xbffff000
[ 8440.778412] blk_update_request: I/O error, dev sdd, sector 6353096 op 
0x0:(READ) flags 0x0 phys_seg 1 prio class 0
[ 8440.778428] ntfs3: sdd1: failed to read volume at offset 0xc1d19000
[ 8440.778441] blk_update_request: I/O error, dev sdd, sector 6353096 op 
0x0:(READ) flags 0x0 phys_seg 1 prio class 0
[ 8440.778452] ntfs3: sdd1: failed to read volume at offset 0xc1d19000
[ 8440.778459] ntfs3: sdd1: ntfs_evict_inode r=0 failed, -22.