From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 064BCC433F5 for ; Mon, 23 May 2022 18:37:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240662AbiEWShE (ORCPT ); Mon, 23 May 2022 14:37:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36970 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S241548AbiEWSf4 (ORCPT ); Mon, 23 May 2022 14:35:56 -0400 Received: from mail-oi1-x22b.google.com (mail-oi1-x22b.google.com [IPv6:2607:f8b0:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BA9A315D31D for ; Mon, 23 May 2022 11:15:40 -0700 (PDT) Received: by mail-oi1-x22b.google.com with SMTP id r68so4569366oie.12 for ; Mon, 23 May 2022 11:15:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=zzofvizuF8zNiK4IN4+SAjhbde0gMJTVr1Nmbjv6AbQ=; b=XLOC+ypgI8cKaE9CDgVvdF8PKbjyzLSoTo3x9MsYzQL2PZAqHEzHlGHIxhtbdbp0mH +huFu7/Vq3CUekJB3lNHifVzr+zBFnIkd/aQ3BCB9TjQlOeuB9BzvB4CREai2swuV9BV Pizs3aRQMv+PwgitC0E2zF3arst/BqNQvGz8k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=zzofvizuF8zNiK4IN4+SAjhbde0gMJTVr1Nmbjv6AbQ=; b=321v795Z4VFtiEL9zE/26mCrTeHByzK9VBP9jb0YcHjyiiM7aCHSY+aeRUto2HXmW3 +NDBevYSbZSzx50KLra71Sy3kFq9slITDNkc3jRKvaK8BTMAnlF23QtfR2isN9o0DGwf IM4I74UaZgYjnsa3gOLKpXuyh9jD0QV53gOBrIlbrn1ZrbGqjQIH0b2X0NN86b36IjNm mjSq9ali+Q7y/BceaWxXKl7CojW1sDzR6NIczCixhtWeXL0DpEM+K/qDEHPSun7NFw+E 2e94A6g5mDuKnAFqPXXbIViIunTgWk+QA01hg69fgoRiYy+JOIV/gMO3QwxEaWuvyRXM X5ow== X-Gm-Message-State: AOAM531Z2bBvUuN102IMux75T9OUFw0918/Lfkyi+FmzCIz2VM6oHPTQ Q4+/8ebTeassMbXjQsWzKgaoLXfOewKjXw== X-Google-Smtp-Source: ABdhPJxDOIhMiU07IFlHUIqUQmUxxDSxZUqXiGUN1FyXxfn5p8WiK+DycZ7bCA0CEw1YNOoiiJbylw== X-Received: by 2002:a05:6808:ec7:b0:322:2bcc:42c2 with SMTP id q7-20020a0568080ec700b003222bcc42c2mr176401oiv.168.1653329644614; Mon, 23 May 2022 11:14:04 -0700 (PDT) Received: from [192.168.1.128] ([38.15.45.1]) by smtp.gmail.com with ESMTPSA id g6-20020aca3906000000b00325cda1ffb5sm4294539oia.52.2022.05.23.11.14.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 May 2022 11:14:04 -0700 (PDT) Subject: Re: [PATCH v7 04/25] kunit: take `kunit_assert` as `const` To: Daniel Latypov , Miguel Ojeda Cc: Linus Torvalds , Greg Kroah-Hartman , rust-for-linux@vger.kernel.org, linux-kernel@vger.kernel.org, Jarkko Sakkinen , Brendan Higgins , linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Shuah Khan References: <20220523020209.11810-1-ojeda@kernel.org> <20220523020209.11810-5-ojeda@kernel.org> From: Shuah Khan Message-ID: <23e4e7b4-bd09-b186-093b-a436ee9cb649@linuxfoundation.org> Date: Mon, 23 May 2022 12:14:02 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/23/22 11:15 AM, Daniel Latypov wrote: > On Sun, May 22, 2022 at 7:03 PM Miguel Ojeda wrote: >> >> The `kunit_do_failed_assertion` function passes its >> `struct kunit_assert` argument to `kunit_fail`. This one, >> in turn, calls its `format` field passing the assert again >> as a `const` pointer. >> >> Therefore, the whole chain may be made `const`. >> >> Reviewed-by: Daniel Latypov >> Reviewed-by: Brendan Higgins >> Signed-off-by: Miguel Ojeda >> --- >> This is a prerequisite patch, independently submitted at: >> >> https://lore.kernel.org/lkml/20220502093625.GA23225@kernel.org/ > > FYI, we'd asked Shuah to pick this patch up in her "kunit" branch. > It's applied here: > https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git/commit/?h=kunit&id=7466886b400b1904ce30fa311904849e314a2cf4 > > It had previously seemed unclear if this series could make it for the > 5.19 merge window (but it now looks like there's interest in trying it > out early on). > > Daniel > I am just about send pull request with this patch included. thanks, -- Shuah