linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <Crag.Wang@dell.com>
To: <Mario.Limonciello@dell.com>, <crag0715@gmail.com>, <sre@kernel.org>
Cc: <mathewk@chromium.org>, <linux-pm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] power_supply: wilco_ec: Add permanent long life charging mode
Date: Wed, 24 Jun 2020 03:51:38 +0000	[thread overview]
Message-ID: <23e76b5eda0849fdb4e1ef8b81807558@KULX13MDC113.APAC.DELL.COM> (raw)
In-Reply-To: <05bbf37785bd44ce8cc8777f107b16ff@AUSX13MPC105.AMER.DELL.COM>

> > > Since this is normally only done in the factory context, can you
> > > please confirm does something need to be artificially done to block
> > > userland from trying to set the battery charging to this mode?  Or
> > > will the EC already
> > handle
> > > blocking it directly?
> >
> > This is a feature of the battery, when the EC receives this setting it
> > will be sent to the battery and stored there. Afterwards any attempt
> > to change this mode will return a failure.
> 
> Sorry this still isn't clear to me.  You're saying that if EC receives longlife
> setting it will be able to do this in the field?  If so, then I think this patch will
> need to block that setting to not allow field conversions into longlife mode.
> 
EC does handle blocking the attempts from changing the mode.

EC reads current mode ahead of a new setting. If it sees permanent long life
already in use then any attempt to put the battery charging in a different mode
will get failure 0x01 from EC.

> >
> > It's even better to block mode selection in the userland if long life
> > mode already in use.
> 
> Yes, I agree.  This sounds like a good follow up to me too.


  reply	other threads:[~2020-06-24  3:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-23  8:20 [PATCH 1/1] power_supply: wilco_ec: Add permanent long life charging mode Crag Wang
2020-06-23 13:48 ` Mario.Limonciello
2020-06-23 15:50   ` Crag.Wang
2020-06-23 18:59     ` Mario.Limonciello
2020-06-24  3:51       ` Crag.Wang [this message]
2020-07-08  2:33         ` Crag.Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=23e76b5eda0849fdb4e1ef8b81807558@KULX13MDC113.APAC.DELL.COM \
    --to=crag.wang@dell.com \
    --cc=Mario.Limonciello@dell.com \
    --cc=crag0715@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=mathewk@chromium.org \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).