From: Pavel Emelyanov <xemul@virtuozzo.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
Adrian Reber <adrian@lisas.de>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Oleg Nesterov <oleg@redhat.com>,
Andrei Vagin <avagin@virtuozzo.com>,
Hendrik Brueckner <brueckner@linux.vnet.ibm.com>,
Cyrill Gorcunov <gorcunov@openvz.org>,
Kees Cook <keescook@chromium.org>,
Linux Containers <containers@lists.linux-foundation.org>
Subject: Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE
Date: Fri, 13 Jul 2018 11:35:50 +0300 [thread overview]
Message-ID: <23f87cb4-cdf5-0f9c-c7b9-a0abb228b77f@virtuozzo.com> (raw)
In-Reply-To: <87sh4o5s82.fsf@xmission.com>
On 07/12/2018 07:33 PM, Eric W. Biederman wrote:
>
> Adrian Reber <adrian@lisas.de> writes:
>
>> The CHECKPOINT_RESTORE configuration option was introduced in 2012 and
>> combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many
>> distribution kernels and also part of the defconfigs of various
>> architectures.
>>
>> To make it easier for distributions to enable CHECKPOINT_RESTORE this
>> removes EXPERT and moves the configuration option out of the EXPERT
>> block.
>
> I think we should change the help text at the same time, to match
> our improve understanding of the situation.
>
> Does anyone remember why this option was added at all?
Sure! Quoting Andrew's ~7 years ago akpm branch merge e-mail:
However I'm less confident than the developers that it will all
eventually work! So what I'm asking them to do is to wrap each piece
of new code inside CONFIG_CHECKPOINT_RESTORE. So if it all
eventually comes to tears and the project as a whole fails, it should
be a simple matter to go through and delete all trace of it.
the best link with full e-mail I googled for is
https://gitlab.imag.fr/kaunetem/linux-kaunetem/commit/099469502f62fbe0d7e4f0b83a2f22538367f734
-- Pavel
> Why this option was placed under expert?
>
> What is the value of disabling this functionality ever?
>
> Is there any reason why we don't just delete CONFIG_CHECKPOINT_RESTORE
> entirely?
>
> Certainly we are at a point where distro's are enabling this so hiding
> it behind CONFIG_EXPERT with a default of N seems inapparopriate.
>
> The only thing I can imagine might be sensible is changing the default
> to Y and leaving it behind CONFIG_EXPERT.
>
> I want to know what is the point of maintaining all of the complexity of
> the ifdefs. If no one can come up with a reason I say let's just remove
> CONFIG_CHECKPOINT_RESTORE entirely.
>
> Eric
>
>
>> Signed-off-by: Adrian Reber <adrian@lisas.de>
>> Cc: Oleg Nesterov <oleg@redhat.com>
>> Cc: Pavel Emelyanov <xemul@virtuozzo.com>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: Eric W. Biederman <ebiederm@xmission.com>
>> Cc: Andrei Vagin <avagin@virtuozzo.com>
>> Cc: Hendrik Brueckner <brueckner@linux.vnet.ibm.com>
>> ---
>> init/Kconfig | 24 ++++++++++++------------
>> 1 file changed, 12 insertions(+), 12 deletions(-)
>>
>> diff --git a/init/Kconfig b/init/Kconfig
>> index 041f3a022122..9c529c763326 100644
>> --- a/init/Kconfig
>> +++ b/init/Kconfig
>> @@ -932,6 +932,18 @@ config NET_NS
>>
>> endif # NAMESPACES
>>
>> +config CHECKPOINT_RESTORE
>> + bool "Checkpoint/restore support"
>> + select PROC_CHILDREN
>> + default n
>> + help
>> + Enables additional kernel features in a sake of checkpoint/restore.
>> + In particular it adds auxiliary prctl codes to setup process text,
>> + data and heap segment sizes, and a few additional /proc filesystem
>> + entries.
>> +
>> + If unsure, say N here.
>> +
>> config SCHED_AUTOGROUP
>> bool "Automatic process group scheduling"
>> select CGROUPS
>> @@ -1348,18 +1360,6 @@ config MEMBARRIER
>>
>> If unsure, say Y.
>>
>> -config CHECKPOINT_RESTORE
>> - bool "Checkpoint/restore support" if EXPERT
>> - select PROC_CHILDREN
>> - default n
>> - help
>> - Enables additional kernel features in a sake of checkpoint/restore.
>> - In particular it adds auxiliary prctl codes to setup process text,
>> - data and heap segment sizes, and a few additional /proc filesystem
>> - entries.
>> -
>> - If unsure, say N here.
>> -
>> config KALLSYMS
>> bool "Load all symbols for debugging/ksymoops" if EXPERT
>> default y
> .
>
next prev parent reply other threads:[~2018-07-13 8:36 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-12 13:07 [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE Adrian Reber
2018-07-12 13:47 ` Oleg Nesterov
2018-07-12 13:47 ` Hendrik Brueckner
2018-07-12 13:51 ` Alice Frosi
2018-07-12 16:33 ` Eric W. Biederman
2018-07-13 8:35 ` Pavel Emelyanov [this message]
2018-07-13 13:46 ` Eric W. Biederman
2018-07-13 14:20 ` Adrian Reber
2018-07-13 20:55 ` Andrew Morton
2018-07-14 4:44 ` Kees Cook
2018-07-14 6:02 ` Josh Triplett
2018-07-14 19:04 ` Eric W. Biederman
2018-07-14 19:10 ` Josh Triplett
2018-07-14 19:39 ` Eric W. Biederman
2018-07-14 20:16 ` Josh Triplett
2018-07-14 20:19 ` Cyrill Gorcunov
2018-07-13 8:23 ` Pavel Emelyanov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=23f87cb4-cdf5-0f9c-c7b9-a0abb228b77f@virtuozzo.com \
--to=xemul@virtuozzo.com \
--cc=adrian@lisas.de \
--cc=akpm@linux-foundation.org \
--cc=avagin@virtuozzo.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=containers@lists.linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=gorcunov@openvz.org \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).