From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94F3FC43331 for ; Mon, 30 Mar 2020 19:11:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6573C2072E for ; Mon, 30 Mar 2020 19:11:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="RjKlM4R0" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728056AbgC3TLk (ORCPT ); Mon, 30 Mar 2020 15:11:40 -0400 Received: from lelv0142.ext.ti.com ([198.47.23.249]:57088 "EHLO lelv0142.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726672AbgC3TLk (ORCPT ); Mon, 30 Mar 2020 15:11:40 -0400 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 02UJBJV0008882; Mon, 30 Mar 2020 14:11:19 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1585595479; bh=OrBnsE/3/0anybmi3bMddb1VVqlFWSwjkIBSJYVW05Y=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=RjKlM4R00TJm33VjHZMQzMYAxJIEzrBtJlG3fN+/D2y/niBX7vQ/+aAgI6rQBLVlt bgvW7cGD7SlvNHjelAKjDqY5FcH9mHDOrZdTJ0ArTO3Co9UxodXGh8e7IG8SYkgZCG /1y5qfspLXncuzF6bxU0yN454DjEQbv9sVxhEuvk= Received: from DFLE100.ent.ti.com (dfle100.ent.ti.com [10.64.6.21]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTP id 02UJBI1s059606; Mon, 30 Mar 2020 14:11:19 -0500 Received: from DFLE107.ent.ti.com (10.64.6.28) by DFLE100.ent.ti.com (10.64.6.21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Mon, 30 Mar 2020 14:11:18 -0500 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Mon, 30 Mar 2020 14:11:18 -0500 Received: from [10.250.86.212] (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 02UJBH2Y126560; Mon, 30 Mar 2020 14:11:18 -0500 Subject: Re: [PATCH] remoteproc: remove rproc_elf32_sanity_check To: Mathieu Poirier , Clement Leger CC: Ohad Ben-Cohen , Bjorn Andersson , Patrice Chotard , Maxime Coquelin , Alexandre Torgue , , , , References: <20200327084939.8321-1-cleger@kalray.eu> <20200327161733.GA18041@xps15> From: Suman Anna Message-ID: <23fc7800-4ba4-07d0-de15-d81498f04d3c@ti.com> Date: Mon, 30 Mar 2020 14:11:17 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20200327161733.GA18041@xps15> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Clement, On 3/27/20 11:17 AM, Mathieu Poirier wrote: > On Fri, Mar 27, 2020 at 09:49:39AM +0100, Clement Leger wrote: >> Since checks are present in the remoteproc elf loader before calling >> da_to_va, loading a elf64 will work on 32bits flavors of kernel. >> Indeed, if a segment size is larger than what size_t can hold, the >> loader will return an error so the functionality is equivalent to >> what exists today. >> >> Signed-off-by: Clement Leger >> --- >> drivers/remoteproc/remoteproc_core.c | 2 +- >> drivers/remoteproc/remoteproc_elf_loader.c | 21 --------------------- >> drivers/remoteproc/remoteproc_internal.h | 1 - >> drivers/remoteproc/st_remoteproc.c | 2 +- >> drivers/remoteproc/st_slim_rproc.c | 2 +- >> drivers/remoteproc/stm32_rproc.c | 2 +- >> 6 files changed, 4 insertions(+), 26 deletions(-) > > Reviewed-by: Mathieu Poirier > >> >> diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c >> index a9ac1d01e09b..02ff076b0122 100644 >> --- a/drivers/remoteproc/remoteproc_core.c >> +++ b/drivers/remoteproc/remoteproc_core.c >> @@ -2069,7 +2069,7 @@ struct rproc *rproc_alloc(struct device *dev, const char *name, >> rproc->ops->parse_fw = rproc_elf_load_rsc_table; >> rproc->ops->find_loaded_rsc_table = rproc_elf_find_loaded_rsc_table; >> if (!rproc->ops->sanity_check) >> - rproc->ops->sanity_check = rproc_elf32_sanity_check; >> + rproc->ops->sanity_check = rproc_elf_sanity_check; Do you still need the capability to override the sanity_check? As I understand, you introduced this to allow platform drivers to use the appropriate elf32 or elf64 one during the ELF64 loader support series. regards Suman >> rproc->ops->get_boot_addr = rproc_elf_get_boot_addr; >> } >> >> diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c >> index 16e2c496fd45..29034f99898d 100644 >> --- a/drivers/remoteproc/remoteproc_elf_loader.c >> +++ b/drivers/remoteproc/remoteproc_elf_loader.c >> @@ -112,27 +112,6 @@ int rproc_elf_sanity_check(struct rproc *rproc, const struct firmware *fw) >> } >> EXPORT_SYMBOL(rproc_elf_sanity_check); >> >> -/** >> - * rproc_elf_sanity_check() - Sanity Check ELF32 firmware image >> - * @rproc: the remote processor handle >> - * @fw: the ELF32 firmware image >> - * >> - * Make sure this fw image is sane. >> - */ >> -int rproc_elf32_sanity_check(struct rproc *rproc, const struct firmware *fw) >> -{ >> - int ret = rproc_elf_sanity_check(rproc, fw); >> - >> - if (ret) >> - return ret; >> - >> - if (fw_elf_get_class(fw) == ELFCLASS32) >> - return 0; >> - >> - return -EINVAL; >> -} >> -EXPORT_SYMBOL(rproc_elf32_sanity_check); >> - >> /** >> * rproc_elf_get_boot_addr() - Get rproc's boot address. >> * @rproc: the remote processor handle >> diff --git a/drivers/remoteproc/remoteproc_internal.h b/drivers/remoteproc/remoteproc_internal.h >> index b389dc79da81..31994715fd43 100644 >> --- a/drivers/remoteproc/remoteproc_internal.h >> +++ b/drivers/remoteproc/remoteproc_internal.h >> @@ -54,7 +54,6 @@ void *rproc_da_to_va(struct rproc *rproc, u64 da, size_t len); >> phys_addr_t rproc_va_to_pa(void *cpu_addr); >> int rproc_trigger_recovery(struct rproc *rproc); >> >> -int rproc_elf32_sanity_check(struct rproc *rproc, const struct firmware *fw); >> int rproc_elf_sanity_check(struct rproc *rproc, const struct firmware *fw); >> u64 rproc_elf_get_boot_addr(struct rproc *rproc, const struct firmware *fw); >> int rproc_elf_load_segments(struct rproc *rproc, const struct firmware *fw); >> diff --git a/drivers/remoteproc/st_remoteproc.c b/drivers/remoteproc/st_remoteproc.c >> index a6cbfa452764..a3268d95a50e 100644 >> --- a/drivers/remoteproc/st_remoteproc.c >> +++ b/drivers/remoteproc/st_remoteproc.c >> @@ -233,7 +233,7 @@ static const struct rproc_ops st_rproc_ops = { >> .parse_fw = st_rproc_parse_fw, >> .load = rproc_elf_load_segments, >> .find_loaded_rsc_table = rproc_elf_find_loaded_rsc_table, >> - .sanity_check = rproc_elf32_sanity_check, >> + .sanity_check = rproc_elf_sanity_check, >> .get_boot_addr = rproc_elf_get_boot_addr, >> }; >> >> diff --git a/drivers/remoteproc/st_slim_rproc.c b/drivers/remoteproc/st_slim_rproc.c >> index 3cca8b65a8db..09bcb4d8b9e0 100644 >> --- a/drivers/remoteproc/st_slim_rproc.c >> +++ b/drivers/remoteproc/st_slim_rproc.c >> @@ -203,7 +203,7 @@ static const struct rproc_ops slim_rproc_ops = { >> .da_to_va = slim_rproc_da_to_va, >> .get_boot_addr = rproc_elf_get_boot_addr, >> .load = rproc_elf_load_segments, >> - .sanity_check = rproc_elf32_sanity_check, >> + .sanity_check = rproc_elf_sanity_check, >> }; >> >> /** >> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c >> index 6a66dbf2df40..2e07a95439c8 100644 >> --- a/drivers/remoteproc/stm32_rproc.c >> +++ b/drivers/remoteproc/stm32_rproc.c >> @@ -505,7 +505,7 @@ static struct rproc_ops st_rproc_ops = { >> .load = rproc_elf_load_segments, >> .parse_fw = stm32_rproc_parse_fw, >> .find_loaded_rsc_table = rproc_elf_find_loaded_rsc_table, >> - .sanity_check = rproc_elf32_sanity_check, >> + .sanity_check = rproc_elf_sanity_check, >> .get_boot_addr = rproc_elf_get_boot_addr, >> }; >> >> -- >> 2.17.1 >>