From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
Cc: Lee Jones <lee.jones@linaro.org>,
Vladimir Zapolskiy <vz@mleia.com>,
Linus Walleij <linus.walleij@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Marek Vasut <marek.vasut@gmail.com>,
Wolfram Sang <wsa@the-dreams.de>,
devicetree@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver
Date: Fri, 12 Oct 2018 16:07:16 +0300 [thread overview]
Message-ID: <2403149.qmrOGLNKPu@avalon> (raw)
In-Reply-To: <3b22c550-0cba-60d7-a8ed-400265c8a9f6@mentor.com>
Hi Vladimir,
On Friday, 12 October 2018 14:24:08 EEST Vladimir Zapolskiy wrote:
> On 10/12/2018 11:39 AM, Lee Jones wrote:
> > On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote:
> >> On 10/12/2018 09:03 AM, Lee Jones wrote:
> >>> On Tue, 09 Oct 2018, Vladimir Zapolskiy wrote:
> >>>> From: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
> >>>>
> >>>> The change adds I2C device driver for TI DS90Ux9xx de-/serializers,
> >>>> support of subdevice controllers is done in separate drivers, because
> >>>> not all IC functionality may be needed in particular situations, and
> >>>> this can be fine grained controlled in device tree.
> >>>>
> >>>> The development of the driver was a collaborative work, the
> >>>> contribution done by Balasubramani Vivekanandan includes:
> >>>> * original implementation of the driver based on a reference driver,
> >>>> * regmap powered interrupt controller support on serializers,
> >>>> * support of implicitly or improperly specified in device tree ICs,
> >>>> * support of device properties and attributes: backward compatible
> >>>>
> >>>> mode, low frequency operation mode, spread spectrum clock generator.
> >>>>
> >>>> Contribution by Steve Longerbeam:
> >>>> * added ds90ux9xx_read_indirect() function,
> >>>> * moved number of links property and added ds90ux9xx_num_fpd_links(),
> >>>> * moved and updated ds90ux9xx_get_link_status() function to core
> >>>> driver,
> >>>> * added fpd_link_show device attribute.
> >>>>
> >>>> Sandeep Jain added support of pixel clock edge configuration.
> >>>>
> >>>> Signed-off-by: Vladimir Zapolskiy <vladimir_zapolskiy@mentor.com>
> >>>> ---
> >>>>
> >>>> drivers/mfd/Kconfig | 14 +
> >>>> drivers/mfd/Makefile | 1 +
> >>>> drivers/mfd/ds90ux9xx-core.c | 879 ++++++++++++++++++++++++++++++++++
> >>>> include/linux/mfd/ds90ux9xx.h | 42 ++
> >>>> 4 files changed, 936 insertions(+)
> >>>> create mode 100644 drivers/mfd/ds90ux9xx-core.c
> >>>> create mode 100644 include/linux/mfd/ds90ux9xx.h
> >>>>
> >>>> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> >>>> index 8c5dfdce4326..a969fa123f64 100644
> >>>> --- a/drivers/mfd/Kconfig
> >>>> +++ b/drivers/mfd/Kconfig
> >>>> @@ -1280,6 +1280,20 @@ config MFD_DM355EVM_MSP
> >>>>
> >>>> boards. MSP430 firmware manages resets and power sequencing,
> >>>> inputs from buttons and the IR remote, LEDs, an RTC, and more.
> >>>>
> >>>> +config MFD_DS90UX9XX
> >>>> + tristate "TI DS90Ux9xx FPD-Link de-/serializer driver"
> >>>> + depends on I2C && OF
> >>>> + select MFD_CORE
> >>>> + select REGMAP_I2C
> >>>> + help
> >>>> + Say yes here to enable support for TI DS90UX9XX de-/serializer
ICs.
> >>>> +
> >>>> + This driver provides basic support for setting up the
> >>>> de-/serializer
> >>>> + chips. Additional functionalities like connection handling to
> >>>> + remote de-/serializers, I2C bridging, pin multiplexing, GPIO
> >>>> + controller and so on are provided by separate drivers and should
> >>>> + enabled individually.
> >>>
> >>> This is not an MFD driver.
> >>
> >> Why do you think so? The representation of the ICs into device tree
> >> format of hardware description shows that this is a truly MFD driver with
> >> multiple IP subcomponents naturally mapped into MFD cells.
> >
> > This driver does too much real work ('stuff') to be an MFD driver.
> > MFD drivers should not need to care of; links, gates, modes, pixels,
> > frequencies maps or properties. Nor should they contain elaborate
> > sysfs structures to control the aforementioned 'stuff'.
>
> What is the reason why device drivers for sort of multimedia ICs like
> WL1273, WM8994 and other numerous codecs are found in drivers/mfd?
I won't comment on those because I don't know them (Lee might have a better
knowledge in this area), but let's not rule out historical mistakes, that we
may not want to repeat.
> If the same reason can not be applied to this DS90Ux9xx driver, why?
>
> > Granted, there may be some code in there which could be appropriate
> > for an MFD driver. However most of it needs moving out into a
> > function driver (or two).
> >
> >> Basically it is possible to replace explicit of_platform_populate() by
> >> adding a "simple-mfd" compatible, if it is desired.
> >>
> >>> After a 30 second Google of what this device actually does, perhaps
> >>> drivers/media might be a better fit?
> >>
> >> I assume it would be quite unusual to add a driver with NO media
> >> functions and controls into drivers/media.
> >
> > drivers/media may very well not be the correct place for this. In my
> > 30 second Google, I saw that this device has a lot to do with cameras,
> > hence my media association.
>
> Well, the argument is similar to the statement that Google says that
> camera sensors *can* be connected to NXP i.MX6 SoC, thus arch/arm/mach-imx
> contents should be placed into drivers/media
If there are any camera drivers in arch/arm/mach-imx, they should certainly be
moved.
> A few TI DS90Ux9xx *cell* drivers may be added to drivers/media, but it is
> out of the scope of the current series, which is completely integral per se,
> and actually the cover letter says that the series of drivers immediately
> allows to output video over DRM to panels, but the discussion is around
> sensors by some reason.
Possibly because a quick search for more information about the device returned
camera use cases. Let's not focus on that.
> But I hope it won't be seen as a misleading reason to consider to add the
> MFD driver into drivers/gpu/drm
Not a misleading one, a very good one :-) This should go in drivers/gpu/drm/
bridge/.
> > If *all* else fails, there is always drivers/misc, but this should be
> > avoided if at all possible.
>
> drivers/misc does not sound like a proper place for the MFD driver...
drivers/misc/ isn't right either.
> >> Laurent, can you please share your opinion?
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-10-12 13:07 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 21:11 [PATCH 0/7] mfd/pinctrl: add initial support of TI DS90Ux9xx ICs Vladimir Zapolskiy
2018-10-08 21:11 ` [PATCH 1/7] dt-bindings: mfd: ds90ux9xx: add description " Vladimir Zapolskiy
2018-10-09 0:13 ` Marek Vasut
2018-10-09 11:11 ` Vladimir Zapolskiy
2018-10-09 20:55 ` Vladimir Zapolskiy
2018-10-09 21:03 ` Marek Vasut
2018-10-10 8:41 ` Linus Walleij
2018-10-12 11:44 ` Laurent Pinchart
2018-10-13 14:28 ` Vladimir Zapolskiy
2018-10-16 12:30 ` Laurent Pinchart
2018-10-30 16:43 ` Luca Ceresoli
2018-10-30 23:40 ` Vladimir Zapolskiy
2018-10-08 21:12 ` [PATCH 2/7] dt-bindings: mfd: ds90ux9xx: add description of TI DS90Ux9xx I2C bridge Vladimir Zapolskiy
2018-10-12 11:54 ` Laurent Pinchart
2018-10-30 16:43 ` Luca Ceresoli
2018-10-31 20:12 ` Vladimir Zapolskiy
2018-11-03 21:00 ` Luca Ceresoli
2018-11-03 22:07 ` Vladimir Zapolskiy
2018-10-08 21:12 ` [PATCH 3/7] dt-bindings: pinctrl: ds90ux9xx: add description of TI DS90Ux9xx pinmux Vladimir Zapolskiy
2018-10-10 8:45 ` Linus Walleij
2018-10-17 15:02 ` Rob Herring
2018-10-12 12:01 ` Laurent Pinchart
2018-10-13 13:47 ` Vladimir Zapolskiy
2018-10-16 12:48 ` Laurent Pinchart
2018-10-30 16:44 ` Luca Ceresoli
2018-10-31 20:31 ` Vladimir Zapolskiy
2018-10-08 21:12 ` [PATCH 4/7] mfd: ds90ux9xx: add TI DS90Ux9xx de-/serializer MFD driver Vladimir Zapolskiy
2018-10-09 4:08 ` kbuild test robot
2018-10-09 11:14 ` Vladimir Zapolskiy
2018-10-12 6:03 ` Lee Jones
2018-10-12 7:41 ` Vladimir Zapolskiy
2018-10-12 8:39 ` Lee Jones
2018-10-12 9:20 ` Kieran Bingham
2018-10-12 10:58 ` Vladimir Zapolskiy
2018-10-12 11:34 ` Lee Jones
2018-10-12 14:13 ` Vladimir Zapolskiy
2018-10-12 14:25 ` Lee Jones
2018-10-12 11:47 ` Kieran Bingham
2018-10-12 13:01 ` Laurent Pinchart
2018-10-12 13:59 ` Vladimir Zapolskiy
2018-10-16 13:08 ` Laurent Pinchart
2018-10-23 8:16 ` Vladimir Zapolskiy
2018-10-30 16:44 ` Luca Ceresoli
2018-10-13 15:10 ` Vladimir Zapolskiy
2018-10-16 13:12 ` Laurent Pinchart
2018-10-16 18:32 ` Vladimir Zapolskiy
2018-10-13 12:33 ` Vladimir Zapolskiy
2018-10-12 11:24 ` Vladimir Zapolskiy
2018-10-12 11:43 ` Lee Jones
2018-10-12 14:23 ` Vladimir Zapolskiy
2018-10-12 13:07 ` Laurent Pinchart [this message]
2018-10-08 21:12 ` [PATCH 5/7] mfd: ds90ux9xx: add I2C bridge/alias and link connection driver Vladimir Zapolskiy
2018-10-12 6:04 ` Lee Jones
2018-10-12 7:32 ` Vladimir Zapolskiy
2018-10-12 9:03 ` Lee Jones
2018-10-12 13:12 ` Laurent Pinchart
2018-10-12 14:36 ` Vladimir Zapolskiy
2018-10-16 14:06 ` Laurent Pinchart
2018-10-08 21:12 ` [PATCH 6/7] pinctrl: ds90ux9xx: add TI DS90Ux9xx pinmux and GPIO controller driver Vladimir Zapolskiy
2018-10-10 9:04 ` Linus Walleij
2018-10-08 21:12 ` [PATCH 7/7] MAINTAINERS: add entry for TI DS90Ux9xx FPD-Link III drivers Vladimir Zapolskiy
2018-10-12 11:34 ` [PATCH 0/7] mfd/pinctrl: add initial support of TI DS90Ux9xx ICs Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2403149.qmrOGLNKPu@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=marek.vasut@gmail.com \
--cc=robh+dt@kernel.org \
--cc=vladimir_zapolskiy@mentor.com \
--cc=vz@mleia.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).