From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0928CC2D0CE for ; Tue, 21 Jan 2020 10:45:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0A3A24653 for ; Tue, 21 Jan 2020 10:45:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729491AbgAUKpK (ORCPT ); Tue, 21 Jan 2020 05:45:10 -0500 Received: from bhuna.collabora.co.uk ([46.235.227.227]:47134 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727220AbgAUKpK (ORCPT ); Tue, 21 Jan 2020 05:45:10 -0500 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id ED66F293365 Message-ID: <241033bf82fc7e955dd20c0084bfd4f6fc9fc75b.camel@collabora.com> Subject: Re: [PATCH 1/4] media: rockchip/rga: add rk3228-rga to rockchip_rga_match[] From: Ezequiel Garcia To: Justin Swartz , Jacob Chen , Mauro Carvalho Chehab , Heiko Stuebner Cc: linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Date: Tue, 21 Jan 2020 07:45:01 -0300 In-Reply-To: <20200120194158.25357-1-justin.swartz@risingedge.co.za> References: <20200120194158.25357-1-justin.swartz@risingedge.co.za> Organization: Collabora Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2020-01-20 at 19:41 +0000, Justin Swartz wrote: > Add an entry to the rockchip_rga_match array for "rockchip,rk3228-rga" > > Signed-off-by: Justin Swartz > --- > drivers/media/platform/rockchip/rga/rga.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/media/platform/rockchip/rga/rga.c b/drivers/media/platform/rockchip/rga/rga.c > index e9ff12b6b..268116cd5 100644 > --- a/drivers/media/platform/rockchip/rga/rga.c > +++ b/drivers/media/platform/rockchip/rga/rga.c > @@ -956,6 +956,9 @@ static const struct dev_pm_ops rga_pm = { > > static const struct of_device_id rockchip_rga_match[] = { > { > + .compatible = "rockchip,rk3228-rga", > + }, Unless you need to tune something in the driver specifically for rk3228, then you don't need a new compatible string. As the name implies, it's just a "compatible", so you may simply declare your rga dts node as compatible to "rockchip,rk3288-rga". (Of course, this means we shouldn't have added the rk3399 compatible string.) Regards, Ezequiel