From: Brad Campbell <brad@fnarfbargle.com>
To: Andreas Kemnade <andreas@kemnade.info>,
Guenter Roeck <linux@roeck-us.net>,
Jean Delvare <jdelvare@suse.com>
Cc: Arnd Bergmann <arnd@arndb.de>,
rydberg@bitmath.org, linux-hwmon@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
hns@goldelico.com
Subject: Re: [REGRESSION] hwmon: (applesmc) avoid overlong udelay()
Date: Thu, 5 Nov 2020 13:18:03 +1100 [thread overview]
Message-ID: <2436afef-99c6-c352-936d-567bf553388c@fnarfbargle.com> (raw)
In-Reply-To: <20201104142057.62493c12@aktux>
On 5/11/20 12:20 am, Andreas Kemnade wrote:
> On Tue, 3 Nov 2020 16:56:32 +1100
> Brad Campbell <brad@fnarfbargle.com> wrote:
>> If anyone with a Mac having a conventional SMC and seeing issues on 5.9 could test this it'd be appreciated. I'm not saying this code is "correct", but it "works for me".
>>
> Seems to work here.
> dmesg | grep applesmc
>
> [ 1.350782] applesmc: key=561 fan=1 temp=33 index=33 acc=0 lux=2 kbd=1
> [ 1.350922] applesmc applesmc.768: hwmon_device_register() is deprecated. Please convert the driver to use hwmon_device_register_with_info().
> [ 17.748504] applesmc: wait_status looping 2: 0x4a, 0x4c, 0x4f
> [ 212.008952] applesmc: wait_status looping 2: 0x44, 0x40, 0x4e
> [ 213.033930] applesmc: wait_status looping 2: 0x44, 0x40, 0x4e
> [ 213.167908] applesmc: wait_status looping 2: 0x44, 0x40, 0x4e
> [ 219.087854] applesmc: wait_status looping 2: 0x44, 0x40, 0x4e
>
> Tested it on top of 5.9
Much appreciated Andreas.
I'm not entirely sure where to go from here. I'd really like some wider testing before cleaning this up and submitting it. It puts extra checks & constraints on the comms with the SMC that weren't there previously.
I guess given there doesn't appear to have been a major outcry that the driver broke in 5.9 might indicate that nobody is using it, or that it only broke on certain machines?
Can we get some guidance from the hwmon maintainers on what direction they'd like to take? I don't really want to push this forward without broader testing only to find it breaks a whole heap of machines on the basis that it fixes mine.
Regards,
Brad
next prev parent reply other threads:[~2020-11-05 2:20 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 8:54 [REGRESSION] hwmon: (applesmc) avoid overlong udelay() Andreas Kemnade
2020-09-30 16:44 ` Guenter Roeck
2020-09-30 20:00 ` Arnd Bergmann
2020-10-01 22:22 ` Andreas Kemnade
2020-10-02 4:07 ` Guenter Roeck
2020-10-06 7:02 ` Andreas Kemnade
2020-11-02 23:56 ` Brad Campbell
2020-11-03 5:56 ` Brad Campbell
2020-11-04 13:20 ` Andreas Kemnade
2020-11-05 2:18 ` Brad Campbell [this message]
2020-11-05 4:22 ` Brad Campbell
2020-11-05 4:43 ` Guenter Roeck
2020-11-05 5:05 ` Brad Campbell
2020-11-05 5:26 ` Guenter Roeck
2020-11-05 5:47 ` [PATCH] applesmc: Re-work SMC comms v1 Brad Campbell
2020-11-05 7:26 ` [PATCH] applesmc: Re-work SMC comms v2 Brad Campbell
2020-11-05 7:56 ` Henrik Rydberg
2020-11-05 8:15 ` Andreas Kemnade
2020-11-05 8:30 ` Brad Campbell
2020-11-05 10:31 ` Henrik Rydberg
2020-11-06 16:26 ` Henrik Rydberg
2020-11-06 20:02 ` Henrik Rydberg
2020-11-07 18:31 ` Henrik Rydberg
2020-11-08 0:09 ` Brad Campbell
2020-11-08 8:22 ` Henrik Rydberg
2020-11-08 1:00 ` [PATCH v3] applesmc: Re-work SMC comms Brad Campbell
2020-11-08 8:35 ` Henrik Rydberg
2020-11-08 10:14 ` Henrik Rydberg
2020-11-08 11:57 ` Brad Campbell
2020-11-08 12:04 ` Henrik Rydberg
2020-11-09 13:06 ` Brad Campbell
2020-11-09 17:08 ` Henrik Rydberg
2020-11-09 22:52 ` Brad Campbell
2020-11-08 16:06 ` Guenter Roeck
2020-11-09 0:25 ` Brad Campbell
2020-11-10 2:04 ` Brad Campbell
2020-11-10 4:55 ` Guenter Roeck
2020-11-10 5:40 ` Brad Campbell
2020-11-10 16:02 ` Guenter Roeck
2020-11-09 8:44 ` Andreas Kemnade
2020-11-09 9:51 ` Brad Campbell
2020-11-11 3:37 ` [PATCH v4 0/1] " Brad Campbell
2020-11-11 4:55 ` [PATCH v1] applesmc: Cleanups on top of re-work comms Brad Campbell
2020-11-11 3:38 ` [PATCH v4 1/1] applesmc: Re-work SMC comms Brad Campbell
2020-11-11 5:56 ` Guenter Roeck
2020-11-11 7:05 ` Brad Campbell
2020-11-11 13:06 ` [PATCH v5 " Brad Campbell
2020-11-11 20:05 ` Henrik Rydberg
2020-11-11 23:28 ` Brad Campbell
2020-11-12 3:08 ` [PATCH v6 " Brad Campbell
2020-11-12 17:20 ` Guenter Roeck
2020-11-06 23:11 ` [PATCH] applesmc: Re-work SMC comms v2 Brad Campbell
2020-11-05 8:12 ` Andreas Kemnade
2020-11-05 16:12 ` Guenter Roeck
2020-11-06 0:02 ` Brad Campbell
2020-11-06 3:08 ` Guenter Roeck
2020-11-09 9:27 ` [PATCH] applesmc: Re-work SMC comms v1 kernel test robot
2020-11-05 9:48 ` [REGRESSION] hwmon: (applesmc) avoid overlong udelay() Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2436afef-99c6-c352-936d-567bf553388c@fnarfbargle.com \
--to=brad@fnarfbargle.com \
--cc=andreas@kemnade.info \
--cc=arnd@arndb.de \
--cc=hns@goldelico.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).