From: "Teres Alexis, Alan Previn" <alan.previn.teres.alexis@intel.com>
To: "airlied@linux.ie" <airlied@linux.ie>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"joonas.lahtinen@linux.intel.com"
<joonas.lahtinen@linux.intel.com>,
"Usyskin, Alexander" <alexander.usyskin@intel.com>,
"tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
"jani.nikula@linux.intel.com" <jani.nikula@linux.intel.com>
Cc: "Winkler, Tomas" <tomas.winkler@intel.com>,
"intel-gfx@lists.freedesktop.org"
<intel-gfx@lists.freedesktop.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Lubart, Vitaly" <vitaly.lubart@intel.com>
Subject: Re: [v5,13/14] drm/i915/gsc: allocate extended operational memory in LMEM
Date: Tue, 2 Aug 2022 17:29:36 +0000 [thread overview]
Message-ID: <243c92cee65c256c4c8003052f73944e9486a3ff.camel@intel.com> (raw)
In-Reply-To: <20220706114345.1128018-14-alexander.usyskin@intel.com>
Looks good, just a minor nit.
Reviewed-by: Alan Previn <alan.previn.teres.alexis@intel.com>
On Wed, 2022-07-06 at 14:43 +0300, Alexander Usyskin wrote:
> From: Tomas Winkler <tomas.winkler@intel.com>
>
> GSC requires more operational memory than available on chip.
> Reserve 4M of LMEM for GSC operation. The memory is provided to the
> GSC as struct resource to the auxiliary data of the child device.
>
> Cc: Alan Previn <alan.previn.teres.alexis@intel.com>
> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com>
> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com>
> ---
> drivers/gpu/drm/i915/gt/intel_gsc.c | 92 ++++++++++++++++++++++++++---
> drivers/gpu/drm/i915/gt/intel_gsc.h | 3 +
> 2 files changed, 88 insertions(+), 7 deletions(-)
>
> + if (def->lmem_size) {
> + dev_dbg(&pdev->dev, "setting up GSC lmem\n");
>
NIT: Any reason we are not being consistent and using drm_err / drm_debug (same below)? either way, ensuring we get PCI
device id info in the dmesg output we are good.
> +
> + if (gsc_ext_om_alloc(gsc, intf, def->lmem_size)) {
> + dev_err(&pdev->dev, "setting up gsc extended operational memory failed\n");
> + kfree(adev);
> + goto fail;
> + }
> +
> + adev->ext_op_mem.start = i915_gem_object_get_dma_address(intf->gem_obj, 0);
> + adev->ext_op_mem.end = adev->ext_op_mem.start + def->lmem_size;
> + }
> +
next prev parent reply other threads:[~2022-08-02 17:29 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 11:43 [PATCH v5 00/14] GSC support for XeHP SDV and DG2 platforms Alexander Usyskin
2022-07-06 11:43 ` [PATCH v5 01/14] drm/i915/gsc: skip irq initialization if using polling Alexander Usyskin
2022-07-06 11:43 ` [PATCH v5 02/14] drm/i915/gsc: add slow_fw flag to the mei auxiliary device Alexander Usyskin
2022-07-07 15:21 ` Rodrigo Vivi
2022-07-18 13:47 ` Winkler, Tomas
2022-07-06 11:43 ` [PATCH v5 03/14] drm/i915/gsc: add slow_fw flag to the gsc device definition Alexander Usyskin
2022-07-06 11:43 ` [PATCH v5 04/14] drm/i915/gsc: add GSC XeHP SDV platform definition Alexander Usyskin
2022-07-06 11:43 ` [PATCH v5 05/14] mei: gsc: use polling instead of interrupts Alexander Usyskin
2022-07-06 11:43 ` [PATCH v5 06/14] mei: gsc: wait for reset thread on stop Alexander Usyskin
2022-07-06 11:43 ` [PATCH v5 07/14] mei: extend timeouts on slow devices Alexander Usyskin
2022-07-06 11:43 ` [PATCH v5 08/14] mei: bus: export common mkhi definitions into a separate header Alexander Usyskin
2022-07-06 11:43 ` [PATCH v5 09/14] mei: mkhi: add memory ready command Alexander Usyskin
2022-07-06 11:43 ` [PATCH v5 10/14] mei: gsc: setup gsc extended operational memory Alexander Usyskin
2022-07-06 11:43 ` [PATCH v5 11/14] mei: gsc: add transition to PXP mode in resume flow Alexander Usyskin
2022-07-06 11:43 ` [PATCH v5 12/14] mei: debugfs: add pxp mode to devstate in debugfs Alexander Usyskin
2022-07-06 11:43 ` [PATCH v5 13/14] drm/i915/gsc: allocate extended operational memory in LMEM Alexander Usyskin
2022-08-02 17:29 ` Teres Alexis, Alan Previn [this message]
2022-08-02 18:49 ` [v5,13/14] " Winkler, Tomas
2022-07-06 11:43 ` [PATCH v5 14/14] HAX: drm/i915: force INTEL_MEI_GSC on for CI Alexander Usyskin
2022-07-08 13:34 ` [PATCH v5 00/14] GSC support for XeHP SDV and DG2 platforms Greg Kroah-Hartman
2022-07-08 13:57 ` Rodrigo Vivi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=243c92cee65c256c4c8003052f73944e9486a3ff.camel@intel.com \
--to=alan.previn.teres.alexis@intel.com \
--cc=airlied@linux.ie \
--cc=alexander.usyskin@intel.com \
--cc=daniel@ffwll.ch \
--cc=gregkh@linuxfoundation.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=jani.nikula@linux.intel.com \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
--cc=tomas.winkler@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
--cc=vitaly.lubart@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).