From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756307AbdDGXBa (ORCPT ); Fri, 7 Apr 2017 19:01:30 -0400 Received: from gloria.sntech.de ([95.129.55.99]:50202 "EHLO gloria.sntech.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbdDGXBX (ORCPT ); Fri, 7 Apr 2017 19:01:23 -0400 From: Heiko Stuebner To: Kever Yang , Will Deacon Cc: linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, Jianqun Xu , Liang Chen , Brian Norris , linux-kernel@vger.kernel.org, Andy Yan , Rob Herring , linux-arm-kernel@lists.infradead.org, Mark Rutland , Catalin Marinas , Matthias Brugger Subject: Re: [PATCH v2 1/2] arm64: dts: rk3399: add support for firefly-rk3399 board Date: Sat, 08 Apr 2017 01:01:07 +0200 Message-ID: <2449203.Hv4EZXJUvX@phil> User-Agent: KMail/5.2.3 (Linux/4.9.0-2-amd64; KDE/5.28.0; x86_64; ; ) In-Reply-To: <1491384800-22412-1-git-send-email-kever.yang@rock-chips.com> References: <1491384800-22412-1-git-send-email-kever.yang@rock-chips.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Kever, Am Mittwoch, 5. April 2017, 17:33:19 CEST schrieb Kever Yang: > Firefly-rk3399 is a bord from T-Firefly, you can find detail about > it here: > http://en.t-firefly.com/en/firenow/Firefly_RK3399/ > > This patch add basic node for the board and make it able to bring > up. > > Peripheral works: > - usb hub which connect to ehci controller; > - UART2 debug > - eMMC > - PCIe > > Not work: > - USB 3.0 HOST, type-C port > - sdio, sd-card > > Not test for other peripheral: > - HDMI > - Ethernet > - OPTICAL > - WiFi/BT > - MIPI CSI/DSI > - IR > - EDP/DP > > Signed-off-by: Kever Yang [...] > + vdd_log: vdd-log { > + compatible = "pwm-regulator"; > + pwms = <&pwm2 0 25000 1>; > + regulator-name = "vdd_log"; > + regulator-min-microvolt = <800000>; > + regulator-max-microvolt = <1400000>; > + regulator-always-on; > + regulator-boot-on; > + > + /* for rockchip boot on */ > + rockchip,pwm_id= <2>; > + rockchip,pwm_voltage = <1000000>; Vendor-kernel stuff, needs to be dropped [...] > +&i2c0 { > + status = "okay"; > + i2c-scl-rising-time-ns = <168>; > + i2c-scl-falling-time-ns = <4>; > + clock-frequency = <400000>; > + > + vdd_cpu_b: pmic@40 { > + compatible = "silergy,syr827"; > + reg = <0x40>; > + vin-supply = <&vcc5v0_sys>; > + regulator-compatible = "fan53555-reg"; > + regulator-name = "vdd_cpu_b"; > + regulator-min-microvolt = <712500>; > + regulator-max-microvolt = <1500000>; > + regulator-ramp-delay = <1000>; > + vsel-gpios = <&gpio1 RK_PC2 GPIO_ACTIVE_HIGH>; non-mainline property > + fcs,suspend-voltage-selector = <0>; > + regulator-always-on; > + regulator-boot-on; > + regulator-initial-state = <3>; non-mainline property > + regulator-state-mem { indentation is wrong > + regulator-off-in-suspend; > + }; > + }; > + > + vdd_gpu: syr828@41 { > + compatible = "silergy,syr828"; > + reg = <0x41>; > + vin-supply = <&vcc5v0_sys>; > + regulator-compatible = "fan53555-reg"; > + regulator-name = "vdd_gpu"; > + regulator-min-microvolt = <712500>; > + regulator-max-microvolt = <1500000>; > + regulator-ramp-delay = <1000>; > + fcs,suspend-voltage-selector = <1>; > + regulator-always-on; > + regulator-boot-on; > + regulator-initial-state = <3>; non-mainline property > + regulator-state-mem { indentation is wrong > + regulator-off-in-suspend; > + }; > + }; > + > + rk808: pmic@1b { > + compatible = "rockchip,rk808"; > + reg = <0x1b>; > + interrupt-parent = <&gpio1>; > + interrupts = <21 IRQ_TYPE_LEVEL_LOW>; > + pinctrl-names = "default"; > + pinctrl-0 = <&pmic_int_l>; > + rockchip,system-power-controller; system-power-controller without the "rockchip,"? > + wakeup-source; > + #clock-cells = <1>; > + clock-output-names = "xin32k", "rk808-clkout2"; [...] > +&i2c1 { > + status = "okay"; > + i2c-scl-rising-time-ns = <300>; > + i2c-scl-falling-time-ns = <15>; > + > + gsl3673: gsl3673@40 { gsl3673: touchscreen@40 > + compatible = "GSL,GSL3673"; compatible lowercase? > + reg = <0x40>; > + screen_max_x = <1536>; > + screen_max_y = <2048>; > + irq_gpio_number = <&gpio1 RK_PC4 IRQ_TYPE_LEVEL_LOW>; > + rst_gpio_number = <&gpio4 RK_PC6 GPIO_ACTIVE_HIGH>; > + }; > + > + rt5640: rt5640@1c { > + #sound-dai-cells = <0>; > + compatible = "realtek,rt5640"; > + reg = <0x1c>; > + clocks = <&cru SCLK_I2S_8CH_OUT>; > + clock-names = "mclk"; > + realtek,in1-differential; > + pinctrl-names = "default"; > + pinctrl-0 = <&rt5640_hpcon>; > + hp-con-gpio = <&gpio4 RK_PC5 GPIO_ACTIVE_HIGH>; > + io-channels = <&saradc 4>; > + hp-det-adc-value = <500>; these last 3 properties are not contained in the rt5640 binding document on linux-next-20170407 . > + }; > +}; > + > +&i2c3 { > + status = "okay"; > + i2c-scl-rising-time-ns = <450>; > + i2c-scl-falling-time-ns = <15>; > +}; > + > +&i2c4 { > + status = "okay"; > + i2c-scl-rising-time-ns = <600>; > + i2c-scl-falling-time-ns = <20>; > + > + fusb0: fusb30x@22 { fusb0: usb-typec@22 or so Also that device is not in mainline yet, so has no approved binding so should not be included right now. > + compatible = "fairchild,fusb302"; > + reg = <0x22>; > + pinctrl-names = "default"; > + pinctrl-0 = <&fusb0_int>; > + int-n-gpios = <&gpio1 RK_PA2 GPIO_ACTIVE_HIGH>; > + vbus-5v-gpios = <&gpio2 RK_PA0 GPIO_ACTIVE_HIGH>; > + status = "okay"; > + }; > + > + mpu6500@68 { accelerometer@68 > + status = "okay"; > + compatible = "invensense,mpu6500"; > + reg = <0x68>; > + irq-gpio = <&gpio1 RK_PC6 IRQ_TYPE_EDGE_RISING>; > + mpu-int_config = <0x10>; > + mpu-level_shifter = <0>; > + mpu-orientation = <0 1 0 1 0 0 0 0 1>; > + orientation-x= <1>; > + orientation-y= <0>; > + orientation-z= <0>; > + mpu-debug = <1>; > + }; > +}; > + [...] > +&u2phy0 { > + status = "okay"; > + extcon = <&fusb0>; see comment for fusb302 > + > + u2phy0_otg: otg-port { > + status = "okay"; > + }; > + > + u2phy0_host: host-port { > + phy-supply = <&vcc5v0_host>; > + status = "okay"; > + }; > +}; > + Heiko