linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "jianchao.wang" <jianchao.w.wang@oracle.com>
To: axboe@kernel.dk
Cc: ming.lei@redhat.com, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH V4 0/5] blk-mq: refactor and fix on issue request directly
Date: Tue, 6 Nov 2018 09:37:48 +0800	[thread overview]
Message-ID: <24495fec-ab19-abc2-d5e8-2734d4f67fcb@oracle.com> (raw)
In-Reply-To: <1541142536-1431-1-git-send-email-jianchao.w.wang@oracle.com>

Would anyone please take a look at this ?

Thanks
Jianchao

On 11/2/18 3:08 PM, Jianchao Wang wrote:
> Hi Jens
> 
> These patch set refactors the code of issueing request driectly and
> fix some defects.
> 
> The 1st patch make __blk_mq_issue_directly be able to accept NULL cookie
> pointer.
> 
> The 2nd patch refactors the code of issue request directly.
> It merges the blk_mq_try_issue_directly and __blk_mq_try_issue_directly
> and make it handle the return value of .queue_rq itself.
> 
> The 3rd patch let the requests be inserted into hctx->dispatch when
> the queue is stopped or quiesced if bypass is true.
> 
> The 4th patch make blk_mq_sched_insert_requests issue requests directly
> with 'bypass' false, then it needn't to handle the non-issued requests
> any more.
> 
> The 5th patch ensures the hctx to be ran on its mapped cpu in issue directly
> path.
> 
> V4:
>  - split the original patch 1 into two patches, 1st and 2nd patch currently
>  - rename the mq_decision to mq_issue_decision
>  - comment changes
> 
> V3:
>  - Correct the code about the case bypass_insert is true and io scheduler
>    attached. The request still need to be issued in case above. (1/4)
>  - Refactor the code to make code clearer. blk_mq_make_request is introduced
>    to decide insert, end or just return based on the return value of .queue_rq
>    and bypass_insert (1/4) 
>  - Add the 2nd patch. It introduce a new decision result which indicates to
>    insert request with blk_mq_request_bypass_insert.
>  - Modify the code to adapt the new patch 1.
> 
> V2:
>  - Add 1st and 2nd patch
> 
> Jianchao Wang (5)
> blk-mq: make __blk_mq_issue_directly be able to accept
> blk-mq: refactor the code of issue request directly
> blk-mq: fix issue directly case when q is stopped or
> blk-mq: issue directly with bypass 'false' in
> blk-mq: ensure hctx to be ran on mapped cpu when issue
> 
>  block/blk-mq-sched.c |   8 ++-
>  block/blk-mq.c       | 149 ++++++++++++++++++++++++++++++---------------------
>  2 files changed, 92 insertions(+), 65 deletions(-)
> 
> Thanks
> Jianchao
> 

      parent reply	other threads:[~2018-11-06  1:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-02  7:08 Jianchao Wang
2018-11-02  7:08 ` [PATCH V4 1/5] blk-mq: make __blk_mq_issue_directly be able to accept NULL cookie pointer Jianchao Wang
2018-11-02  7:08 ` [PATCH V4 2/5] blk-mq: refactor the code of issue request directly Jianchao Wang
2018-11-02  7:08 ` [PATCH V4 3/5] blk-mq: fix issue directly case when q is stopped or quiesced Jianchao Wang
2018-11-02  7:08 ` [PATCH V4 4/5] blk-mq: issue directly with bypass 'false' in blk_mq_sched_insert_requests Jianchao Wang
2018-11-02  7:08 ` [PATCH V4 5/5] blk-mq: ensure hctx to be ran on mapped cpu when issue directly Jianchao Wang
2018-11-06  1:37 ` jianchao.wang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24495fec-ab19-abc2-d5e8-2734d4f67fcb@oracle.com \
    --to=jianchao.w.wang@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ming.lei@redhat.com \
    --subject='Re: [PATCH V4 0/5] blk-mq: refactor and fix on issue request directly' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).