From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751975AbaCAHsw (ORCPT ); Sat, 1 Mar 2014 02:48:52 -0500 Received: from mx1.redhat.com ([209.132.183.28]:7971 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750978AbaCAHsu (ORCPT ); Sat, 1 Mar 2014 02:48:50 -0500 Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20140228212134.GC2517@katana> References: <20140228212134.GC2517@katana> <20140218205418.GH18768@katana> <20140109214954.25590.73057.stgit@warthog.procyon.org.uk> <20140109215002.25590.51609.stgit@warthog.procyon.org.uk> <11165.1393507178@warthog.procyon.org.uk> To: Wolfram Sang Cc: dhowells@redhat.com, wolfram@the-dreams.de, khali@linux-fr.org, linux-i2c@vger.kernel.org, Steven Rostedt , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] i2c: Add message transfer tracepoints for SMBUS Date: Sat, 01 Mar 2014 07:48:27 +0000 Message-ID: <24554.1393660107@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Wolfram Sang wrote: > > > Can we have something like this for 'flags'? > > > > There's a __print_flags() which should work. One thing I'm concerned about > > there is how do we handle more flags being added - does that count as an ABI > > break if the printed format changes? > > Not sure, I mean, this is debug output, no? Apparently, the raw messages are ABI, but the text dump (which is what we're talking out) is not. So doing this should be okay. David