From: Saeed Mahameed <saeedm@nvidia.com>
To: "len.baker@gmx.com" <len.baker@gmx.com>,
"davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"leon@kernel.org" <leon@kernel.org>
Cc: "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
Erez Shitrit <erezsh@nvidia.com>,
"keescook@chromium.org" <keescook@chromium.org>,
Yevgeny Kliteynik <kliteyn@nvidia.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Alex Vesker <valex@nvidia.com>,
"linux-hardening@vger.kernel.org"
<linux-hardening@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jianbo Liu <jianbol@nvidia.com>
Subject: Re: [PATCH] net/mlx5: DR, Prefer kcalloc over open coded arithmetic
Date: Mon, 20 Sep 2021 21:19:05 +0000 [thread overview]
Message-ID: <24604c4ac90323a1f39e3f7bffb7c79fc56cd874.camel@nvidia.com> (raw)
In-Reply-To: <20210905074936.15723-1-len.baker@gmx.com>
On Sun, 2021-09-05 at 09:49 +0200, Len Baker wrote:
> As noted in the "Deprecated Interfaces, Language Features,
> Attributes,
> and Conventions" documentation [1], size calculations (especially
> multiplication) should not be performed in memory allocator (or
> similar)
> function arguments due to the risk of them overflowing. This could
> lead
> to values wrapping around and a smaller allocation being made than
> the
> caller was expecting. Using those allocations could lead to linear
> overflows of heap memory and other misbehaviors.
>
> So, refactor the code a bit to use the purpose specific kcalloc()
> function instead of the argument size * count in the kzalloc()
> function.
>
> [1]
> https://www.kernel.org/doc/html/v5.14/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments
>
> Signed-off-by: Len Baker <len.baker@gmx.com>
applied to net-next-mlx5,
Thanks.
next prev parent reply other threads:[~2021-09-20 21:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-05 7:49 [PATCH] net/mlx5: DR, Prefer kcalloc over open coded arithmetic Len Baker
2021-09-20 21:19 ` Saeed Mahameed [this message]
2021-09-21 4:06 ` Kees Cook
2021-09-25 7:28 ` Len Baker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24604c4ac90323a1f39e3f7bffb7c79fc56cd874.camel@nvidia.com \
--to=saeedm@nvidia.com \
--cc=davem@davemloft.net \
--cc=erezsh@nvidia.com \
--cc=jianbol@nvidia.com \
--cc=keescook@chromium.org \
--cc=kliteyn@nvidia.com \
--cc=kuba@kernel.org \
--cc=len.baker@gmx.com \
--cc=leon@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=valex@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).