From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: kernel-janitors@vger.kernel.org,
Viresh Kumar <viresh.kumar@linaro.org>,
cpufreq@vger.kernel.org, linux-pm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: Avoid using ARRAY_AND_SIZE(e) as a function argument
Date: Tue, 13 Aug 2013 15:22:09 +0200 [thread overview]
Message-ID: <2461013.EC2pHmIZ5g@vostro.rjw.lan> (raw)
In-Reply-To: <1376239917-15594-13-git-send-email-Julia.Lawall@lip6.fr>
On Sunday, August 11, 2013 06:51:53 PM Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@lip6.fr>
>
> Replace ARRAY_AND_SIZE(e) in function argument position to avoid hiding the
> arity of the called function.
>
> The semantic match that makes this change is as follows:
> (http://coccinelle.lip6.fr/)
>
> // <smpl>
> @@
> expression e,f;
> @@
>
> f(...,
> - ARRAY_AND_SIZE(e)
> + e,ARRAY_SIZE(e)
> ,...)
> // </smpl>
>
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Queued up for 3.12.
Thanks,
Rafael
> ---
> Not compiled.
>
> drivers/cpufreq/pxa3xx-cpufreq.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/pxa3xx-cpufreq.c b/drivers/cpufreq/pxa3xx-cpufreq.c
> index 9c92ef0..d26306f 100644
> --- a/drivers/cpufreq/pxa3xx-cpufreq.c
> +++ b/drivers/cpufreq/pxa3xx-cpufreq.c
> @@ -213,10 +213,12 @@ static int pxa3xx_cpufreq_init(struct cpufreq_policy *policy)
> policy->cur = policy->min = policy->max;
>
> if (cpu_is_pxa300() || cpu_is_pxa310())
> - ret = setup_freqs_table(policy, ARRAY_AND_SIZE(pxa300_freqs));
> + ret = setup_freqs_table(policy, pxa300_freqs,
> + ARRAY_SIZE(pxa300_freqs));
>
> if (cpu_is_pxa320())
> - ret = setup_freqs_table(policy, ARRAY_AND_SIZE(pxa320_freqs));
> + ret = setup_freqs_table(policy, pxa320_freqs,
> + ARRAY_SIZE(pxa320_freqs));
>
> if (ret) {
> pr_err("failed to setup frequency table\n");
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
next prev parent reply other threads:[~2013-08-13 13:11 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-11 16:51 [PATCH 0/16] Avoid using ARRAY_AND_SIZE(e) as a function argument Julia Lawall
2013-08-11 16:51 ` [PATCH 1/16] sound/soc/pxa/mioa701_wm9713.c: " Julia Lawall
2013-08-11 18:06 ` Mark Brown
2013-08-11 16:51 ` [PATCH 2/16] arch/arm/mach-pxa: " Julia Lawall
2013-08-11 16:51 ` [PATCH 3/16] arch/arm/mach-ux500/cpu-db8500.c: " Julia Lawall
2013-08-20 9:13 ` Linus Walleij
2013-08-11 16:51 ` [PATCH 4/16] arch/arm/mach-pxa/z2.c: " Julia Lawall
2013-08-11 16:51 ` [PATCH 5/16] arch/arm/mach-pxa/vpac270.c: " Julia Lawall
2013-08-11 16:51 ` [PATCH 6/16] arch/arm/mach-pxa: " Julia Lawall
2013-08-11 16:51 ` [PATCH 7/16] arch/arm/mach-pxa/colibri-pxa270-income.c: " Julia Lawall
2013-08-11 16:51 ` [PATCH 8/16] arch/arm/mach-pxa/palmz72.c: " Julia Lawall
2013-08-11 16:51 ` [PATCH 9/16] arch/arm/mach-pxa/mioa701.c: " Julia Lawall
2013-08-12 19:58 ` Robert Jarzmik
2013-08-12 20:24 ` Julia Lawall
2013-08-11 16:51 ` [PATCH 10/16] arch/arm/mach-mmp: " Julia Lawall
2013-08-11 16:51 ` [PATCH 11/16] arch/arm/mach-pxa/palmtreo.c: " Julia Lawall
2013-08-13 0:34 ` Tomas Cech
2013-08-11 16:51 ` [PATCH 12/16] drivers/cpufreq/pxa3xx-cpufreq.c: " Julia Lawall
2013-08-12 5:26 ` Viresh Kumar
2013-08-12 5:45 ` Julia Lawall
2013-08-12 5:46 ` Viresh Kumar
2013-08-12 5:48 ` Julia Lawall
2013-08-12 5:50 ` Viresh Kumar
2013-08-13 13:22 ` Rafael J. Wysocki [this message]
2013-08-11 16:51 ` [PATCH 13/16] arch/arm/mach-pxa/hx4700.c: " Julia Lawall
2013-08-11 16:51 ` [PATCH 14/16] arch/arm/mach-pxa/ezx.c: " Julia Lawall
2013-08-11 16:51 ` [PATCH 15/16] arch/arm/mach-kirkwood: " Julia Lawall
2013-08-12 19:14 ` Jason Cooper
2013-08-11 16:51 ` [PATCH 16/16] arch/arm/mach-pxa/stargate2.c: " Julia Lawall
2013-08-12 9:22 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2461013.EC2pHmIZ5g@vostro.rjw.lan \
--to=rjw@sisk.pl \
--cc=Julia.Lawall@lip6.fr \
--cc=cpufreq@vger.kernel.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).