From: "Michal Malý" <madcatxster@gmail.com>
To: Simon Wood <gitsend@mungewell.org>
Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Jiri Kosina <jkosina@suse.cz>, Edwin Velds <edwin@velds.nl>,
Elias Vanderstuyft <elias.vds@gmail.com>,
Simon Wood <simon@mungewell.org>
Subject: Re: [RFC] HID:hid-lg4ff: Delay to allow wheels to center after plug-in
Date: Wed, 26 Oct 2016 09:36:27 +0200 [thread overview]
Message-ID: <24625977.TfGNBbEdyA@thora> (raw)
In-Reply-To: <1477445172-2682-1-git-send-email-simon@mungewell.org>
Hi all,
maybe instead of stalling the entire init() function it'd be better to put a
request to disable autocentering on a workqueue and start a delayed work once
the init() function is done setting the wheel up? There'd be a bit more code
to write though...
Michal
On Tuesday, October 25, 2016 7:26:12 PM CEST Simon Wood wrote:
> A number of wheels (G27/etc) do a little full right/full left 'dance'
> when first plugged in. This patch inserts a delay so that this 'dance'
> is completed before we disable (set to zero) the autocenter spring.
>
> A side benefit is that the DFGT was confused without the delay, and is
> now correctly being set to 900' rotation mode.
>
> Side Effect - and the reason I am sending as RFC. This 8s delay seems
> to have an effect on other wheels connected at the same time.
>
> With 3 wheels on a hub, and then the hub connected to PC. The wheel
> on the right in video below waits for G27 to complete this 8s, before
> it will do it's 'dance' and register with the system.
>
> https://www.youtube.com/watch?v=xCVpCw_yGgA
>
> I don't know if this is a problem, or if someone here has suggestions
> on a better way to implement the delay...
> ---
> drivers/hid/hid-lg4ff.c | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/hid/hid-lg4ff.c b/drivers/hid/hid-lg4ff.c
> index af3a8ec..3eee920 100644
> --- a/drivers/hid/hid-lg4ff.c
> +++ b/drivers/hid/hid-lg4ff.c
> @@ -1248,6 +1248,8 @@ int lg4ff_init(struct hid_device *hid)
> /* Check if autocentering is available and
> * set the centering force to zero by default */
> if (test_bit(FF_AUTOCENTER, dev->ffbit)) {
> + wait_queue_head_t wait;
> +
> /* Formula Force EX expects different autocentering command */
> if ((bcdDevice >> 8) == LG4FF_FFEX_REV_MAJ &&
> (bcdDevice & 0xff) == LG4FF_FFEX_REV_MIN)
> @@ -1255,6 +1257,14 @@ int lg4ff_init(struct hid_device *hid)
> else
> dev->ff->set_autocenter = lg4ff_set_autocenter_default;
>
> + /* insert a 8s delay to allow DFGT/G25/G27/G29 wheels to return to
center
> position*/ + if (lg4ff_devices[i].product_id ==
> USB_DEVICE_ID_LOGITECH_DFGT_WHEEL || +
lg4ff_devices[i].product_id ==
> USB_DEVICE_ID_LOGITECH_G25_WHEEL || + lg4ff_devices[i].product_id
==
> USB_DEVICE_ID_LOGITECH_G27_WHEEL || + lg4ff_devices[i].product_id
==
> USB_DEVICE_ID_LOGITECH_G29_WHEEL) { + init_waitqueue_head (&wait);
> + wait_event_interruptible_timeout(wait, 0, msecs_to_jiffies(8000));
> + }
> dev->ff->set_autocenter(dev, 0);
> }
next prev parent reply other threads:[~2016-10-26 7:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 1:26 [RFC] HID:hid-lg4ff: Delay to allow wheels to center after plug-in Simon Wood
2016-10-26 7:36 ` Michal Malý [this message]
2016-10-26 17:00 ` Dmitry Torokhov
2016-10-27 23:30 ` Simon Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24625977.TfGNBbEdyA@thora \
--to=madcatxster@gmail.com \
--cc=edwin@velds.nl \
--cc=elias.vds@gmail.com \
--cc=gitsend@mungewell.org \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@mungewell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).