From: Florian Fainelli <f.fainelli@gmail.com>
To: "Sebastian Frias" <sf84@laposte.net>,
afleming@freescale.com, jgarzik@pobox.com,
"Måns Rullgård" <mans@mansr.com>
Cc: netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>
Subject: Re: Is Documentation/networking/phy.txt still up-to-date?
Date: Wed, 9 Nov 2016 09:07:08 -0800 [thread overview]
Message-ID: <24676d24-5b07-7d26-6ffa-14e857960a52@gmail.com> (raw)
In-Reply-To: <582323A8.20706@laposte.net>
On 11/09/2016 05:24 AM, Sebastian Frias wrote:
> Hi,
>
> Documentation/networking/phy.txt discusses phy_connect and states that:
>
> "...
>
> interface is a u32 which specifies the connection type used
> between the controller and the PHY. Examples are GMII, MII,
> RGMII, and SGMII. For a full list, see include/linux/phy.h
>
> Now just make sure that phydev->supported and phydev->advertising have any
> values pruned from them which don't make sense for your controller (a 10/100
> controller may be connected to a gigabit capable PHY, so you would need to
> mask off SUPPORTED_1000baseT*). See include/linux/ethtool.h for definitions
> for these bitfields. Note that you should not SET any bits, or the PHY may
> get put into an unsupported state.
>
> ..."
>
> However, 'drivers/net/ethernet/aurora/nb8800.c' for example, does SETs some
> bits (in function 'nb8800_pause_adv').
All pause/flow control related bits should be set by the Ethernet MAC
driver because this is an Ethernet MAC, not PHY, thing. See this
discussion for some details:
https://www.mail-archive.com/netdev@vger.kernel.org/msg135347.html
So the nb8800 drivers does the correct thing here, but the documentation
should be updated to reflect that this applies to all bits, except the
Pause capabilities because these need to come from the Ethernet MAC.
>
> I checked 'drivers/net/ethernet/broadcom/genet/bcmmii.c' and that one CLEARs
> bits (as per the documentation).
>
> Does anybody knows what is the correct/recommended approach?
Both drivers do correct things, they just don't set the same things here.
--
Florian
next prev parent reply other threads:[~2016-11-09 17:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-09 13:24 Is Documentation/networking/phy.txt still up-to-date? Sebastian Frias
2016-11-09 17:07 ` Florian Fainelli [this message]
2016-11-14 13:18 ` Sebastian Frias
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24676d24-5b07-7d26-6ffa-14e857960a52@gmail.com \
--to=f.fainelli@gmail.com \
--cc=afleming@freescale.com \
--cc=davem@davemloft.net \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mans@mansr.com \
--cc=netdev@vger.kernel.org \
--cc=sf84@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).