linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: dhowells@redhat.com, George Spelvin <linux@horizon.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	LSM List <linux-security-module@vger.kernel.org>,
	Andy Lutomirski <luto@amacapital.net>,
	petkan@mip-labs.com, "Theodore Ts'o" <tytso@mit.edu>,
	Mimi Zohar <zohar@linux.vnet.ibm.com>
Subject: Re: Should we automatically generate a module signing key at all?
Date: Fri, 22 May 2015 23:15:34 +0100	[thread overview]
Message-ID: <24757.1432332934@warthog.procyon.org.uk> (raw)
In-Reply-To: <CA+55aFxYa9rd8mrJjkbUvKvLifn8uos40uNjj8L1ug873i5_aQ@mail.gmail.com>

Linus Torvalds <torvalds@linux-foundation.org> wrote:

> I forget the exact details of the signature ..., but for the modules
> themselves, it's just appended to the module contents.

Yes.

> And because the size of the certificate list is variable, you can't just
> zero it out or anything like that to make things compare equal.

Since it's discarded at the end of boot, it could be padded significantly.

Also the kernel image gets compressed and a prologue attached before being
placed in the binary RPMs or whatever, so you can't zero out the keys in those
very easily.

> But we might also simply decide to pack the keys differently. I'd
> personally be ok with it being in the initrd, for example, although
> for all I know that might screw up the people who actually want to use
> the BIOS secure booting thing

We wouldn't be able to trust any key loaded from the initrd unless the initrd
was itself verifiable.  Further, the initrd, at least in Fedora, gets composed
on the running system upon kernel installation so that it holds just the
modules you need to keep the size down.

> (I don't know how much that verifies).

The BIOS secure booting thing verifies the shim, grub and the kernel, as I
understand it.  The kernel then verifies modules and kexec images.

David

  parent reply	other threads:[~2015-05-22 22:15 UTC|newest]

Thread overview: 63+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-21 23:54 Should we automatically generate a module signing key at all? George Spelvin
2015-05-22  0:03 ` Linus Torvalds
2015-05-22  0:10   ` Andy Lutomirski
2015-05-22 14:13   ` George Spelvin
2015-05-22 20:40     ` Linus Torvalds
2015-05-22 20:44       ` Andy Lutomirski
2015-05-22 21:09         ` Linus Torvalds
2015-05-22 22:18         ` David Howells
2015-05-22 22:21           ` Linus Torvalds
2015-05-22 22:15     ` David Howells [this message]
2015-05-22 22:19       ` Andy Lutomirski
2015-05-22 22:21       ` David Howells
2015-05-22  0:03 ` Andy Lutomirski
2015-05-22 12:42   ` George Spelvin
  -- strict thread matches above, loose matches on Subject: below --
2015-05-18 16:04 David Howells
2015-05-18 16:19 ` David Woodhouse
2015-05-18 16:22   ` Linus Torvalds
2015-05-18 16:55     ` David Woodhouse
2015-05-18 16:20 ` Linus Torvalds
2015-05-19  0:51   ` Andy Lutomirski
2015-05-19  7:42     ` David Woodhouse
2015-05-19 17:44     ` Linus Torvalds
2015-05-19 17:58       ` Andy Lutomirski
2015-05-19 18:01         ` Linus Torvalds
2015-05-19 18:08         ` David Woodhouse
2015-05-19 18:12           ` Andy Lutomirski
2015-05-19 18:38             ` David Woodhouse
2015-05-19 18:49               ` Andy Lutomirski
2015-05-19 20:00                 ` David Woodhouse
2015-05-19 20:05                   ` Andy Lutomirski
2015-05-19 20:25                     ` David Woodhouse
2015-05-19 18:44           ` David Howells
2015-05-19 19:01             ` Andy Lutomirski
2015-05-21 16:10             ` David Howells
2015-05-21 16:50               ` Andy Lutomirski
2015-06-23 20:37       ` Pavel Machek
2015-05-20  5:01     ` Rusty Russell
2015-05-19  8:53   ` David Howells
2015-05-19 12:46     ` David Woodhouse
2015-05-19 12:52     ` David Howells
2015-05-19 14:36     ` Andy Lutomirski
2015-05-19 15:37       ` Mimi Zohar
2015-05-19 15:53         ` Petko Manolov
2015-05-19 17:17         ` Andy Lutomirski
2015-05-19 15:30     ` David Howells
2015-05-19 15:55       ` Theodore Ts'o
2015-05-19 16:09         ` Petko Manolov
2015-05-19 17:32         ` Mimi Zohar
2015-05-19 17:43           ` Andy Lutomirski
2015-05-19 17:53             ` Linus Torvalds
2015-05-19 16:23       ` David Howells
2015-05-19 17:55         ` Theodore Ts'o
2015-05-19 18:10         ` David Howells
2015-05-19 21:47         ` Jiri Kosina
2015-05-20  7:45           ` Michal Marek
2015-05-20  7:47         ` Michal Marek
2015-05-19 17:17       ` Andy Lutomirski
2015-05-19 18:38       ` David Howells
2015-05-19 18:46         ` Andy Lutomirski
2015-05-19 18:50         ` David Howells
2015-05-19 18:57         ` David Howells
2015-05-19 19:06           ` Andy Lutomirski
2015-05-21 15:59           ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24757.1432332934@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=dwmw2@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux@horizon.com \
    --cc=luto@amacapital.net \
    --cc=petkan@mip-labs.com \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=zohar@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).