From: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
To: Stefan Wahren <stefan.wahren@i2se.com>,
Kamil Debski <kamil@wypas.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Jean Delvare <jdelvare@suse.com>,
Guenter Roeck <linux@roeck-us.net>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Robin Murphy <robin.murphy@arm.com>
Cc: linux-hwmon@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH V5 3/3] hwmon: pwm-fan: Add RPM support via external interrupt
Date: Fri, 12 Apr 2019 15:15:55 +0200 [thread overview]
Message-ID: <24771fbe-0c45-78b0-e96b-6ed31ccdcb7f@metux.net> (raw)
In-Reply-To: <1554989411-23666-4-git-send-email-stefan.wahren@i2se.com>
On 11.04.19 15:30, Stefan Wahren wrote:
> This adds RPM support to the pwm-fan driver in order to use with
> fancontrol/pwmconfig. This feature is intended for fans with a tachometer
> output signal, which generate a defined number of pulses per revolution.
Wouldn't it be better to have a CONFIG_* flag for keeping the kernel
image size smaller when this feature isn't needed ?
--mtx
--
Enrico Weigelt, metux IT consult
Free software and Linux embedded engineering
info@metux.net -- +49-151-27565287
next prev parent reply other threads:[~2019-04-12 13:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 13:30 [PATCH V5 0/3] hwmon: pwm-fan: Add RPM support Stefan Wahren
2019-04-11 13:30 ` [PATCH V5 1/3] dt-bindings: hwmon: Add tachometer interrupt to pwm-fan Stefan Wahren
2019-04-11 13:30 ` [PATCH V5 2/3] Documentation: pwm-fan: Add description for RPM support Stefan Wahren
2019-04-11 13:30 ` [PATCH V5 3/3] hwmon: pwm-fan: Add RPM support via external interrupt Stefan Wahren
2019-04-11 16:57 ` Guenter Roeck
2019-04-12 11:07 ` Stefan Wahren
2019-04-12 11:50 ` Robin Murphy
2019-04-12 13:50 ` Guenter Roeck
2019-04-12 13:54 ` Robin Murphy
2019-04-12 14:29 ` Guenter Roeck
2019-04-12 13:15 ` Enrico Weigelt, metux IT consult [this message]
2019-04-12 13:35 ` Stefan Wahren
2019-04-12 13:47 ` Guenter Roeck
2019-04-12 17:35 ` [PATCH V5 0/3] hwmon: pwm-fan: Add RPM support Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24771fbe-0c45-78b0-e96b-6ed31ccdcb7f@metux.net \
--to=lkml@metux.net \
--cc=b.zolnierkie@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=jdelvare@suse.com \
--cc=kamil@wypas.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=robin.murphy@arm.com \
--cc=stefan.wahren@i2se.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).