From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043AbdKKTYt (ORCPT ); Sat, 11 Nov 2017 14:24:49 -0500 Received: from mout.web.de ([212.227.15.14]:55893 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751811AbdKKTYr (ORCPT ); Sat, 11 Nov 2017 14:24:47 -0500 Subject: [PATCH 3/3] ALSA: sgio2audio: Adjust two null pointer checks in snd_sgio2audio_create() From: SF Markus Elfring To: alsa-devel@alsa-project.org, Arvind Yadav , Bhumika Goyal , Jaroslav Kysela , Mark Brown , Takashi Iwai Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <249efc55-0688-6772-fc70-526a1bfa2603@users.sourceforge.net> Date: Sat, 11 Nov 2017 20:23:31 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K0:T5fb72izvABnWrrK/nx1GG8WlCPPO+SZjLE2+aKoVwNap2pz98u EVDQNRg+hJC5gCZ3ZL8aj5Bl1iOI/WO9g0o085Cyw+k/ksEuMV/clCFqMA7Awls89w34S4P tgSf2QSnR6lwJbgUzVNSvNXCv/ZMBtF6ae0TvEoVZP1Q4jxYXZ/m3aqMMMIgbVKqLfqd3L0 VytkIZv2JPRnrFdusqPVA== X-UI-Out-Filterresults: notjunk:1;V01:K0:VcQ9cfI0338=:Y2Y8u2o5Q5UU3a55Se9z3y +QW8bTgbc1QCqfTfQffIOzHZlrQkmQsv2i/lbl97JrY6w45jyEArNZUU4rw1d35OrLWxdYZXM fsdd8tQd1Ec17QXhq76ca4FDrHAnPPpA5+0pPdc+aH0cgRv+lPRUCR9JyCoWX0pr67LDMGAM+ GayO/j4iLcBR0szRzOkGaRTEoNeGoKr0AP+5CVG3HfsssAmS/Sdu0l/hl47G3g3CiYteOaBxV 0EVK0OlslyVnso/ZhebUoVOJYmXymqp/2bBETRAWh1QYBjZJf9PXSTUJegrxYsbhR3I2nvjk7 u06s29f/KFtsp3zRk9TqaB5SFLjb0R1jmZjsGzaXoVRrg4/m7MUV4MPfdfKwF1oC+WAy/FOJo hYtSoUU6EE0jFLG1yA3/qDZX+EPV8UiEIkE0SsX7yeoTDl9oMSitPze48rYs9QGoheBewRJLQ wnt3U7ekcIKhc3+moJvVU2rnLc7G0aO6HcTGq20Yn8L4hXJrdiYR5sJwbIbfyir/YTE+zoqYt jXb0rqKfKrqPO/qYEKarEAEgmLIuCaC0TKdoeIEM6OW1Cpk1gL2qvUxWSIaGr6iBhcPvrH3Dd coHMzSDLQuDLhZfaR+Hs8pRd/gKsqahBCrVeIAAmMzTiY2yUOpQWfFGy+yt07tsv5Vf3LP4w7 7JPHB34xn3bBjxGMguJa5pNMyiu0CmC4dWCDcaJY3hUKXuMm4i3VYOQLBZozEMdTfqDJD1UXI VrKNJor+NNPUyCPf3lTqbScFUjIPk3aT5JxsEd4Cj/pV+H6WGzhVNpgDxeQyCv6+tsnEqp+R2 00kV4uu7N5nL9mweogfYctkR3G+akd95nazLmKW5jSj+rejABQ= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Sat, 11 Nov 2017 20:10:22 +0100 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The script “checkpatch.pl” pointed information out like the following. Comparison to NULL could be written !… Thus fix the affected source code places. Signed-off-by: Markus Elfring --- sound/mips/sgio2audio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/mips/sgio2audio.c b/sound/mips/sgio2audio.c index 9e175a184b66..4027f0fc8db6 100644 --- a/sound/mips/sgio2audio.c +++ b/sound/mips/sgio2audio.c @@ -841,14 +841,14 @@ static int snd_sgio2audio_create(struct snd_card *card, return -ENOENT; chip = kzalloc(sizeof(*chip), GFP_KERNEL); - if (chip == NULL) + if (!chip) return -ENOMEM; chip->card = card; chip->ring_base = dma_alloc_coherent(NULL, MACEISA_RINGBUFFERS_SIZE, &chip->ring_base_dma, GFP_USER); - if (chip->ring_base == NULL) { + if (!chip->ring_base) { printk(KERN_ERR "sgio2audio: could not allocate ring buffers\n"); kfree(chip); -- 2.15.0