From: zhenwei pi <pizhenwei@bytedance.com>
To: Peter Xu <peterx@redhat.com>, Jue Wang <juew@google.com>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"David Hildenbrand" <david@redhat.com>,
jasowang@redhat.com, LKML <linux-kernel@vger.kernel.org>,
"Linux MM" <linux-mm@kvack.org>,
mst@redhat.com,
"HORIGUCHI NAOYA(堀口 直也)" <naoya.horiguchi@nec.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
qemu-devel@nongnu.org, virtualization@lists.linux-foundation.org
Subject: Re: Re: [PATCH 0/3] recover hardware corrupted page by virtio balloon
Date: Fri, 27 May 2022 14:32:52 +0800 [thread overview]
Message-ID: <24a95dea-9ea6-a904-7c0b-197961afa1d1@bytedance.com> (raw)
In-Reply-To: <Yo/I3oLkd9OU0ice@xz-m1.local>
On 5/27/22 02:37, Peter Xu wrote:
> On Wed, May 25, 2022 at 01:16:34PM -0700, Jue Wang wrote:
>> The hypervisor _must_ emulate poisons identified in guest physical
>> address space (could be transported from the source VM), this is to
>> prevent silent data corruption in the guest. With a paravirtual
>> approach like this patch series, the hypervisor can clear some of the
>> poisoned HVAs knowing for certain that the guest OS has isolated the
>> poisoned page. I wonder how much value it provides to the guest if the
>> guest and workload are _not_ in a pressing need for the extra KB/MB
>> worth of memory.
>
> I'm curious the same on how unpoisoning could help here. The reasoning
> behind would be great material to be mentioned in the next cover letter.
>
> Shouldn't we consider migrating serious workloads off the host already
> where there's a sign of more severe hardware issues, instead?
>
> Thanks,
>
I'm maintaining 1000,000+ virtual machines, from my experience:
UE is quite unusual and occurs randomly, and I did not hit UE storm case
in the past years. The memory also has no obvious performance drop after
hitting UE.
I hit several CE storm case, the performance memory drops a lot. But I
can't find obvious relationship between UE and CE.
So from the point of my view, to fix the corrupted page for VM seems
good enough. And yes, unpoisoning several pages does not help
significantly, but it is still a chance to make the virtualization better.
--
zhenwei pi
next prev parent reply other threads:[~2022-05-27 6:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-25 20:16 [PATCH 0/3] recover hardware corrupted page by virtio balloon Jue Wang
2022-05-26 18:37 ` Peter Xu
2022-05-27 6:32 ` zhenwei pi [this message]
2022-05-30 7:41 ` David Hildenbrand
2022-05-30 11:33 ` zhenwei pi
2022-05-30 15:49 ` Peter Xu
2022-05-31 4:08 ` Jue Wang
2022-06-01 2:17 ` zhenwei pi
2022-06-01 7:59 ` David Hildenbrand
2022-06-02 9:28 ` zhenwei pi
2022-06-02 9:40 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24a95dea-9ea6-a904-7c0b-197961afa1d1@bytedance.com \
--to=pizhenwei@bytedance.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=jasowang@redhat.com \
--cc=juew@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mst@redhat.com \
--cc=naoya.horiguchi@nec.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).