From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752184AbcFOBPG (ORCPT ); Tue, 14 Jun 2016 21:15:06 -0400 Received: from regular1.263xmail.com ([211.150.99.134]:51675 "EHLO regular1.263xmail.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752182AbcFOBPE (ORCPT ); Tue, 14 Jun 2016 21:15:04 -0400 X-263anti-spam: KSV:0; X-MAIL-GRAY: 0 X-MAIL-DELIVERY: 1 X-KSVirus-check: 0 X-ABS-CHECKED: 4 X-ADDR-CHECKED: 0 X-RL-SENDER: frank.wang@rock-chips.com X-FST-TO: frank.wang@rock-chips.com X-SENDER-IP: 58.22.7.114 X-LOGIN-NAME: frank.wang@rock-chips.com X-UNIQUE-TAG: <5fba0ad625191eb0d1462902da99e8b1> X-ATTACHMENT-NUM: 0 X-DNS-TYPE: 0 Subject: Re: [PATCH v5 2/2] phy: rockchip-inno-usb2: add a new driver for Rockchip usb2phy To: =?UTF-8?Q?Heiko_St=c3=bcbner?= , Guenter Roeck References: <1465783810-18756-1-git-send-email-frank.wang@rock-chips.com> <7225720.0AClDW7eQ6@diego> <4065185.1IWsBDlcMJ@diego> Cc: Douglas Anderson , Guenter Roeck , Guenter Roeck , jwerner@chromium.org, kishon@ti.com, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, Kumar Gala , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, Ziyuan Xu , Kever Yang , Tao Huang , william.wu@rock-chips.com, frank.wang@rock-chips.com From: Frank Wang Message-ID: <24acf224-e792-6648-fcdb-8729ded6df84@rock-chips.com> Date: Wed, 15 Jun 2016 09:14:44 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <4065185.1IWsBDlcMJ@diego> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko & Guenter, On 2016/6/14 22:00, Heiko Stübner wrote: > Am Dienstag, 14. Juni 2016, 06:50:31 schrieb Guenter Roeck: >> On Tue, Jun 14, 2016 at 6:27 AM, Heiko Stübner wrote: >>> Am Montag, 13. Juni 2016, 10:10:10 schrieb Frank Wang: >>>> The newer SoCs (rk3366, rk3399) take a different usb-phy IP block >>>> than rk3288 and before, and most of phy-related registers are also >>>> different from the past, so a new phy driver is required necessarily. >>>> >>>> Signed-off-by: Frank Wang >>>> --- > [...] > >>>> +static int rockchip_usb2phy_init(struct phy *phy) >>>> +{ >>>> + struct rockchip_usb2phy_port *rport = phy_get_drvdata(phy); >>>> + struct rockchip_usb2phy *rphy = dev_get_drvdata(phy->dev.parent); >>>> + int ret; >>>> + >>>> >>> if (!rport->port_cfg) >>> >>> return 0; >>> >>> Otherwise the currently empty otg-port will cause null-pointer >>> dereferences >>> when it gets assigned in the devicetree already. >> Not really, at least not here - that port should not have port_id set >> to USB2PHY_PORT_HOST. >> >> Does it even make sense to instantiate the otg port ? Is it going to >> do anything without port configuration ? > Ok, that would be the other option - not creating the phy in the driver. Well, I will put this conditional inside *_host_port_init(), if it is an empty, the phy-device should not be created. Something like the following: --- a/drivers/phy/phy-rockchip-inno-usb2.c +++ b/drivers/phy/phy-rockchip-inno-usb2.c @@ -483,9 +483,13 @@ static int rockchip_usb2phy_host_port_init(struct rockchip_usb2phy *rphy, { int ret; - rport->port_id = USB2PHY_PORT_HOST; rport->port_cfg = &rphy->phy_cfg->port_cfgs[USB2PHY_PORT_HOST]; + if (!rport->port_cfg) { + dev_err(rphy->dev, "no host port-config provided.\n"); + return -EINVAL; + } + rport->port_id = USB2PHY_PORT_HOST; > Or from what I've seen, handling it as similar to the host-port should work > initially as well most likely, supplying the additional otg-parts later on. @Guenter, just as Heiko said, the otg-parts is not ready now, it will be supplied later. BR. Frank