From: Saurav Girepunje <saurav.girepunje@gmail.com>
To: gregkh@linuxfoundation.org, kuba@kernel.org,
lee.jones@linaro.org, nathan@kernel.org, clrrm@isep.ipp.pt,
johan@kernel.org, dinghao.liu@zju.edu.cn,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: saurav.girepunje@hotmail.com
Subject: Re: [PATCH] staging: rtl8192u: remove the if condition without effect
Date: Mon, 8 Nov 2021 09:45:05 +0530 [thread overview]
Message-ID: <24befb64-0fdc-03ab-5a9a-c7be443be1a1@gmail.com> (raw)
In-Reply-To: <YYijapuGOmObwM3S@Sauravs-MacBook-Air.local>
On 08/11/21 9:41 am, Saurav Girepunje wrote:
> In function rtl8192_adapter_start priv->pFirmware->firmware_status
> is assign to FW_STATUS_0_INIT just after assignment variable is
> again get check for same value. Therefore if condition will be
> always be true. So remove the if condition ,else if section and
> else section which will never get execute.
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 9 +--------
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index 726d7ad9408b..f5d9e81f4ac7 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -2666,14 +2666,7 @@ static bool rtl8192_adapter_start(struct net_device *dev)
> /* config CPUReset Register */
> /* Firmware Reset or not? */
> read_nic_dword(dev, CPU_GEN, &dwRegRead);
> - if (priv->pFirmware->firmware_status == FW_STATUS_0_INIT)
> - dwRegRead |= CPU_GEN_SYSTEM_RESET; /* do nothing here? */
> - else if (priv->pFirmware->firmware_status == FW_STATUS_5_READY)
> - dwRegRead |= CPU_GEN_FIRMWARE_RESET;
> - else
> - RT_TRACE(COMP_ERR,
> - "ERROR in %s(): undefined firmware state(%d)\n",
> - __func__, priv->pFirmware->firmware_status);
> + dwRegRead |= CPU_GEN_SYSTEM_RESET; /* do nothing here? */
>
> write_nic_dword(dev, CPU_GEN, dwRegRead);
> /* config BB. */
> --
> 2.33.0
>
read_nic_dword function call also does not update value of priv->pFirmware->firmware_status.
read_nic_dword return a value that never check by any caller function.
That can cover on another patch.
Regards,
Saurav
prev parent reply other threads:[~2021-11-08 4:15 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 4:11 [PATCH] staging: rtl8192u: remove the if condition without effect Saurav Girepunje
2021-11-08 4:15 ` Saurav Girepunje [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24befb64-0fdc-03ab-5a9a-c7be443be1a1@gmail.com \
--to=saurav.girepunje@gmail.com \
--cc=clrrm@isep.ipp.pt \
--cc=dinghao.liu@zju.edu.cn \
--cc=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=kuba@kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nathan@kernel.org \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).