From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CCF25C4320A for ; Mon, 2 Aug 2021 07:34:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3E9860F5A for ; Mon, 2 Aug 2021 07:34:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232563AbhHBHfA (ORCPT ); Mon, 2 Aug 2021 03:35:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232173AbhHBHe7 (ORCPT ); Mon, 2 Aug 2021 03:34:59 -0400 Received: from mail-lf1-x129.google.com (mail-lf1-x129.google.com [IPv6:2a00:1450:4864:20::129]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBC55C06175F; Mon, 2 Aug 2021 00:34:49 -0700 (PDT) Received: by mail-lf1-x129.google.com with SMTP id g13so31992498lfj.12; Mon, 02 Aug 2021 00:34:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aFUA7gqv5nqUBy64bglY3W//g6TnGj78A7yZtc2oA5k=; b=uH1amc5xp//nd7WvK2vN3WhxHIO6u6iBR4fQQ0K7fPU14ANcqcKFLQ7A2q7YcH0Qic Q5jmAjM49CqhS22RzTwTZolI3VxhhzQY9Wf00LV2m6QlpB/+JuZE6GcNeH7qH7kgTOGm Bex2nRL6HG9CSBLt/dHG4pjs59PABbRisCuSKPyRFfpcCvUzIha301aiFa0y5LZ8k7X0 3xL6fAzdRWGUPAgSAYcWMXAcbgd2nwfZhTA69F49gtiLoX9S6q/m2jTLF3l3Pq01EAqn Y6OLmGmkrGaSkh/Sv/q10IPKy1OeRyRnMl338b5zGMITWcgfNr+Jvxo0Uwq6nCS5Llcm 0RZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aFUA7gqv5nqUBy64bglY3W//g6TnGj78A7yZtc2oA5k=; b=nOguulAIDj8UgZyzzUFXPi9c32OERT1SBnpL9iu3QDegig8PdHYvMuAbxiI72khedh F8fdac/1BLtw+ebf2K/EVuJZ4iByNVzDhHEq+dE3Upc2+f+lB2Wgo1lxEMTw4IRzRWUV vZRGGiJxVToIp860vSPL1hgPkWNG4UfsB0hR2qMwu+QJGlVBPLLtLn+sGz01odunmxvf 0ecacMFLZkRpSoy5PDUFYajknn0JYmOdNyF+FseBPjfyLHJ9krEvL59Z8VrD8WwIAYpq HFORIccaEBWtrwSgAPTEX0baptBeSB665SMoPr0WPt49SHG8HAqxQPw1b5FE58ZNAcJn 3d0w== X-Gm-Message-State: AOAM533Ri5nx24Tt4z9wnkp+oWhu4PJ97Crb+l1Wtcx0aw1rseyAK3Lf hx84PClWiPeTdRDK1QYAJgLoo7qJnAI= X-Google-Smtp-Source: ABdhPJyJ6xmipNtY+j1ylKQrOd30UXQg8VwWVYtQ46MUx56SmG+iSxryGz7TjY/Lpe+zCl5vm+1FVg== X-Received: by 2002:a05:6512:3a86:: with SMTP id q6mr11624095lfu.548.1627889687486; Mon, 02 Aug 2021 00:34:47 -0700 (PDT) Received: from [192.168.1.49] ([109.197.204.123]) by smtp.gmail.com with ESMTPSA id h17sm121037lfc.191.2021.08.02.00.34.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Aug 2021 00:34:47 -0700 (PDT) Subject: Re: [PATCH 1/7] iio: ep93xx: Prepare clock before using it To: Jonathan Cameron Cc: Geert Uytterhoeven , Nikita Shubin , linux-iio@vger.kernel.org, Lars-Peter Clausen , linux-kernel@vger.kernel.org References: <20210613233041.128961-1-alexander.sverdlin@gmail.com> <20210613233041.128961-2-alexander.sverdlin@gmail.com> <20210614115043.07ea0ae1@jic23-huawei> From: Alexander Sverdlin Message-ID: <24f29bc6-311c-4f96-2e1b-1a5df936bb3a@gmail.com> Date: Mon, 2 Aug 2021 09:30:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: <20210614115043.07ea0ae1@jic23-huawei> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Jonathan! On 14/06/2021 12:50, Jonathan Cameron wrote: > On Mon, 14 Jun 2021 01:30:35 +0200 > Alexander Sverdlin wrote: > >> Use clk_prepare_enable()/clk_disable_unprepare() in preparation for switch >> to Common Clock Framework, otherwise the following is visible: >> >> WARNING: CPU: 0 PID: 1 at drivers/clk/clk.c:1011 clk_core_enable+0x9c/0xbc >> Enabling unprepared ep93xx-adc >> CPU: 0 PID: 1 Comm: swapper Not tainted 5.13.0-rc5-... #1 >> Hardware name: Cirrus Logic EDB9302 Evaluation Board >> [] (unwind_backtrace) from [] (show_stack+0x10/0x18) >> [] (show_stack) from [] (dump_stack+0x20/0x2c) >> [] (dump_stack) from [] (__warn+0x98/0xc0) >> [] (__warn) from [] (warn_slowpath_fmt+0x90/0xc0) >> [] (warn_slowpath_fmt) from [] (clk_core_enable+0x9c/0xbc) >> [] (clk_core_enable) from [] (clk_core_enable_lock+0x18/0x30) >> [] (clk_core_enable_lock) from [] (ep93xx_adc_probe+0xe4/0x1a0) >> [] (ep93xx_adc_probe) from [] (platform_probe+0x34/0x80) >> [] (platform_probe) from [] (really_probe+0xe8/0x394) >> [] (really_probe) from [] (device_driver_attach+0x5c/0x64) >> [] (device_driver_attach) from [] (__driver_attach+0x7c/0xec) >> [] (__driver_attach) from [] (bus_for_each_dev+0x78/0xc4) >> [] (bus_for_each_dev) from [] (driver_attach+0x18/0x24) >> [] (driver_attach) from [] (bus_add_driver+0x140/0x1cc) >> [] (bus_add_driver) from [] (driver_register+0x74/0x114) >> [] (driver_register) from [] (__platform_driver_register+0x18/0x24) >> [] (__platform_driver_register) from [] (ep93xx_adc_driver_init+0x10/0x1c) >> [] (ep93xx_adc_driver_init) from [] (do_one_initcall+0x7c/0x1a4) >> [] (do_one_initcall) from [] (kernel_init_freeable+0x17c/0x1fc) >> [] (kernel_init_freeable) from [] (kernel_init+0x8/0xf8) >> [] (kernel_init) from [] (ret_from_fork+0x14/0x3c) >> ... >> ep93xx-adc ep93xx-adc: Cannot enable clock >> ep93xx-adc: probe of ep93xx-adc failed with error -108 >> >> Signed-off-by: Alexander Sverdlin > Acked-by: Jonathan Cameron > > From cover letter I'm assuming you want these to go through same route as > the common clock conversion? If not shout and I can pick this one up. We didn't manage to consolidate the delivery path for this series, could you please take this patch alone, as you proposed initially? >> --- >> drivers/iio/adc/ep93xx_adc.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/iio/adc/ep93xx_adc.c b/drivers/iio/adc/ep93xx_adc.c >> index c08ab3c6dfaf..5c85257b814c 100644 >> --- a/drivers/iio/adc/ep93xx_adc.c >> +++ b/drivers/iio/adc/ep93xx_adc.c >> @@ -207,7 +207,7 @@ static int ep93xx_adc_probe(struct platform_device *pdev) >> */ >> } >> >> - ret = clk_enable(priv->clk); >> + ret = clk_prepare_enable(priv->clk); >> if (ret) { >> dev_err(&pdev->dev, "Cannot enable clock\n"); >> return ret; >> @@ -215,7 +215,7 @@ static int ep93xx_adc_probe(struct platform_device *pdev) >> >> ret = iio_device_register(iiodev); >> if (ret) >> - clk_disable(priv->clk); >> + clk_disable_unprepare(priv->clk); >> >> return ret; >> } >> @@ -226,7 +226,7 @@ static int ep93xx_adc_remove(struct platform_device *pdev) >> struct ep93xx_adc_priv *priv = iio_priv(iiodev); >> >> iio_device_unregister(iiodev); >> - clk_disable(priv->clk); >> + clk_disable_unprepare(priv->clk); >> >> return 0; >> } >