* [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY
@ 2020-11-01 0:34 Pablo Greco
2020-11-01 0:34 ` [PATCH] ARM: dts: sun8i: r40: bananapi-m2-berry: Fix dcdc1 regulator Pablo Greco
` (3 more replies)
0 siblings, 4 replies; 10+ messages in thread
From: Pablo Greco @ 2020-11-01 0:34 UTC (permalink / raw)
To: linux-sunxi
Cc: Pablo Greco, Rob Herring, Maxime Ripard, Chen-Yu Tsai,
Jernej Skrabec, Hans de Goede, Icenowy Zheng, devicetree,
linux-arm-kernel, linux-kernel
The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on
the PHY, using pull-ups on the RXDLY and TXDLY pins.
Fix the phy-mode description to correct reflect this so that the
implementation doesn't reconfigure the delays incorrectly. This
happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
rx/tx delay config").
Fixes: 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board")
Signed-off-by: Pablo Greco <pgreco@centosproject.org>
---
arch/arm/boot/dts/sun7i-a20-bananapi.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
index bb3987e101c2..0b3d9ae75650 100644
--- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts
+++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
@@ -132,7 +132,7 @@
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-supply = <®_gmac_3v3>;
status = "okay";
};
--
2.18.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: sun8i: r40: bananapi-m2-berry: Fix dcdc1 regulator
2020-11-01 0:34 [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Pablo Greco
@ 2020-11-01 0:34 ` Pablo Greco
2020-11-01 7:31 ` Jernej Škrabec
2020-11-01 0:34 ` [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node Pablo Greco
` (2 subsequent siblings)
3 siblings, 1 reply; 10+ messages in thread
From: Pablo Greco @ 2020-11-01 0:34 UTC (permalink / raw)
To: linux-sunxi
Cc: Pablo Greco, Rob Herring, Maxime Ripard, Chen-Yu Tsai,
Jernej Skrabec, Hans de Goede, Icenowy Zheng, devicetree,
linux-arm-kernel, linux-kernel
DCDC1 regulator powers many different subsystems. While some of them can
work at 3.0 V, some of them can not. For example, VCC-HDMI can only work
between 3.24 V and 3.36 V. According to OS images provided by the board
manufacturer this regulator should be set to 3.3 V.
Set DCDC1 and DCDC1SW to 3.3 V in order to fix this.
Fixes: 23edc168bd98 ("ARM: dts: sun8i: Add board dts file for Banana Pi M2 Berry")
Fixes: 27e81e1970a8 ("ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC ethernet controller")
Signed-off-by: Pablo Greco <pgreco@centosproject.org>
---
arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
index 3ab6f47cea4f..47954551f573 100644
--- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
+++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
@@ -198,16 +198,16 @@
};
®_dc1sw {
- regulator-min-microvolt = <3000000>;
- regulator-max-microvolt = <3000000>;
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
regulator-name = "vcc-gmac-phy";
};
®_dcdc1 {
regulator-always-on;
- regulator-min-microvolt = <3000000>;
- regulator-max-microvolt = <3000000>;
- regulator-name = "vcc-3v0";
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-name = "vcc-3v3";
};
®_dcdc2 {
--
2.18.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node
2020-11-01 0:34 [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Pablo Greco
2020-11-01 0:34 ` [PATCH] ARM: dts: sun8i: r40: bananapi-m2-berry: Fix dcdc1 regulator Pablo Greco
@ 2020-11-01 0:34 ` Pablo Greco
2020-11-01 7:29 ` Jernej Škrabec
2020-11-01 7:34 ` [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Jernej Škrabec
2020-11-02 14:07 ` Maxime Ripard
3 siblings, 1 reply; 10+ messages in thread
From: Pablo Greco @ 2020-11-01 0:34 UTC (permalink / raw)
To: linux-sunxi
Cc: Pablo Greco, Rob Herring, Maxime Ripard, Chen-Yu Tsai,
Jernej Skrabec, Hans de Goede, Icenowy Zheng, devicetree,
linux-arm-kernel, linux-kernel
Ethernet PHY on BananaPi M2 Berry provides RX and TX delays. Fix ethernet
node to reflect that fact.
Fixes: 27e81e1970a8 ("ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC ethernet controller")
Signed-off-by: Pablo Greco <pgreco@centosproject.org>
---
arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
index 15c22b06fc4b..3ab6f47cea4f 100644
--- a/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
+++ b/arch/arm/boot/dts/sun8i-v40-bananapi-m2-berry.dts
@@ -120,7 +120,7 @@
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-supply = <®_dc1sw>;
status = "okay";
};
--
2.18.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node
2020-11-01 0:34 ` [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node Pablo Greco
@ 2020-11-01 7:29 ` Jernej Škrabec
0 siblings, 0 replies; 10+ messages in thread
From: Jernej Škrabec @ 2020-11-01 7:29 UTC (permalink / raw)
To: linux-sunxi, Pablo Greco
Cc: Pablo Greco, Rob Herring, Maxime Ripard, Chen-Yu Tsai,
Hans de Goede, Icenowy Zheng, devicetree, linux-arm-kernel,
linux-kernel
Dne nedelja, 01. november 2020 ob 01:34:17 CET je Pablo Greco napisal(a):
> Ethernet PHY on BananaPi M2 Berry provides RX and TX delays. Fix ethernet
> node to reflect that fact.
>
> Fixes: 27e81e1970a8 ("ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC
ethernet controller")
> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Thanks!
Jernej
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun8i: r40: bananapi-m2-berry: Fix dcdc1 regulator
2020-11-01 0:34 ` [PATCH] ARM: dts: sun8i: r40: bananapi-m2-berry: Fix dcdc1 regulator Pablo Greco
@ 2020-11-01 7:31 ` Jernej Škrabec
0 siblings, 0 replies; 10+ messages in thread
From: Jernej Škrabec @ 2020-11-01 7:31 UTC (permalink / raw)
To: linux-sunxi, Pablo Greco
Cc: Pablo Greco, Rob Herring, Maxime Ripard, Chen-Yu Tsai,
Hans de Goede, Icenowy Zheng, devicetree, linux-arm-kernel,
linux-kernel
Dne nedelja, 01. november 2020 ob 01:34:16 CET je Pablo Greco napisal(a):
> DCDC1 regulator powers many different subsystems. While some of them can
> work at 3.0 V, some of them can not. For example, VCC-HDMI can only work
> between 3.24 V and 3.36 V. According to OS images provided by the board
> manufacturer this regulator should be set to 3.3 V.
>
> Set DCDC1 and DCDC1SW to 3.3 V in order to fix this.
>
> Fixes: 23edc168bd98 ("ARM: dts: sun8i: Add board dts file for Banana Pi M2
Berry")
> Fixes: 27e81e1970a8 ("ARM: dts: sun8i: v40: bananapi-m2-berry: Enable GMAC
ethernet controller")
> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Thanks!
Jernej
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY
2020-11-01 0:34 [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Pablo Greco
2020-11-01 0:34 ` [PATCH] ARM: dts: sun8i: r40: bananapi-m2-berry: Fix dcdc1 regulator Pablo Greco
2020-11-01 0:34 ` [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node Pablo Greco
@ 2020-11-01 7:34 ` Jernej Škrabec
2020-11-02 14:07 ` Maxime Ripard
3 siblings, 0 replies; 10+ messages in thread
From: Jernej Škrabec @ 2020-11-01 7:34 UTC (permalink / raw)
To: linux-sunxi, Pablo Greco
Cc: Pablo Greco, Rob Herring, Maxime Ripard, Chen-Yu Tsai,
Hans de Goede, Icenowy Zheng, devicetree, linux-arm-kernel,
linux-kernel
Dne nedelja, 01. november 2020 ob 01:34:15 CET je Pablo Greco napisal(a):
> The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on
> the PHY, using pull-ups on the RXDLY and TXDLY pins.
>
> Fix the phy-mode description to correct reflect this so that the
> implementation doesn't reconfigure the delays incorrectly. This
> happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
> rx/tx delay config").
>
> Fixes: 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board")
> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Thanks!
Jernej
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY
2020-11-01 0:34 [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Pablo Greco
` (2 preceding siblings ...)
2020-11-01 7:34 ` [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Jernej Škrabec
@ 2020-11-02 14:07 ` Maxime Ripard
2020-11-02 14:21 ` Pablo Sebastián Greco
3 siblings, 1 reply; 10+ messages in thread
From: Maxime Ripard @ 2020-11-02 14:07 UTC (permalink / raw)
To: Pablo Greco
Cc: linux-sunxi, Rob Herring, Chen-Yu Tsai, Jernej Skrabec,
Hans de Goede, Icenowy Zheng, devicetree, linux-arm-kernel,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 855 bytes --]
Hi,
On Sat, Oct 31, 2020 at 09:34:15PM -0300, Pablo Greco wrote:
> The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on
> the PHY, using pull-ups on the RXDLY and TXDLY pins.
>
> Fix the phy-mode description to correct reflect this so that the
> implementation doesn't reconfigure the delays incorrectly. This
> happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
> rx/tx delay config").
>
> Fixes: 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board")
> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
Thanks for sending those patches.
However, I'm not entirely sure how you sent it but the odd threading you
used (each other patches being in reply to this one without 0/N in the
name) seem to confuse the tools we use to apply the patches.
Can you resend it properly?
Thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY
2020-11-02 14:07 ` Maxime Ripard
@ 2020-11-02 14:21 ` Pablo Sebastián Greco
0 siblings, 0 replies; 10+ messages in thread
From: Pablo Sebastián Greco @ 2020-11-02 14:21 UTC (permalink / raw)
To: Maxime Ripard
Cc: linux-sunxi, Rob Herring, Chen-Yu Tsai, Jernej Skrabec,
Hans de Goede, Icenowy Zheng, devicetree, linux-arm-kernel,
linux-kernel
On 2/11/20 11:07, Maxime Ripard wrote:
> Hi,
>
> On Sat, Oct 31, 2020 at 09:34:15PM -0300, Pablo Greco wrote:
>> The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on
>> the PHY, using pull-ups on the RXDLY and TXDLY pins.
>>
>> Fix the phy-mode description to correct reflect this so that the
>> implementation doesn't reconfigure the delays incorrectly. This
>> happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
>> rx/tx delay config").
>>
>> Fixes: 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board")
>> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
> Thanks for sending those patches.
>
> However, I'm not entirely sure how you sent it but the odd threading you
> used (each other patches being in reply to this one without 0/N in the
> name) seem to confuse the tools we use to apply the patches.
>
> Can you resend it properly?
> Thanks!
> Maxime
I prepared them individually but sent them together in a single
git-send-email, that must have been the problem.
I"ll send them again one by one.
Pablo.
^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY
2020-11-02 14:16 Pablo Greco
@ 2020-11-02 17:06 ` Maxime Ripard
0 siblings, 0 replies; 10+ messages in thread
From: Maxime Ripard @ 2020-11-02 17:06 UTC (permalink / raw)
To: Pablo Greco
Cc: linux-sunxi, Rob Herring, Chen-Yu Tsai, Jernej Skrabec,
Hans de Goede, devicetree, linux-arm-kernel, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 580 bytes --]
On Mon, Nov 02, 2020 at 11:16:40AM -0300, Pablo Greco wrote:
> The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on
> the PHY, using pull-ups on the RXDLY and TXDLY pins.
>
> Fix the phy-mode description to correct reflect this so that the
> implementation doesn't reconfigure the delays incorrectly. This
> happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
> rx/tx delay config").
>
> Fixes: 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board")
> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
Applied thanks!
Maxime
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY
@ 2020-11-02 14:16 Pablo Greco
2020-11-02 17:06 ` Maxime Ripard
0 siblings, 1 reply; 10+ messages in thread
From: Pablo Greco @ 2020-11-02 14:16 UTC (permalink / raw)
To: linux-sunxi
Cc: Pablo Greco, Rob Herring, Maxime Ripard, Chen-Yu Tsai,
Jernej Skrabec, Hans de Goede, devicetree, linux-arm-kernel,
linux-kernel
The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on
the PHY, using pull-ups on the RXDLY and TXDLY pins.
Fix the phy-mode description to correct reflect this so that the
implementation doesn't reconfigure the delays incorrectly. This
happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
rx/tx delay config").
Fixes: 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board")
Signed-off-by: Pablo Greco <pgreco@centosproject.org>
---
arch/arm/boot/dts/sun7i-a20-bananapi.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
index bb3987e101c2..0b3d9ae75650 100644
--- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts
+++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts
@@ -132,7 +132,7 @@
pinctrl-names = "default";
pinctrl-0 = <&gmac_rgmii_pins>;
phy-handle = <&phy1>;
- phy-mode = "rgmii";
+ phy-mode = "rgmii-id";
phy-supply = <®_gmac_3v3>;
status = "okay";
};
--
2.18.4
^ permalink raw reply related [flat|nested] 10+ messages in thread
end of thread, other threads:[~2020-11-02 17:06 UTC | newest]
Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-01 0:34 [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Pablo Greco
2020-11-01 0:34 ` [PATCH] ARM: dts: sun8i: r40: bananapi-m2-berry: Fix dcdc1 regulator Pablo Greco
2020-11-01 7:31 ` Jernej Škrabec
2020-11-01 0:34 ` [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node Pablo Greco
2020-11-01 7:29 ` Jernej Škrabec
2020-11-01 7:34 ` [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Jernej Škrabec
2020-11-02 14:07 ` Maxime Ripard
2020-11-02 14:21 ` Pablo Sebastián Greco
2020-11-02 14:16 Pablo Greco
2020-11-02 17:06 ` Maxime Ripard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).