From: Jon Masters <jcm@jonmasters.org>
To: Vadim Lomovtsev <Vadim.Lomovtsev@caviumnetworks.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
David.Daney@cavium.com, tn@semihalf.com,
linux-kernel@vger.kernel.org,
stemerkhanov@CAVIUMNETWORKS.onmicrosoft.com,
linux-pci@vger.kernel.org, bhelgaas@google.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] PCI: ACPI: Fix ThunderX PEM initialization
Date: Thu, 16 Mar 2017 10:32:39 -0400 [thread overview]
Message-ID: <251db823-591b-483b-9c55-13c911020fd1@jonmasters.org> (raw)
In-Reply-To: <20170315113323.GA28027@localhost.localdomain>
Hi Vadim,
Thanks for your followup and attention to this matter. More below.
On 03/15/2017 07:33 AM, Vadim Lomovtsev wrote:
>> The upstream Linux kernel contains a quirk matching entry that looks for
>> "THRX". Therefore, you have already agreed (as of at least January) that
>> this is the prefix that you will use in any firmware updates to support
>> the latest upstream Linux kernel. Please register this prefix promptly.
>
> And from what I know for now - we wont going to register this
> since we have already regsitered "CAV" prefix for that. And this was the part
> of our discussion also.
>
> We had a bit long review of proper implementation of legacy firmware support,
> so my apologise on that.
>
> Please take a look at link to the patchset posted by Tomasz.
> https://www.spinics.net/lists/arm-kernel/msg568741.html
I'll let others comment on the suitability of taking that for upstream.
>>>> So the FW will be updated accordingly.
>>
>> Indeed.
>
> Yes, it is now contains "CAVxxx" as _HID for device config object.
Which is different from the version that was merged into upstream. That
should never have happened. It will never happen again. I have spent some
time over the past few days ensuring folks understand that I will not
allow a repeat of this to occur the next time around. We will have
platforms that are bulletproof and supported by upstream with any
errata fixes in a very carefully controlled manner. There will
under no circumstances ever be a situation like this again.
>> The version Bjorn merged looks for "THRX". This is the version that you will
>> use, and you will promptly register that prefix with UEFI and provide fixes
>> for existing firmware to correctly use the solution that is upstream.
>
> Cavium FW is updated accordingly to use already registered prefix.
> For existent FW legacy support is posted by Tomasz.
I'm watching this to ensure it's cleaned up properly.
Jon.
next prev parent reply other threads:[~2017-03-16 15:03 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 16:25 [PATCH] PCI: ACPI: Fix ThunderX PEM initialization Vadim Lomovtsev
2017-01-30 17:39 ` David Daney
2017-01-30 21:12 ` Bjorn Helgaas
2017-01-31 10:28 ` Vadim Lomovtsev
2017-01-31 14:25 ` Bjorn Helgaas
2017-01-31 14:57 ` Vadim Lomovtsev
2017-01-31 20:31 ` Bjorn Helgaas
2017-02-01 12:53 ` Vadim Lomovtsev
2017-02-01 15:18 ` Bjorn Helgaas
2017-02-01 15:34 ` Vadim Lomovtsev
2017-03-15 11:14 ` Jon Masters
2017-03-15 11:33 ` Vadim Lomovtsev
2017-03-16 14:32 ` Jon Masters [this message]
2017-03-16 16:25 ` David Daney
2017-03-21 11:38 ` Jon Masters
2017-03-21 13:47 ` Bjorn Helgaas
2017-03-21 14:17 ` Tomasz Nowicki
2017-03-21 14:56 ` David Daney
2017-03-22 14:28 ` Jon Masters
2017-03-22 14:48 ` Bjorn Helgaas
2017-03-22 16:25 ` Jon Masters
2017-03-22 16:34 ` Bjorn Helgaas
2017-03-23 22:14 ` Bjorn Helgaas
2017-03-23 22:16 ` Jon Masters
2017-03-21 17:45 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=251db823-591b-483b-9c55-13c911020fd1@jonmasters.org \
--to=jcm@jonmasters.org \
--cc=David.Daney@cavium.com \
--cc=Vadim.Lomovtsev@caviumnetworks.com \
--cc=bhelgaas@google.com \
--cc=helgaas@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=stemerkhanov@CAVIUMNETWORKS.onmicrosoft.com \
--cc=tn@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).