linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: David Gow <davidgow@google.com>,
	Brendan Higgins <brendanhiggins@google.com>,
	Alan Maguire <alan.maguire@oracle.com>
Cc: Daniel Latypov <dlatypov@google.com>,
	Marco Elver <elver@google.com>,
	kunit-dev@googlegroups.com, linux-kselftest@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH kunit-fixes v5 1/4] kunit: Support skipped tests
Date: Fri, 25 Jun 2021 10:43:03 -0600	[thread overview]
Message-ID: <2521712b-fd96-04a8-dde1-30efe0fdfefb@linuxfoundation.org> (raw)
In-Reply-To: <20210625065815.322131-1-davidgow@google.com>

On 6/25/21 12:58 AM, David Gow wrote:
> The kunit_mark_skipped() macro marks the current test as "skipped", with
> the provided reason. The kunit_skip() macro will mark the test as
> skipped, and abort the test.
> 
> The TAP specification supports this "SKIP directive" as a comment after
> the "ok" / "not ok" for a test. See the "Directives" section of the TAP
> spec for details:
> https://testanything.org/tap-specification.html#directives
> 
> The 'success' field for KUnit tests is replaced with a kunit_status
> enum, which can be SUCCESS, FAILURE, or SKIPPED, combined with a
> 'status_comment' containing information on why a test was skipped.
> 
> A new 'kunit_status' test suite is added to test this.
> 
> Signed-off-by: David Gow <davidgow@google.com>
> Tested-by: Marco Elver <elver@google.com>
> Reviewed-by: Daniel Latypov <dlatypov@google.com>
> Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
> ---
> 
> Changes since v4:
> https://lore.kernel.org/linux-kselftest/20210611070802.1318911-1-davidgow@google.com/
> - Rebase on top of kselftest/kunit-fixes as of 2021-06-25
>    - This is as of commit c1610aae49 ("kunit: tool: internal refactor of parser input handling")
> 

Thank you for the rebase. Applied to kunix-fixes

thanks,
-- Shuah

      parent reply	other threads:[~2021-06-25 16:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-25  6:58 [PATCH kunit-fixes v5 1/4] kunit: Support skipped tests David Gow
2021-06-25  6:58 ` [PATCH kunit-fixes v5 2/4] kunit: tool: Support skipped tests in kunit_tool David Gow
2021-06-25  6:58 ` [PATCH kunit-fixes v5 3/4] kunit: test: Add example tests which are always skipped David Gow
2021-06-25 10:52   ` Marco Elver
2021-06-25  6:58 ` [PATCH kunit-fixes v5 4/4] kasan: test: make use of kunit_skip() David Gow
2021-06-25 16:43 ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2521712b-fd96-04a8-dde1-30efe0fdfefb@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=alan.maguire@oracle.com \
    --cc=brendanhiggins@google.com \
    --cc=davidgow@google.com \
    --cc=dlatypov@google.com \
    --cc=elver@google.com \
    --cc=kunit-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).