From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Daniel Lezcano <daniel.lezcano@linaro.org>,
Linux PM <linux-pm@vger.kernel.org>, Todd Kjos <tkjos@google.com>,
Joel Fernandes <joelaf@google.com>,
Colin Cross <ccross@android.com>,
Ramesh Thomas <ramesh.thomas@intel.com>,
Mel Gorman <mgorman@suse.de>, Ingo Molnar <mingo@redhat.com>,
Rafael Wysocki <rafael.j.wysocki@intel.com>,
Philippe Ombredanne <pombredanne@nexb.com>,
Thomas Gleixner <tglx@linutronix.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kate Stewart <kstewart@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] cpuidle/drivers/menu: Remove get_loadavg in the performance multiplier
Date: Thu, 04 Oct 2018 11:39:14 +0200 [thread overview]
Message-ID: <2531993.xoN9vA4MB0@aspire.rjw.lan> (raw)
In-Reply-To: <20181004093644.GL19272@hirez.programming.kicks-ass.net>
On Thursday, October 4, 2018 11:36:44 AM CEST Peter Zijlstra wrote:
> On Thu, Oct 04, 2018 at 10:47:04AM +0200, Rafael J. Wysocki wrote:
>
> > > The comment is irrelevant as the remaining function is used for
> > > statistics in addition to the perf multiplier. It does exactly what the
> > > function name is.
> >
> > Which is my point. It shouldn't be dropped entirely, but updated IMO.
>
> But the function name isn't the problem.. the problem that any use of
> the number is fundamentally broken.
>
We're in violent agreement here. :-)
I just wanted to say that the comment was still relevant at least with
respect to this function, but the patch was removing the comment
entirely.
next prev parent reply other threads:[~2018-10-04 9:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-04 7:42 [PATCH 1/2] sched: Factor out nr_iowait and nr_iowait_cpu Daniel Lezcano
2018-10-04 7:42 ` [PATCH 2/2] cpuidle/drivers/menu: Remove get_loadavg in the performance multiplier Daniel Lezcano
2018-10-04 7:57 ` Peter Zijlstra
2018-10-04 8:12 ` Daniel Lezcano
2018-10-04 9:35 ` Peter Zijlstra
2018-10-04 8:22 ` Rafael J. Wysocki
2018-10-04 8:40 ` Daniel Lezcano
2018-10-04 8:47 ` Rafael J. Wysocki
2018-10-04 9:36 ` Peter Zijlstra
2018-10-04 9:39 ` Rafael J. Wysocki [this message]
2018-10-04 17:16 ` Joe Perches
2018-10-04 7:46 ` [PATCH 1/2] sched: Factor out nr_iowait and nr_iowait_cpu Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2531993.xoN9vA4MB0@aspire.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=ccross@android.com \
--cc=daniel.lezcano@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=joelaf@google.com \
--cc=kstewart@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pombredanne@nexb.com \
--cc=rafael.j.wysocki@intel.com \
--cc=ramesh.thomas@intel.com \
--cc=tglx@linutronix.de \
--cc=tkjos@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).