From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932294AbbFEMYO (ORCPT ); Fri, 5 Jun 2015 08:24:14 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:62065 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752056AbbFEMYL (ORCPT ); Fri, 5 Jun 2015 08:24:11 -0400 From: Arnd Bergmann To: Gregory Fong Cc: linux-arm-kernel@lists.infradead.org, Kevin Cernekee , Russell King , open list Subject: Re: [PATCH 2/3] ARM: Remove redundant ARCH_SPARSEMEM_DEFAULT setting Date: Fri, 05 Jun 2015 14:23:30 +0200 Message-ID: <2541002.3d7fzEFzRU@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1433469518-8472-3-git-send-email-gregory.0xf0@gmail.com> References: <1433469518-8472-1-git-send-email-gregory.0xf0@gmail.com> <1433469518-8472-3-git-send-email-gregory.0xf0@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:4zzC2QTs4L1wp/8V7d8/WucZ6GxcslyAdn9AdmKnEqLVm6b9NJ6 086JisXYBBF8lWNU7LW8c5u1Ul6ebLe4stg0IZMpXV18B1weON83EI1CfXbzuWwPODuSA0D E7rEtl18wOicdpYDTLPkl4t2/iLM91vsldN/9K/E3I+qKSqRYFjxiOIkV/Z0g8zo8BRSDVb HVlWTzkN7UqVYp8MxYaLQ== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 04 June 2015 18:58:37 Gregory Fong wrote: > From: Kevin Cernekee > > If ARCH_SPARSEMEM_ENABLE=y and ARCH_{FLATMEM,DISCONTIGMEM}_ENABLE=n, > then the logic in mm/Kconfig already makes CONFIG_SPARSEMEM the only > choice. This is true for all of the existing ARM users of > ARCH_SPARSEMEM_ENABLE. > > Forcing ARCH_SPARSEMEM_DEFAULT=y if ARCH_SPARSEMEM_ENABLE=y prevents > us from ever defaulting to FLATMEM, so we should remove this setting. > > Signed-off-by: Kevin Cernekee > Signed-off-by: Gregory Fong > Acked-by: Arnd Bergmann It took me a while to understand the logic, but your patch does make a lot of sense to me now. Arnd