From: "Mickaël Salaün" <mic@digikod.net> To: James Morris <jmorris@namei.org> Cc: "Casey Schaufler" <casey@schaufler-ca.com>, linux-kernel@vger.kernel.org, "Al Viro" <viro@zeniv.linux.org.uk>, "Andy Lutomirski" <luto@amacapital.net>, "Arnd Bergmann" <arnd@arndb.de>, "Jann Horn" <jannh@google.com>, "Jonathan Corbet" <corbet@lwn.net>, "Kees Cook" <keescook@chromium.org>, "Michael Kerrisk" <mtk.manpages@gmail.com>, "Mickaël Salaün" <mickael.salaun@ssi.gouv.fr>, "Serge E . Hallyn" <serge@hallyn.com>, "Shuah Khan" <shuah@kernel.org>, "Vincent Dagonneau" <vincent.dagonneau@ssi.gouv.fr>, kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v17 05/10] fs,landlock: Support filesystem access-control Date: Thu, 14 May 2020 20:49:31 +0200 Message-ID: <2561827e-020c-9a76-98ae-9514904c69f9@digikod.net> (raw) In-Reply-To: <alpine.LRH.2.21.2005150329580.26489@namei.org> On 14/05/2020 19:31, James Morris wrote: > On Thu, 14 May 2020, Mickaël Salaün wrote: > >>> This needs to be converted to the LSM API via superblock blob stacking. >>> >>> See Casey's old patch: >>> https://lore.kernel.org/linux-security-module/20190829232935.7099-2-casey@schaufler-ca.com/ >> >> s_landlock_inode_refs is quite similar to s_fsnotify_inode_refs, but I >> can do it once the superblock security blob patch is upstream. Is it a >> blocker for now? What is the current status of lbs_superblock? > > Yes it is a blocker. Landlock should not be adding its own functions in > core code, it should be using the LSM API (and extending that as needed). OK, I'll use that in the next series. > >> Anyway, we also need to have a call to landlock_release_inodes() in >> generic_shutdown_super(), which does not fit the LSM framework, and I >> think it is not an issue. Landlock handling of inodes is quite similar >> to fsnotify. > > fsnotify is not an LSM. Yes, so I'll need to add a new LSM hook for this (release) call, right?
next prev parent reply index Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-05-11 19:21 [PATCH v17 00/10] Landlock LSM Mickaël Salaün 2020-05-11 19:21 ` [PATCH v17 01/10] landlock: Add object management Mickaël Salaün 2020-05-11 19:21 ` [PATCH v17 02/10] landlock: Add ruleset and domain management Mickaël Salaün 2020-05-14 3:09 ` James Morris 2020-05-14 10:27 ` Mickaël Salaün 2020-05-11 19:21 ` [PATCH v17 03/10] landlock: Set up the security framework and manage credentials Mickaël Salaün 2020-05-11 19:21 ` [PATCH v17 04/10] landlock: Add ptrace restrictions Mickaël Salaün 2020-05-11 19:21 ` [PATCH v17 05/10] fs,landlock: Support filesystem access-control Mickaël Salaün 2020-05-14 3:37 ` James Morris 2020-05-14 10:39 ` Mickaël Salaün 2020-05-14 15:58 ` Casey Schaufler 2020-05-14 18:46 ` Mickaël Salaün 2020-05-14 17:31 ` James Morris 2020-05-14 18:49 ` Mickaël Salaün [this message] 2020-05-14 19:37 ` James Morris 2020-05-11 19:21 ` [PATCH v17 06/10] landlock: Add syscall implementation Mickaël Salaün 2020-05-11 19:21 ` [PATCH v17 07/10] arch: Wire up landlock() syscall Mickaël Salaün 2020-05-11 19:21 ` [PATCH v17 08/10] selftests/landlock: Add initial tests Mickaël Salaün 2020-05-11 19:21 ` [PATCH v17 09/10] samples/landlock: Add a sandbox manager example Mickaël Salaün 2020-05-11 19:21 ` [PATCH v17 10/10] landlock: Add user and kernel documentation Mickaël Salaün 2020-05-11 21:54 ` [PATCH v17 00/10] Landlock LSM Mickaël Salaün
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=2561827e-020c-9a76-98ae-9514904c69f9@digikod.net \ --to=mic@digikod.net \ --cc=arnd@arndb.de \ --cc=casey@schaufler-ca.com \ --cc=corbet@lwn.net \ --cc=jannh@google.com \ --cc=jmorris@namei.org \ --cc=keescook@chromium.org \ --cc=kernel-hardening@lists.openwall.com \ --cc=linux-api@vger.kernel.org \ --cc=linux-arch@vger.kernel.org \ --cc=linux-doc@vger.kernel.org \ --cc=linux-fsdevel@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-kselftest@vger.kernel.org \ --cc=linux-security-module@vger.kernel.org \ --cc=luto@amacapital.net \ --cc=mickael.salaun@ssi.gouv.fr \ --cc=mtk.manpages@gmail.com \ --cc=serge@hallyn.com \ --cc=shuah@kernel.org \ --cc=vincent.dagonneau@ssi.gouv.fr \ --cc=viro@zeniv.linux.org.uk \ --cc=x86@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
LKML Archive on lore.kernel.org Archives are clonable: git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git git clone --mirror https://lore.kernel.org/lkml/8 lkml/git/8.git git clone --mirror https://lore.kernel.org/lkml/9 lkml/git/9.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \ linux-kernel@vger.kernel.org public-inbox-index lkml Example config snippet for mirrors Newsgroup available over NNTP: nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel AGPL code for this site: git clone https://public-inbox.org/public-inbox.git