From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E27C433E0 for ; Thu, 14 May 2020 18:49:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 1173220657 for ; Thu, 14 May 2020 18:49:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727794AbgENStf (ORCPT ); Thu, 14 May 2020 14:49:35 -0400 Received: from smtp-bc09.mail.infomaniak.ch ([45.157.188.9]:50611 "EHLO smtp-bc09.mail.infomaniak.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726778AbgENStf (ORCPT ); Thu, 14 May 2020 14:49:35 -0400 Received: from smtp-2-0000.mail.infomaniak.ch (unknown [10.5.36.107]) by smtp-2-3000.mail.infomaniak.ch (Postfix) with ESMTPS id 49NLDr72ydzlh8ns; Thu, 14 May 2020 20:49:32 +0200 (CEST) Received: from ns3096276.ip-94-23-54.eu (unknown [94.23.54.103]) by smtp-2-0000.mail.infomaniak.ch (Postfix) with ESMTPA id 49NLDq6DNjzljZmr; Thu, 14 May 2020 20:49:31 +0200 (CEST) Subject: Re: [PATCH v17 05/10] fs,landlock: Support filesystem access-control To: James Morris Cc: Casey Schaufler , linux-kernel@vger.kernel.org, Al Viro , Andy Lutomirski , Arnd Bergmann , Jann Horn , Jonathan Corbet , Kees Cook , Michael Kerrisk , =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= , "Serge E . Hallyn" , Shuah Khan , Vincent Dagonneau , kernel-hardening@lists.openwall.com, linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-security-module@vger.kernel.org, x86@kernel.org References: <20200511192156.1618284-1-mic@digikod.net> <20200511192156.1618284-6-mic@digikod.net> From: =?UTF-8?Q?Micka=c3=abl_Sala=c3=bcn?= Message-ID: <2561827e-020c-9a76-98ae-9514904c69f9@digikod.net> Date: Thu, 14 May 2020 20:49:31 +0200 User-Agent: MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Antivirus: Dr.Web (R) for Unix mail servers drweb plugin ver.6.0.2.8 X-Antivirus-Code: 0x100000 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/05/2020 19:31, James Morris wrote: > On Thu, 14 May 2020, Mickaël Salaün wrote: > >>> This needs to be converted to the LSM API via superblock blob stacking. >>> >>> See Casey's old patch: >>> https://lore.kernel.org/linux-security-module/20190829232935.7099-2-casey@schaufler-ca.com/ >> >> s_landlock_inode_refs is quite similar to s_fsnotify_inode_refs, but I >> can do it once the superblock security blob patch is upstream. Is it a >> blocker for now? What is the current status of lbs_superblock? > > Yes it is a blocker. Landlock should not be adding its own functions in > core code, it should be using the LSM API (and extending that as needed). OK, I'll use that in the next series. > >> Anyway, we also need to have a call to landlock_release_inodes() in >> generic_shutdown_super(), which does not fit the LSM framework, and I >> think it is not an issue. Landlock handling of inodes is quite similar >> to fsnotify. > > fsnotify is not an LSM. Yes, so I'll need to add a new LSM hook for this (release) call, right?