From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF60CC4332B for ; Wed, 18 Mar 2020 20:42:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BC5B42076F for ; Wed, 18 Mar 2020 20:42:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726930AbgCRUmR convert rfc822-to-8bit (ORCPT ); Wed, 18 Mar 2020 16:42:17 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:54825 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726647AbgCRUmR (ORCPT ); Wed, 18 Mar 2020 16:42:17 -0400 Received: from 1.general.jvosburgh.us.vpn ([10.172.68.206] helo=famine.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1jEfVj-0004Va-6W; Wed, 18 Mar 2020 20:41:55 +0000 Received: by famine.localdomain (Postfix, from userid 1000) id 691DB630E4; Wed, 18 Mar 2020 13:41:53 -0700 (PDT) Received: from famine (localhost [127.0.0.1]) by famine.localdomain (Postfix) with ESMTP id 5DA87AC1DD; Wed, 18 Mar 2020 13:41:53 -0700 (PDT) From: Jay Vosburgh To: Jarod Wilson cc: Eric Dumazet , LKML , Moshe Levi , Marcelo Ricardo Leitner , Netdev Subject: Re: [PATCH net] ipv6: don't auto-add link-local address to lag ports In-reply-to: References: <20200318140605.45273-1-jarod@redhat.com> <8a88d1c8-c6b1-ad85-7971-e6ae8c6fa0e4@gmail.com> Comments: In-reply-to Jarod Wilson message dated "Wed, 18 Mar 2020 14:32:52 -0400." X-Mailer: MH-E 8.6+git; nmh 1.6; GNU Emacs 27.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <25628.1584564113.1@famine> Content-Transfer-Encoding: 8BIT Date: Wed, 18 Mar 2020 13:41:53 -0700 Message-ID: <25629.1584564113@famine> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Jarod Wilson wrote: >On Wed, Mar 18, 2020 at 2:02 PM Eric Dumazet wrote: >> >> On 3/18/20 7:06 AM, Jarod Wilson wrote: >> > Bonding slave and team port devices should not have link-local addresses >> > automatically added to them, as it can interfere with openvswitch being >> > able to properly add tc ingress. >> > >> > Reported-by: Moshe Levi >> > CC: Marcelo Ricardo Leitner >> > CC: netdev@vger.kernel.org >> > Signed-off-by: Jarod Wilson >> >> >> This does not look a net candidate to me, unless the bug has been added recently ? >> >> The absence of Fixes: tag is a red flag for a net submission. >> >> By adding a Fixes: tag, you are doing us a favor, please. > >Yeah, wasn't entirely sure on this one. It fixes a problem, but it's >not exactly a new one. A quick look at git history suggests this might >actually be something that technically pre-dates the move to git in >2005, but only really became a problem with some additional far more >recent infrastructure (tc and friends). I can resubmit it as net-next >if that's preferred. Commit c2edacf80e15 bonding / ipv6: no addrconf for slaves separately from master should (in theory) already prevent ipv6 link-local addrconf, at least for bonding slaves, and dates from 2007. If something has changed to break the logic in this commit, then (a) you might need to do some research to find a candidate for your Fixes tag, and (b) I'd suggest also investigating whether or not the change added by c2edacf80e15 to addrconf_notify() no longer serves any purpose, and should be removed if that is the case. Note also that the hyperv netvsc driver, in netvsc_vf_join(), sets IFF_SLAVE in order to trigger the addrconf prevention logic from c2edacf80e15; I'm not sure if your patch would affect its expectations (if c2edacf80e15 were removed). -J --- -Jay Vosburgh, jay.vosburgh@canonical.com