From: Marcel Holtmann <marcel@holtmann.org>
To: Fabian Schindlatz <fabian.schindlatz@fau.de>
Cc: "Johan Hedberg" <johan.hedberg@gmail.com>,
linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org,
"Thomas Röthenbacher" <thomas.roethenbacher@fau.de>
Subject: Re: [PATCH] bluetooth: hci_ll: Refactor download_firmware
Date: Sat, 6 Jul 2019 12:51:28 +0200 [thread overview]
Message-ID: <25689519-DE1B-4BB6-9C36-4C73F2895E07@holtmann.org> (raw)
In-Reply-To: <20190701205713.2833-1-fabian.schindlatz@fau.de>
Hi Fabian,
> Extract the new function send_command_from_firmware from
> download_firmware, which helps with the readability of the switch
> statement. This way the code is less deeply nested and also no longer
> exceeds the 80 character limit.
>
> Co-developed-by: Thomas Röthenbacher <thomas.roethenbacher@fau.de>
> Signed-off-by: Thomas Röthenbacher <thomas.roethenbacher@fau.de>
> Signed-off-by: Fabian Schindlatz <fabian.schindlatz@fau.de>
> ---
> drivers/bluetooth/hci_ll.c | 45 ++++++++++++++++++++++++--------------
> 1 file changed, 28 insertions(+), 17 deletions(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2019-07-06 10:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-01 20:57 [PATCH] bluetooth: hci_ll: Refactor download_firmware Fabian Schindlatz
2019-07-06 10:51 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25689519-DE1B-4BB6-9C36-4C73F2895E07@holtmann.org \
--to=marcel@holtmann.org \
--cc=fabian.schindlatz@fau.de \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thomas.roethenbacher@fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).