From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1759041AbcJ1Ks5 (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Oct 2016 06:48:57 -0400
Received: from mout.kundenserver.de ([217.72.192.75]:52439 "EHLO
        mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1757307AbcJ1Ksx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Oct 2016 06:48:53 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: Yangbo Lu <yangbo.lu@nxp.com>, linux-mmc@vger.kernel.org,
        ulf.hansson@linaro.org, Scott Wood <oss@buserror.net>,
        Mark Rutland <mark.rutland@arm.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Xiaobo Xie <xiaobo.xie@nxp.com>, Minghuan Lian <minghuan.lian@nxp.com>,
        linux-i2c@vger.kernel.org, linux-clk@vger.kernel.org,
        Qiang Zhao <qiang.zhao@nxp.com>, Russell King <linux@arm.linux.org.uk>,
        Bhupesh Sharma <bhupesh.sharma@freescale.com>,
        Joerg Roedel <joro@8bytes.org>,
        Claudiu Manoil <claudiu.manoil@freescale.com>,
        devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Santosh Shilimkar <ssantosh@kernel.org>,
        linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org, Leo Li <leoyang.li@nxp.com>,
        iommu@lists.linux-foundation.org, Kumar Gala <galak@codeaurora.org>,
        Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [v15, 6/7] base: soc: introduce soc_device_match() interface
Date: Fri, 28 Oct 2016 12:47:54 +0200
Message-ID: <2572890.e6aV4hmMEL@wuerfel>
User-Agent: KMail/5.1.3 (Linux/4.4.0-34-generic; KDE/5.18.0; x86_64; ; )
In-Reply-To: <1477637418-38938-7-git-send-email-yangbo.lu@nxp.com>
References: <1477637418-38938-1-git-send-email-yangbo.lu@nxp.com> <1477637418-38938-7-git-send-email-yangbo.lu@nxp.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:u9I3TWIF+m5WjC2IUsjPdNeW/bX0A4GysxkJJU3eYJjWbQc5r6l
 lhA06IMW3jEcwYn/g6nSi/gha8iilWqNa1M1qx5Y/CMlWqrIOGjRmLTBP+EP6xhFU3rSK3j
 YbW7KRn+gQyJBZSUY4pwf7xl7l7QOTDMmi8aS29wkC2dDnJrgzM1BG57nvfnyNsl4n/1Rgz
 JdJjWPNmXsH0QAeQFtENg==
X-UI-Out-Filterresults: notjunk:1;V01:K0:s/FRLNZNBXw=:bifpXwcmGVhTuoS9tNFEjm
 i4AGCIoF07djyg8oZZAI7qnQsZlamLZWfioa3EHL4VKrUvpTELPv/3Yzup6kTFehjsoddKJeV
 koLdVCz7d90zbbyszGmhU9A6uGW4ksnKRSif5I9WOMmAX2+lp5RUVLxaN7CdH1TXXjteFJhAu
 g6NlAgMIOMzRpz2qLH2YuemEwa9iQLSAoWyNebW6THDLXujUsQJ6dvYRgYHvh7Gt1ctQZlPuI
 akRPAx/wMrNZepbURjsv5GJGAKxbx87VNuF5XpWmyr4htC5S3+XDkLScjuCCywTZPoEbT7q96
 60gMLI/QqLPyxfdo0VfxL93kkTC5XVFTrQjxsckGAOK2g0FZALwOtXAMLdiu+gz1Doklo8W+M
 dk8cKjV3sqeeD/XKL+TbNnI86jEA5gdi7DeZoM4McAtwG1jYS8iG6ssD5AP2gxHMj4nGKsUNa
 HssJMiqTKFHRQ7Qf2MNt0ZTs2qcoH9Izg7AceNPmur080ZRZHCcGuyaay2vxyJ7mg9OeAcXEf
 2lDrMQ6roS+ZpHaZYEkbg+qgAquEp3Hi+Ii08FfwAfdVwm2+nLrcuIVOZVlXIIqrww4/cqsnX
 JQUi87jhoeW0Kd/3ZW1dFFn+fYkFNct4ihAV5ZVaL5oYXZr6lg/aE/mbgcr0j32mIuafeclDV
 6/JC1DgTPIPn3vC4K1ghQMpF1i+9Vb+BEozgWY+GMR3oFIIXe0/p8yuBqCP4ZIDZb5wqgkkv7
 pyFVhW4dl4RYSibj
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Friday, October 28, 2016 2:50:17 PM CEST Yangbo Lu wrote:
> +
> +static int soc_device_match_one(struct device *dev, void *arg)
> +{
> +       struct soc_device *soc_dev = container_of(dev, struct soc_device, dev);
> +       const struct soc_device_attribute *match = arg;
> +
> +       if (match->machine &&
> +           !glob_match(match->machine, soc_dev->attr->machine))
> +               return 0;
> +
> +       if (match->family &&
> +           !glob_match(match->family, soc_dev->attr->family))
> +               return 0;
> +
> 

Geert found a bug in my code, and submitted a fix at
https://patchwork.kernel.org/patch/9361395/

I think you should include that one in your series.

	Arnd