From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964824AbcBPQKh (ORCPT <rfc822;w@1wt.eu>);
	Tue, 16 Feb 2016 11:10:37 -0500
Received: from mout.kundenserver.de ([217.72.192.74]:63860 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S964810AbcBPQKd (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 16 Feb 2016 11:10:33 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: linux-arm-kernel@lists.infradead.org
Cc: Takashi Iwai <tiwai@suse.de>, alsa-devel@alsa-project.org,
        linux-kernel@vger.kernel.org, Jaroslav Kysela <perex@perex.cz>,
        Mark Brown <broonie@kernel.org>, Han Lu <han.lu@intel.com>,
        Libin Yang <libin.yang@linux.intel.com>,
        Thierry Reding <treding@nvidia.com>,
        David Henningsson <david.henningsson@canonical.com>
Subject: Re: [PATCH] sound: hdmi: avoid dereferencing uninitialized 'jack' pointer
Date: Tue, 16 Feb 2016 17:09:43 +0100
Message-ID: <2573932.AU4HSxN0NE@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <s5hbn7g7izt.wl-tiwai@suse.de>
References: <1455634059-1896914-1-git-send-email-arnd@arndb.de> <s5hbn7g7izt.wl-tiwai@suse.de>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:B0cTaiS6sbvhS0PBDxvgL9+HtXHsbtc+DtC7KaJPwV5d2TDsgeJ
 KJ144oCtwrTVTsshgklTUp7y7UThtq9dq5i1ITk5jeSM0Oags2RkL9v1sPIRBQ17F/lHSc1
 VdbpTYU363RlhnJr6i2zqp14rUOGO1MX0bVdT+522wh674VM2xzNWlVQ70L9fK8QIfM+2MK
 UxdSstqDRNnogZVpvEMtQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:JzEdYVVQvs0=:1vShbGfQgfugmqtttA6nqG
 Rd3OiXyv2+61jWyfvHoq5CN+tR/NGDCHfTTHG418J51sRVKL1i7hWBY1oESWGjWoxI2T2JQzz
 0Bu11TpiF+EgGQQXywdlfzdfFA31kIcLeeIKMDFW3nHnZrNdVhtaXY21BsynCmRUWIk1UDwYB
 yMtMuSzcZZ+DRQYd1h+d7b19rQKOT478hmkjsJu8QTkUzUocntP9fd29S/IGwNtDstZcUjwSX
 D8VeoHbRgEwJt0iEUctkYGEfYShy4oxKcKLhm7UZHrbGVY6Aq7enfVTT4F/Phohs6umDqiuiR
 cZA1z1Xsqw6IyeBswVh21VumSoeCDwH/rTD1YYTp8EMaiycMbqZXfurAv5wndSlQC7Y2cbgAQ
 tGAZxbI2mj9hzeD8YKczUrpZSvex+3im0ELurRnGPUYxNj/pNdt5c1DB0bknkyXjvgVEwUbmh
 OQg957OSdhGdLoWXVKprWUSlEETU/Lrj2NHZXxn02vSjc2k9+LzXXmDG9VR+0vqq3oEA/1S/Z
 Q1U4XdymtO4XUNEmlH3TTy2OFb55ktOjHQSs7XlTxtlcBCMe9bIA3h8GVPuZYwleta0JIH5/U
 2ONwuWi/GCEyoiez9eCa3+fvf/n3vM/MiWV4hZN7mt7sS+2BjqEvC7VnBEDqnorVM68oPLHl1
 1NR8k+b9xCXEEeA/SJvQFFF17fIgmPvHniTK2xdNm+BiPthSnrWyswUtTC+hwODVTHBhvYQ3L
 yVtHnCvU7qg93NBj
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 16 February 2016 16:49:42 Takashi Iwai wrote:
> 
> Thanks for the patch.  But I think it's cleaner to fix Kconfig.
> 
> Thinking more of it, maybe splitting jack stuff as a separate module
> and does reverse-select to CONFIG_INPUT would be better.  Then its
> users can select simply SND_JACK, and everything would fit.
> 
> 

Adding 'select INPUT' is rather nasty, I think that can lead to circular
dependencies, and would likely upset users of small embedded systems
that want to use audio but don't want to use input.

Generally speaking, I would recommend never using 'select' on a user
visible Kconfig symbol.

Another option might would be to change snd_jack_new() to return
an error if that SND_JACK is disabled, and then require all users
to handle the error gracefully, i.e. not fail the probe() function
but just not use the jack.

	Arnd