From: Sameer Pujar <spujar@nvidia.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: <broonie@kernel.org>, <lgirdwood@gmail.com>, <robh+dt@kernel.org>,
<pierre-louis.bossart@linux.intel.com>, <perex@perex.cz>,
<tiwai@suse.com>, <thierry.reding@gmail.com>,
<jonathanh@nvidia.com>, <alsa-devel@alsa-project.org>,
<devicetree@vger.kernel.org>, <linux-tegra@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <sharadg@nvidia.com>,
<mkumard@nvidia.com>, <viswanathl@nvidia.com>,
<rlokhande@nvidia.com>, <dramesh@nvidia.com>,
<atalambedu@nvidia.com>, <nwartikar@nvidia.com>,
<swarren@nvidia.com>, <nicoleotsuka@gmail.com>
Subject: Re: [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver
Date: Fri, 2 Oct 2020 14:38:24 +0530 [thread overview]
Message-ID: <25771697-fc85-b377-ae99-a5e0957ba02d@nvidia.com> (raw)
In-Reply-To: <87362xkxdv.wl-kuninori.morimoto.gx@renesas.com>
>> Add Tegra audio machine driver which is based on generic audio graph card
>> driver. It re-uses most of the common stuff from audio graph driver and
>> uses the same DT binding. Required Tegra specific customizations are done
>> in the driver.
> (snip)
>> +static const struct snd_soc_ops tegra_audio_graph_ops = {
>> + .startup = asoc_simple_startup,
>> + .shutdown = asoc_simple_shutdown,
>> + .hw_params = tegra_audio_graph_hw_params,
>> +};
> This is just an idea,
> but can we use hooks here somehow ?
>
> .ops_hook_pre
> .ops_hook_func
> .ops_hook_post
>
> if (priv->ops_hook_pre->func)
> priv->ops_hook_pre->func_pre(...);
>
> if (priv->ops_hook_func->func)
> priv->ops_hook_func->func(...); /* driver's function */
> else
> graph_func(...); /* audio-graph function */
>
> if (priv->ops_hook_post->func)
> priv->ops_hook_post->func(...);
Right now I just required to populate some flags or structures and do
not have any specific pre()/post() functions to be called. Can this be
reserved for later?
>
>
>> +static int tegra_audio_graph_probe(struct platform_device *pdev)
>> +{
>> + struct asoc_simple_priv *priv;
>> + struct device *dev = &pdev->dev;
>> + struct snd_soc_card *card;
>> + struct link_info li;
>> + int err;
>> +
>> + /* Allocate the private data and the DAI link array */
>> + priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
>> + if (!priv)
>> + return -ENOMEM;
>> +
>> + priv->data = (struct tegra_audio_graph_data *)
>> + devm_kzalloc(dev, sizeof(*priv->data), GFP_KERNEL);
>> + if (!priv->data)
>> + return -ENOMEM;
>> +
>> + card = simple_priv_to_card(priv);
>> +
>> + card->owner = THIS_MODULE;
>> + card->dev = dev;
>> + card->component_chaining = true;
>> + card->probe = tegra_audio_graph_card_probe;
>> +
>> + priv->ops = &tegra_audio_graph_ops;
>> + priv->force_dpcm = 1;
>> +
>> + memset(&li, 0, sizeof(li));
>> + graph_get_dais_count(priv, &li);
>> + if (!li.link || !li.dais)
>> + return -EINVAL;
>> +
>> + err = asoc_simple_init_priv(priv, &li);
>> + if (err < 0)
>> + return err;
>> +
>> + err = graph_parse_of(priv);
>> + if (err < 0) {
>> + if (err != -EPROBE_DEFER)
>> + dev_err(dev, "Parse error %d\n", err);
>> + goto cleanup;
>> + }
>> +
>> + snd_soc_card_set_drvdata(card, priv);
>> +
>> + asoc_simple_debug_info(priv);
>> +
>> + err = devm_snd_soc_register_card(dev, card);
>> + if (err < 0)
>> + goto cleanup;
>> +
>> + return 0;
>> +
>> +cleanup:
>> + asoc_simple_clean_reference(card);
>> +
>> + return err;
>> +}
> These are almost same as graph_probe().
> Maybe we can separate graph_probe() and export function ?
Yes possible, I can move more stuff into graph_parse_of() which is
already an exported function in the current series. This can be utilized
by both generic audio graph and Tegra audio graph.
Something like below,
static int tegra_audio_graph_probe(struct platform_device *pdev)
{
struct tegra_audio_priv *priv;
struct device *dev = &pdev->dev;
struct snd_soc_card *card;
priv = devm_kzalloc(dev, sizeof(*priv), GFP_KERNEL);
if (!priv)
return -ENOMEM;
card = simple_priv_to_card(&priv->simple);
card->owner = THIS_MODULE;
card->dev = dev;
card->probe = tegra_audio_graph_card_probe;
/* graph_parse_of() depends on below */
card->component_chaining = 1;
priv->simple.ops = &tegra_audio_graph_ops;
priv->simple.force_dpcm = 1;
return graph_parse_of(&priv->simple);
}
Does this sound fine?
next prev parent reply other threads:[~2020-10-02 9:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 17:32 [PATCH v3 00/13] Audio graph card updates and usage with Tegra210 audio Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 01/13] ASoC: soc-core: Fix component name_prefix parsing Sameer Pujar
2020-10-01 18:53 ` Michał Mirosław
2020-10-02 8:50 ` Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 02/13] ASoC: soc-pcm: Get all BEs along DAPM path Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 03/13] ASoC: audio-graph: Use of_node and DAI for DPCM DAI link names Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 04/13] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM Sameer Pujar
2020-10-01 17:32 ` [PATCH v3 05/13] ASoC: audio-graph: Support empty Codec endpoint Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 06/13] ASoC: simple-card-utils: Expose new members for asoc_simple_priv Sameer Pujar
2020-10-02 1:45 ` Kuninori Morimoto
2020-10-02 8:59 ` Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 07/13] ASoC: audio-graph: Update driver as per new exposed members Sameer Pujar
2020-10-02 1:46 ` Kuninori Morimoto
2020-10-02 9:00 ` Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 08/13] ASoC: audio-graph: Expose helpers from audio graph Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 09/13] ASoC: dt-bindings: tegra: Add schema for audio graph card Sameer Pujar
2020-10-06 20:34 ` Rob Herring
2020-10-07 7:13 ` Sameer Pujar
2020-10-16 5:14 ` Sameer Pujar
2020-10-16 16:42 ` Mark Brown
2020-10-01 17:33 ` [PATCH v3 10/13] ASoC: tegra: Add audio graph based card driver Sameer Pujar
2020-10-01 19:07 ` Michał Mirosław
2020-10-01 19:44 ` Jon Hunter
2020-10-01 20:57 ` Dmitry Osipenko
2020-10-01 21:02 ` Dmitry Osipenko
2020-10-02 8:51 ` Sameer Pujar
2020-10-02 5:34 ` Kuninori Morimoto
2020-10-02 9:08 ` Sameer Pujar [this message]
2020-10-04 23:20 ` Kuninori Morimoto
2020-10-01 17:33 ` [PATCH v3 11/13] arm64: defconfig: Enable Tegra audio graph " Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 12/13] arm64: tegra: Audio graph header for Tegra210 Sameer Pujar
2020-10-01 17:33 ` [PATCH v3 13/13] arm64: tegra: Audio graph sound card for Jetson Nano and TX1 Sameer Pujar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25771697-fc85-b377-ae99-a5e0957ba02d@nvidia.com \
--to=spujar@nvidia.com \
--cc=alsa-devel@alsa-project.org \
--cc=atalambedu@nvidia.com \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dramesh@nvidia.com \
--cc=jonathanh@nvidia.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mkumard@nvidia.com \
--cc=nicoleotsuka@gmail.com \
--cc=nwartikar@nvidia.com \
--cc=perex@perex.cz \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=rlokhande@nvidia.com \
--cc=robh+dt@kernel.org \
--cc=sharadg@nvidia.com \
--cc=swarren@nvidia.com \
--cc=thierry.reding@gmail.com \
--cc=tiwai@suse.com \
--cc=viswanathl@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).