From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 20D9BC433DF for ; Tue, 11 Aug 2020 20:08:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F193620756 for ; Tue, 11 Aug 2020 20:08:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=mg.codeaurora.org header.i=@mg.codeaurora.org header.b="a1mtBxTU" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727006AbgHKUID (ORCPT ); Tue, 11 Aug 2020 16:08:03 -0400 Received: from mail29.static.mailgun.info ([104.130.122.29]:23126 "EHLO mail29.static.mailgun.info" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726543AbgHKUID (ORCPT ); Tue, 11 Aug 2020 16:08:03 -0400 DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1597176482; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=c+Gm6+UBSxuYp9eQxZTBOgGyHEhfY4Etd44uMrLVLZ0=; b=a1mtBxTUTfCtfNCMt/hSP6W8K3NdRCCNN3KOgxmJBqJ7f0vIiEDTxxyYdsH8BS/4NQ6bwl93 iVUkUVjQM7ny8hBh/1zQy6SsjihkQtdOfzIkQ36UOfOQsmI83JIzXmwtS0imS7P8dVRmMTRm nZd8xP+pIEANTGMtd/r8Q8M6mtk= X-Mailgun-Sending-Ip: 104.130.122.29 X-Mailgun-Sid: WyI0MWYwYSIsICJsaW51eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n06.prod.us-west-2.postgun.com with SMTP id 5f32fa881e4d3989d463c320 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Tue, 11 Aug 2020 20:07:36 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 7914CC433C9; Tue, 11 Aug 2020 20:07:35 +0000 (UTC) Received: from [10.206.24.160] (unknown [202.46.22.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: sanm) by smtp.codeaurora.org (Postfix) with ESMTPSA id D9083C433CA; Tue, 11 Aug 2020 20:07:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org D9083C433CA Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: aws-us-west-2-caf-mail-1.web.codeaurora.org; spf=none smtp.mailfrom=sanm@codeaurora.org Subject: Re: [PATCH 1/2] clk: qcom: gcc: Add genpd active wakeup flag for sc7180 To: Stephen Boyd , Andy Gross , Bjorn Andersson , Doug Anderson , Felipe Balbi , Greg Kroah-Hartman , Mark Rutland , Matthias Kaehlcke , Michael Turquette , Rob Herring Cc: linux-arm-msm@vger.kernel.org, linux-usb@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Manu Gautam , linux-clk@vger.kernel.org, Taniya Das References: <1591885683-29514-1-git-send-email-sanm@codeaurora.org> <1591885683-29514-2-git-send-email-sanm@codeaurora.org> <159191561875.242598.18326727418245335996@swboyd.mtv.corp.google.com> <159683666176.1360974.5500366475077976771@swboyd.mtv.corp.google.com> From: "Sandeep Maheswaram (Temp)" Message-ID: <257c6fbf-336f-b416-4ef7-7af83e65d0fa@codeaurora.org> Date: Wed, 12 Aug 2020 01:37:24 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <159683666176.1360974.5500366475077976771@swboyd.mtv.corp.google.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 8/8/2020 3:14 AM, Stephen Boyd wrote: > Quoting Stephen Boyd (2020-06-11 15:46:58) >> Quoting Sandeep Maheswaram (2020-06-11 07:28:02) >>> From: Taniya Das >>> >>> The USB client requires the usb30_prim gdsc to be kept active for >>> certain use cases, thus add the GENPD_FLAG_ACTIVE_WAKEUP flag. >> Can you please describe more of what this is for? Once sentence doesn't >> tell me much at all. I guess that sometimes we want to wakeup from USB >> and so the usb gdsc should be marked as "maybe keep on for wakeups" with >> the GENPD_FLAG_ACTIVE_WAKEUP flag if the USB controller is wakeup >> enabled? >> >>> Signed-off-by: Taniya Das >>> --- >> Add a Fixes: tag too? And I assume we need to do this for all USB gdscs >> on various SoCs and maybe other GDSCs like PCIe. Any plans to fix those >> GDSCs? >> > Any update here? I moved this change to usb driver code dwc3-qcom.c in v2 of this series https://patchwork.kernel.org/cover/11652281/ -- QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation