From: Heiko Stuebner <heiko@sntech.de>
To: Brian Norris <briannorris@chromium.org>
Cc: Sandy Huang <hjc@rock-chips.com>,
dri-devel@lists.freedesktop.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Sean Paul <seanpaul@chromium.org>,
Guenter Roeck <linux@roeck-us.net>,
Jeffy Chen <jeffy.chen@rock-chips.com>,
Robin Murphy <robin.murphy@arm.com>,
Vicente Bergas <vicencb@gmail.com>,
Marc Zyngier <marc.zyngier@arm.com>,
stable@vger.kernel.org
Subject: Re: [PATCH for-4.20] Revert "drm/rockchip: Allow driver to be shutdown on reboot/kexec"
Date: Tue, 11 Dec 2018 16:34:35 +0100 [thread overview]
Message-ID: <2584922.nx44hha6lV@phil> (raw)
In-Reply-To: <20181205181657.177703-1-briannorris@chromium.org>
Am Mittwoch, 5. Dezember 2018, 19:16:57 CET schrieb Brian Norris:
> This reverts commit 7f3ef5dedb146e3d5063b6845781ad1bb59b92b5.
>
> It causes new warnings [1] on shutdown when running the Google Kevin or
> Scarlet (RK3399) boards under Chrome OS. Presumably our usage of DRM is
> different than what Marc and Heiko test.
>
> We're looking at a different approach (e.g., [2]) to replace this, but
> IMO the revert should be taken first, as it already propagated to
> -stable.
>
> [1] Report here:
> http://lkml.kernel.org/lkml/20181205030127.GA200921@google.com
>
> WARNING: CPU: 4 PID: 2035 at drivers/gpu/drm/drm_mode_config.c:477 drm_mode_config_cleanup+0x1c4/0x294
> ...
> Call trace:
> drm_mode_config_cleanup+0x1c4/0x294
> rockchip_drm_unbind+0x4c/0x8c
> component_master_del+0x88/0xb8
> rockchip_drm_platform_remove+0x2c/0x44
> rockchip_drm_platform_shutdown+0x20/0x2c
> platform_drv_shutdown+0x2c/0x38
> device_shutdown+0x164/0x1b8
> kernel_restart_prepare+0x40/0x48
> kernel_restart+0x20/0x68
> ...
> Memory manager not clean during takedown.
> WARNING: CPU: 4 PID: 2035 at drivers/gpu/drm/drm_mm.c:950 drm_mm_takedown+0x34/0x44
> ...
> drm_mm_takedown+0x34/0x44
> rockchip_drm_unbind+0x64/0x8c
> component_master_del+0x88/0xb8
> rockchip_drm_platform_remove+0x2c/0x44
> rockchip_drm_platform_shutdown+0x20/0x2c
> platform_drv_shutdown+0x2c/0x38
> device_shutdown+0x164/0x1b8
> kernel_restart_prepare+0x40/0x48
> kernel_restart+0x20/0x68
> ...
>
> [2] https://patchwork.kernel.org/patch/10556151/
> https://www.spinics.net/lists/linux-rockchip/msg21342.html
> [PATCH] drm/rockchip: shutdown drm subsystem on shutdown
>
> Fixes: 7f3ef5dedb14 ("drm/rockchip: Allow driver to be shutdown on reboot/kexec")
> Cc: Jeffy Chen <jeffy.chen@rock-chips.com>
> Cc: Robin Murphy <robin.murphy@arm.com>
> Cc: Vicente Bergas <vicencb@gmail.com>
> Cc: Marc Zyngier <marc.zyngier@arm.com>
> Cc: Heiko Stuebner <heiko@sntech.de>
> Cc: stable@vger.kernel.org
> Signed-off-by: Brian Norris <briannorris@chromium.org>
So, I've applied this revert to drm-misc-fixes now, so it should still
land in 4.20-rc.
I'll resurrect Vicentes patch for a later regular inclusion as well,
but with more testing involved.
Heiko
prev parent reply other threads:[~2018-12-11 15:35 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 18:16 [PATCH for-4.20] Revert "drm/rockchip: Allow driver to be shutdown on reboot/kexec" Brian Norris
2018-12-11 15:34 ` Heiko Stuebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2584922.nx44hha6lV@phil \
--to=heiko@sntech.de \
--cc=briannorris@chromium.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=jeffy.chen@rock-chips.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux@roeck-us.net \
--cc=marc.zyngier@arm.com \
--cc=robin.murphy@arm.com \
--cc=seanpaul@chromium.org \
--cc=stable@vger.kernel.org \
--cc=vicencb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).