From: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>
To: Peter Zijlstra <peterz@infradead.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org, mingo@redhat.com
Subject: Re: [PATCH 2/2] x86/unwind/orc: Fix address check size for deref_stack_iret_regs
Date: Tue, 12 Apr 2022 13:57:35 +0300 [thread overview]
Message-ID: <258541649761055@myt5-132c43df2a33.qloud-c.yandex.net> (raw)
In-Reply-To: <YlVOAw9yUbivp7Ki@hirez.programming.kicks-ass.net>
> On Tue, Apr 12, 2022 at 10:40:04AM +0300, Dmitry Monakhov wrote:
>
>> For historical reasons we check only IRET_FRAME_OFFSET, but this check
>> is no longer valid because we also access regs->sp field which is
>> located beyond IRET_FRAME, so it is reasonable to validate full structure.
>
> Uuuh, what? IRET frame is:
>
> ss, sp, flags, cs, ip
>
> that very much includes sp.
Oh. Indeed you are right. Sorry. Please ignore this patch.
next prev parent reply other threads:[~2022-04-12 12:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-12 7:40 [PATCH 1/2] x86/unwind/orc: recheck address range after stack info was updated Dmitry Monakhov
2022-04-12 7:40 ` [PATCH 2/2] x86/unwind/orc: Fix address check size for deref_stack_iret_regs Dmitry Monakhov
2022-04-12 10:01 ` Peter Zijlstra
2022-04-12 10:57 ` Dmitry Monakhov [this message]
2022-04-12 10:08 ` [PATCH 1/2] x86/unwind/orc: recheck address range after stack info was updated Peter Zijlstra
2022-04-16 0:49 ` Josh Poimboeuf
2022-04-29 5:14 ` [PATCH] perf/amd/ibs: Use interrupt regs ip for stack unwinding Ravi Bangoria
2022-04-29 20:28 ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
2022-05-02 6:07 ` [PATCH] " Namhyung Kim
2022-05-04 9:23 ` [tip: perf/core] " tip-bot2 for Ravi Bangoria
2022-05-10 9:11 ` tip-bot2 for Ravi Bangoria
2022-04-12 10:11 ` [PATCH 1/2] x86/unwind/orc: recheck address range after stack info was updated Peter Zijlstra
2022-04-14 15:18 ` Josh Poimboeuf
2022-04-16 0:46 ` Josh Poimboeuf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=258541649761055@myt5-132c43df2a33.qloud-c.yandex.net \
--to=dmtrmonakhov@yandex-team.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).