From: "Rémi Denis-Courmont" <remi@remlab.net>
To: Vito Caputo <vcaputo@pengaru.com>
Cc: netdev@vger.kernel.org, courmisch@gmail.com, davem@davemloft.net,
kuba@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: kernel BUG at net/phonet/socket.c:LINE!
Date: Mon, 13 Apr 2020 09:01:58 +0300 [thread overview]
Message-ID: <2585533.60Y2ixrnJE@basile.remlab.net> (raw)
In-Reply-To: <20200413054914.euz7g2fcxsr74lfm@shells.gnugeneration.com>
Le maanantaina 13. huhtikuuta 2020, 8.49.14 EEST Vito Caputo a écrit :
> > If we are to distinguish the two error scenarii, then it's the rebind
> > case
> > that needs a different error, but EINVAL is consistent with INET.
>
> Isn't the existing code is bugged if treating -EINVAL as valid and a rebind?
>
> The invalid size will return a NULL sobject but -EINVAL, triggering the
> BUG_ON.
How do you pass an invalid size? It's a constant `sizeof(struct sockaddr_pn)`
in that code path.
--
Rémi Denis-Courmont
Tapiolan uusi kaupunki, Uudenmaan tasavalta
next prev parent reply other threads:[~2020-04-13 6:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 7:16 kernel BUG at net/phonet/socket.c:LINE! syzbot
2020-04-11 0:43 ` Vito Caputo
2020-04-11 7:36 ` Rémi Denis-Courmont
2020-04-13 5:49 ` Vito Caputo
2020-04-13 6:01 ` Rémi Denis-Courmont [this message]
2020-04-13 6:05 ` Vito Caputo
2021-12-19 14:58 ` [syzbot] " syzbot
2021-12-19 21:09 ` Pavel Skripkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2585533.60Y2ixrnJE@basile.remlab.net \
--to=remi@remlab.net \
--cc=courmisch@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vcaputo@pengaru.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).