From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S262102AbUKBQlK (ORCPT ); Tue, 2 Nov 2004 11:41:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261855AbUKBQer (ORCPT ); Tue, 2 Nov 2004 11:34:47 -0500 Received: from mx1.redhat.com ([66.187.233.31]:41601 "EHLO mx1.redhat.com") by vger.kernel.org with ESMTP id S261936AbUKBQeP (ORCPT ); Tue, 2 Nov 2004 11:34:15 -0500 From: David Howells In-Reply-To: <20041102094827.GD5841@infradead.org> References: <20041102094827.GD5841@infradead.org> <76b4a884-2c3c-11d9-91a1-0002b3163499@redhat.com> <200411011930.iA1JUL1K023209@warthog.cambridge.redhat.com> To: Christoph Hellwig Cc: torvalds@osdl.org, akpm@osdl.org, davidm@snapgear.com, linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org Subject: Re: [PATCH 8/14] FRV: GP-REL data support User-Agent: EMH/1.14.1 SEMI/1.14.5 (Awara-Onsen) FLIM/1.14.5 (Demachiyanagi) APEL/10.6 Emacs/21.3 (i386-redhat-linux-gnu) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.5 - "Awara-Onsen") Content-Type: text/plain; charset=US-ASCII Date: Tue, 02 Nov 2004 16:34:01 +0000 Message-ID: <25976.1099413241@redhat.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org > > +#ifdef CONFIG_FRV > > +#define __jiffy_data __attribute__((section(".data"))) > > +#else > > +#define __jiffy_data > > +#endif > > please avoid per-arch ifdefs in common code, this needs to go into some asm/ > header, or and __ARCH_HAVE_FOO ifdef. You're advocating using an ifdef? I thought you hated the things... I want to avoid changing every other arch. > Anyway, would doing this unconditionally cause any problems? Not as far as I know. > > +#ifndef __ASSEMBLY__ > > +extern const char linux_banner[]; > > +#endif > > totally wrong place. this is not about linkage at all. Actually, it's almost entirely about linkage:-) But in this case, you may be right. Anyone any suggestions as to the right place for this? linux/kernel.h perhaps? David